Commit 453adc54 authored by Charlie Harrison's avatar Charlie Harrison Committed by Commit Bot

Remove SB2.RemoteCall.CheckDispatchTime

Bug: 900062,839190
Change-Id: I0b5ed1f711a221790cfe0f2ee40842a46556e50c
Reviewed-on: https://chromium-review.googlesource.com/c/1308034Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Reviewed-by: default avatarVarun Khaneja <vakh@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604398}
parent f888d68b
...@@ -13,8 +13,6 @@ ...@@ -13,8 +13,6 @@
#include "base/containers/flat_set.h" #include "base/containers/flat_set.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
#include "base/task/post_task.h" #include "base/task/post_task.h"
#include "base/time/time.h"
#include "base/timer/elapsed_timer.h"
#include "base/trace_event/trace_event.h" #include "base/trace_event/trace_event.h"
#include "components/safe_browsing/android/safe_browsing_api_handler_util.h" #include "components/safe_browsing/android/safe_browsing_api_handler_util.h"
#include "components/safe_browsing/db/v4_protocol_manager_util.h" #include "components/safe_browsing/db/v4_protocol_manager_util.h"
...@@ -200,15 +198,8 @@ void SafeBrowsingApiHandlerBridge::StartURLCheck( ...@@ -200,15 +198,8 @@ void SafeBrowsingApiHandlerBridge::StartURLCheck(
ScopedJavaLocalRef<jintArray> j_threat_types = ScopedJavaLocalRef<jintArray> j_threat_types =
SBThreatTypeSetToJavaArray(env, threat_types); SBThreatTypeSetToJavaArray(env, threat_types);
base::ElapsedTimer check_timer;
Java_SafeBrowsingApiBridge_startUriLookup(env, j_api_handler_, callback_id, Java_SafeBrowsingApiBridge_startUriLookup(env, j_api_handler_, callback_id,
j_url, j_threat_types); j_url, j_threat_types);
// TODO(vakh): The following metric isn't very useful now since the
// |startUriLookup| method simply posts a task and adds listeners now.
// Continue to monitor it to ensure that it keeps falling and then remove it
// when it is consistently a low value. (https://crbug.com/839190)
UMA_HISTOGRAM_COUNTS_10M("SB2.RemoteCall.CheckDispatchTime",
check_timer.Elapsed().InMicroseconds());
} }
} // namespace safe_browsing } // namespace safe_browsing
...@@ -91375,6 +91375,9 @@ uploading your change for review. ...@@ -91375,6 +91375,9 @@ uploading your change for review.
</histogram> </histogram>
<histogram name="SB2.RemoteCall.CheckDispatchTime" units="microseconds"> <histogram name="SB2.RemoteCall.CheckDispatchTime" units="microseconds">
<obsolete>
Deprecated Oct 2018
</obsolete>
<owner>csharrison@chromium.org</owner> <owner>csharrison@chromium.org</owner>
<owner>vakh@chromium.org</owner> <owner>vakh@chromium.org</owner>
<summary> <summary>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment