GitLab

Cosmetic cleanup of CRWWebController.

- removed using base::UserMetricsAction (does not improve formatting)
- removed UMA constants (there is a presubmit script for UMA strings,
  which does not work with constants)
- removed _delegate ivar and -delegate method (this is now a property)
- removed -isLoaded method as unused
- removed setNativeController: predeclaration (duplicates property)
- removed the usage of |new|
- cleaned up scrollPosition (it's ok to call methods on nil self.webScrollView)
- use NavigationManager instead of web::NavigationManager
- removed unused currentURL local variable
- assign nullptr to _lastUserInteraction instead of nil
- s/url/URL
- s/message_frame_origin/messageFrameOrigin
- removed dead code from handleLoadError:forNavigation:
- s/self.webStateImpl->GetNavigationManagerImpl()/self.navigationManagerImpl
- s/self.userAgentType/[self userAgentType] (not a property)

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie264e71b0726eacc13c61794535aa55a1b83be06
Reviewed-on: https://chromium-review.googlesource.com/1029612Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554400}