Commit 4542ea08 authored by peter's avatar peter Committed by Commit bot

Remove Notification::small_image_url_ as it has no users.

Also removes two methods from Notification which only forward calls
to the delegate, and have a single call-site.

BUG=

Review URL: https://codereview.chromium.org/574273003

Cr-Commit-Position: refs/heads/master@{#295499}
parent 350ce8af
...@@ -408,7 +408,7 @@ void MessageCenterNotificationManager::ImageDownloads::StartDownloadWithImage( ...@@ -408,7 +408,7 @@ void MessageCenterNotificationManager::ImageDownloads::StartDownloadWithImage(
if (url.is_empty()) if (url.is_empty())
return; return;
content::WebContents* contents = notification.GetWebContents(); content::WebContents* contents = notification.delegate()->GetWebContents();
if (!contents) { if (!contents) {
LOG(WARNING) << "Notification needs an image but has no WebContents"; LOG(WARNING) << "Notification needs an image but has no WebContents";
return; return;
...@@ -479,7 +479,7 @@ void MessageCenterNotificationManager::ProfileNotification::StartDownloads() { ...@@ -479,7 +479,7 @@ void MessageCenterNotificationManager::ProfileNotification::StartDownloads() {
void void
MessageCenterNotificationManager::ProfileNotification::OnDownloadsCompleted() { MessageCenterNotificationManager::ProfileNotification::OnDownloadsCompleted() {
notification_.DoneRendering(); notification_.delegate()->ReleaseRenderViewHost();
} }
void void
......
...@@ -74,11 +74,6 @@ class Notification : public message_center::Notification { ...@@ -74,11 +74,6 @@ class Notification : public message_center::Notification {
// Id of the delegate embedded inside this instance. // Id of the delegate embedded inside this instance.
std::string delegate_id() const { return delegate()->id(); } std::string delegate_id() const { return delegate()->id(); }
content::WebContents* GetWebContents() const {
return delegate()->GetWebContents();
}
void DoneRendering() { delegate()->ReleaseRenderViewHost(); }
NotificationDelegate* delegate() const { return delegate_.get(); } NotificationDelegate* delegate() const { return delegate_.get(); }
private: private:
...@@ -96,9 +91,6 @@ class Notification : public message_center::Notification { ...@@ -96,9 +91,6 @@ class Notification : public message_center::Notification {
// The URL of a large image to be displayed for a a rich notification. // The URL of a large image to be displayed for a a rich notification.
GURL image_url_; GURL image_url_;
// The URL of a small image to be displayed for a a rich notification.
GURL small_image_url_;
// The user-supplied replace ID for the notification. // The user-supplied replace ID for the notification.
base::string16 replace_id_; base::string16 replace_id_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment