Commit 45436d4d authored by Ayu Ishii's avatar Ayu Ishii Committed by Commit Bot

CookieStore: WPT to verify subscribe/unsubscribe is idempotent

This change adds a wpt to test that subscribe/unsubscribe
is idempotent.

Bug: 729800
Change-Id: I3744b06ea53c4839ac1f82f3fd2241d0bd4d9e2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207584
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770412}
parent 54289f85
......@@ -64,3 +64,86 @@ promise_test(async testCase => {
registration.cookies.subscribe(
{ name: 'cookie-name', matchType: 'equals', url: '/wrong/path' }));
}, 'cookieStore.subscribe with invalid url path in option');
promise_test(async testCase => {
if (self.GLOBAL.isWindow()) {
const registration = await service_worker_unregister_and_register(
testCase, 'resources/empty_sw.js',
'/cookie-store/resources/does/not/exist');
testCase.add_cleanup(() => registration.unregister());
// Must wait for the service worker to enter the 'activated' state before
// subscribing to cookiechange events.
await wait_for_state(testCase, registration.installing, 'activated');
self.registration = registration;
} else if (!self.registration.active) {
// Must wait for the service worker to enter the 'activated' state before
// subscribing to cookiechange events.
await new Promise(resolve => {
self.addEventListener('activate', event => { resolve(); });
});
}
{
const subscriptions = [
{ name: 'cookie-name', matchType: 'equals' }
];
// Call subscribe for same subscription multiple times to verify that it is
// idempotent.
await self.registration.cookies.subscribe(subscriptions);
await self.registration.cookies.subscribe(subscriptions);
await self.registration.cookies.subscribe(subscriptions);
testCase.add_cleanup(() => registration.cookies.unsubscribe(subscriptions));
}
const subscriptions = await registration.cookies.getSubscriptions();
assert_equals(subscriptions.length, 1);
assert_equals(subscriptions[0].name, 'cookie-name');
assert_equals(subscriptions[0].matchType, 'equals');
assert_equals(subscriptions[0].url, registration.scope);
}, 'cookieStore.subscribe is idempotent');
promise_test(async testCase => {
if (self.GLOBAL.isWindow()) {
const registration = await service_worker_unregister_and_register(
testCase, 'resources/empty_sw.js',
'/cookie-store/resources/does/not/exist');
testCase.add_cleanup(() => registration.unregister());
// Must wait for the service worker to enter the 'activated' state before
// subscribing to cookiechange events.
await wait_for_state(testCase, registration.installing, 'activated');
self.registration = registration;
} else if (!self.registration.active) {
// Must wait for the service worker to enter the 'activated' state before
// subscribing to cookiechange events.
await new Promise(resolve => {
self.addEventListener('activate', event => { resolve(); });
});
}
{
const subscriptions = [
{ name: 'cookie-name1', matchType: 'equals' },
{ name: 'cookie-name2', matchType: 'equals' }
];
await self.registration.cookies.subscribe(subscriptions);
testCase.add_cleanup(() => registration.cookies.unsubscribe(subscriptions));
// Call unsubscribe for same subscription multiple times to verify that it
// is idempotent.
await registration.cookies.unsubscribe([subscriptions[0]]);
await registration.cookies.unsubscribe([subscriptions[0]]);
await registration.cookies.unsubscribe([subscriptions[0]]);
}
const subscriptions = await registration.cookies.getSubscriptions();
assert_equals(subscriptions.length, 1);
assert_equals(subscriptions[0].name, 'cookie-name2');
assert_equals(subscriptions[0].matchType, 'equals');
assert_equals(subscriptions[0].url, registration.scope);
}, 'CookieStore.unsubscribe is idempotent');
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment