Commit 4562d24d authored by Jeff Carpenter's avatar Jeff Carpenter Committed by Commit Bot

[WPT Export] Update docs

- Update instructions for new Gerrit provisional PR flow
- Split out necessary information from additional information
- Add note that CLs with >1000 files will not be exported
- Rephrase a lot of things

Bug: 
Change-Id: Ie40bdd4ca39b5efaf63fa7341d9df861d16e84dc
Reviewed-on: https://chromium-review.googlesource.com/567592
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: default avatarQuinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486904}
parent bc991410
...@@ -63,20 +63,38 @@ can fix it manually. ...@@ -63,20 +63,38 @@ can fix it manually.
### Automatic export process ### Automatic export process
If a commit to Chromium master changes any files in the If you upload a CL with any changes in
[third_party/WebKit/LayoutTests/external/wpt](../../third_party/WebKit/LayoutTests/external/wpt) [third_party/WebKit/LayoutTests/external/wpt](../../third_party/WebKit/LayoutTests/external/wpt),
directory, the WPT Exporter will create a Pull Request on GitHub for it. once you add reviewers the exporter will create a provisional pull request with
All PRs use the `chromium-export` label: see those changes in the [upstream WPT GitHub repository](https://github.com/w3c/web-platform-tests/).
[all of them here](https://github.com/w3c/web-platform-tests/pulls?utf8=%E2%9C%93&q=is%3Apr%20label%3Achromium-export).
The exporter runs continuously under the chromium.infra.cron master: Once you're ready to land your CL, please check the Travis CI status on the
see [all recent builds](https://build.chromium.org/p/chromium.infra.cron/builders/wpt-exporter). upstream PR (link at the bottom of the page). If it's green, go ahead and land your CL
The source for the exporter lives in and the exporter will automatically remove the "do not merge yet" label and merge the PR.
[third_party/WebKit/Tools/Scripts/wpt-exporter](../../third_party/WebKit/Tools/Scripts/wpt-exporter).
If Travis CI is red on the upstream PR, please try to resolve the failures before
In the unlikely event that the exporter starts misbehaving -- for example, merging. If you run into Travis CI issues, or if you have a CL with WPT changes that
creating the same PR over and over again -- **all you need to do to disable the the exporter did not pick up, please reach out to ecosystem-infra@chromium.org.
exporter is [land this CL](https://chromium-review.googlesource.com/c/462381/)**,
which will put it in "dry run" mode. Additional things to note:
- CLs that change over 1000 files will not be exported.
- All PRs use the
[`chromium-export`](https://github.com/w3c/web-platform-tests/pulls?utf8=%E2%9C%93&q=is%3Apr%20label%3Achromium-export) label.
- All PRs for CLs that haven't yet been landed in Chromium also use the
[`do not merge yet`](https://github.com/w3c/web-platform-tests/pulls?q=is%3Apr+is%3Aopen+label%3A%22do+not+merge+yet%22) label.
- The exporter cannot create upstream PRs for in-flight CLs with binary files (e.g. webm files).
An export PR will still be made after the CL lands.
For maintainers:
- The exporter runs continuously under the
[chromium.infra.cron master](https://build.chromium.org/p/chromium.infra.cron/builders/wpt-exporter).
- The source lives in
[third_party/WebKit/Tools/Scripts/wpt-exporter](../../third_party/WebKit/Tools/Scripts/wpt-exporter).
- If the exporter starts misbehaving
(for example, creating the same PR over and over again)
put it in "dry run" mode by landing [this CL](https://crrev.com/c/462381/).
### Skipped tests ### Skipped tests
......
...@@ -238,7 +238,10 @@ class TestExporter(object): ...@@ -238,7 +238,10 @@ class TestExporter(object):
'the WPT Importer is blocked from operating.\n\n' 'the WPT Importer is blocked from operating.\n\n'
'(There is ongoing work to 1. prevent CLs with red upstream PRs from landing ' '(There is ongoing work to 1. prevent CLs with red upstream PRs from landing '
'(https://crbug.com/711447) and 2. prevent the importer from being blocked on ' '(https://crbug.com/711447) and 2. prevent the importer from being blocked on '
'stuck exportable changes (https://crbug.com/734121))' 'stuck exportable changes (https://crbug.com/734121))\n\n'
'WPT Export docs:\n'
'https://chromium.googlesource.com/chromium/src/+/master'
'/docs/testing/web_platform_tests.md#Automatic-export-process'
).format( ).format(
pr_url='%spull/%d' % (WPT_GH_URL, response_data['number']) pr_url='%spull/%d' % (WPT_GH_URL, response_data['number'])
)) ))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment