Reland "DevTools: Block SIGPROF during CPU throttling"
This is a reland of a5afd47a Original change's description: > DevTools: Block SIGPROF during CPU throttling > > The V8 CPU profiler schedules SIGPROF signals. It is very likely that > the signal handler for these will run while the throttling signal > handler is already running. V8 can't properly read the stack when > there is already a signal handler present. > > Fix this by using sa_mask to block V8's SIGPROFs while the > throttling handler is running. This makes more sense overall as well. > Our CPU samples would be skewed by whichever stacks we encounter > during throttling pauses. > > Bug: 1027242 > Change-Id: I80e856ce1e7b4744a9af7e36c2022b6d8610cf60 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012280 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733592} Bug: 1027242 Change-Id: I2c5c1e462f9f6f16739e773dda112bacd8b354f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014404 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#734429}
Showing
Please register or sign in to comment