feedback: Fix lint errors.

Fix the following classes of lint errors

For i18n-content use javaScriptCase.
Found lines longer than 80 characters

This CL was generated manually, using code-search to double-check that
all references were updated.

BUG=None
TEST=Deploy to eve, check feedback dialog

Change-Id: Iaaf3d565fafcca251096fe97b48a3a4f363d8f61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869995Reviewed-by: J Kardatzke <jkardatzke@chromium.org>
Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708043}

chrome/browser/extensions/api/feedback_private/chrome_feedback_private_delegate.cc

@@ -73,29 +73,28 @@ ChromeFeedbackPrivateDelegate::GetStrings(
                                ? IDS_FEEDBACK_REPORT_PAGE_TITLE_SAD_TAB_FLOW
                                : IDS_FEEDBACK_REPORT_PAGE_TITLE);
   SET_STRING("additionalInfo", IDS_FEEDBACK_ADDITIONAL_INFO_LABEL);
-  SET_STRING("minimize-btn-label", IDS_FEEDBACK_MINIMIZE_BUTTON_LABEL);
-  SET_STRING("close-btn-label", IDS_FEEDBACK_CLOSE_BUTTON_LABEL);
-  SET_STRING("page-url", IDS_FEEDBACK_REPORT_URL_LABEL);
+  SET_STRING("minimizeBtnLabel", IDS_FEEDBACK_MINIMIZE_BUTTON_LABEL);
+  SET_STRING("closeBtnLabel", IDS_FEEDBACK_CLOSE_BUTTON_LABEL);
+  SET_STRING("pageUrl", IDS_FEEDBACK_REPORT_URL_LABEL);
   SET_STRING("screenshot", IDS_FEEDBACK_SCREENSHOT_LABEL);
   SET_STRING("screenshotA11y", IDS_FEEDBACK_SCREENSHOT_A11Y_TEXT);
-  SET_STRING("user-email", IDS_FEEDBACK_USER_EMAIL_LABEL);
-  SET_STRING("anonymous-user", IDS_FEEDBACK_ANONYMOUS_EMAIL_OPTION);
-  SET_STRING("sys-info", GetSysInfoCheckboxStringId(browser_context));
-  SET_STRING("assistant-info",
+  SET_STRING("userEmail", IDS_FEEDBACK_USER_EMAIL_LABEL);
+  SET_STRING("anonymousUser", IDS_FEEDBACK_ANONYMOUS_EMAIL_OPTION);
+  SET_STRING("sysInfo", GetSysInfoCheckboxStringId(browser_context));
+  SET_STRING("assistantInfo",
              IDS_FEEDBACK_INCLUDE_ASSISTANT_INFORMATION_CHKBOX);
-  SET_STRING("attach-file-label", IDS_FEEDBACK_ATTACH_FILE_LABEL);
-  SET_STRING("attach-file-note", IDS_FEEDBACK_ATTACH_FILE_NOTE);
-  SET_STRING("attach-file-to-big", IDS_FEEDBACK_ATTACH_FILE_TO_BIG);
-  SET_STRING("reading-file", IDS_FEEDBACK_READING_FILE);
-  SET_STRING("send-report", IDS_FEEDBACK_SEND_REPORT);
+  SET_STRING("attachFileLabel", IDS_FEEDBACK_ATTACH_FILE_LABEL);
+  SET_STRING("attachFileNote", IDS_FEEDBACK_ATTACH_FILE_NOTE);
+  SET_STRING("attachFileToBig", IDS_FEEDBACK_ATTACH_FILE_TO_BIG);
+  SET_STRING("sendReport", IDS_FEEDBACK_SEND_REPORT);
   SET_STRING("cancel", IDS_CANCEL);
-  SET_STRING("no-description", IDS_FEEDBACK_NO_DESCRIPTION);
-  SET_STRING("privacy-note", IDS_FEEDBACK_PRIVACY_NOTE);
-  SET_STRING("performance-trace",
+  SET_STRING("noDescription", IDS_FEEDBACK_NO_DESCRIPTION);
+  SET_STRING("privacyNote", IDS_FEEDBACK_PRIVACY_NOTE);
+  SET_STRING("performanceTrace",
              IDS_FEEDBACK_INCLUDE_PERFORMANCE_TRACE_CHECKBOX);
-  SET_STRING("bluetooth-logs-info", IDS_FEEDBACK_BLUETOOTH_LOGS_CHECKBOX);
-  SET_STRING("bluetooth-logs-message", IDS_FEEDBACK_BLUETOOTH_LOGS_MESSAGE);
-  SET_STRING("assistant-logs-message", IDS_FEEDBACK_ASSISTANT_LOGS_MESSAGE);
+  SET_STRING("bluetoothLogsInfo", IDS_FEEDBACK_BLUETOOTH_LOGS_CHECKBOX);
+  SET_STRING("bluetoothLogsMessage", IDS_FEEDBACK_BLUETOOTH_LOGS_MESSAGE);
+  SET_STRING("assistantLogsMessage", IDS_FEEDBACK_ASSISTANT_LOGS_MESSAGE);
 
   // Add the localized strings needed for the "system information" page.
   SET_STRING("sysinfoPageTitle", IDS_FEEDBACK_SYSINFO_PAGE_TITLE);

chrome/browser/resources/feedback/html/assistant_logs_info.html

@@ -14,12 +14,12 @@
     <span class="topbutton-bar">
       <button class="close-button"
               id="assistant-close-button" tabindex="-1"
-              i18n-values="aria-label:close-btn-label">
+              i18n-values="aria-label:closeBtnLabel">
       </button>
     </span>
   </div>
   <div id="assistant-logs-info-container">
-  <span i18n-content="assistant-logs-message"></span>
+  <span i18n-content="assistantLogsMessage"></span>
   </div>
 </body>
 </html>

chrome/browser/resources/feedback/html/bluetooth_logs_info.html

@@ -5,7 +5,7 @@
   </head>
   <body>
     <div id="bluetooth-logs-info-container">
-      <span i18n-content="bluetooth-logs-message"></span>
+      <span i18n-content="bluetoothLogsMessage"></span>
     </div>
   </body>
 <html>

chrome/browser/resources/feedback/html/default.html

@@ -4,7 +4,8 @@
 <meta charset="utf-8">
 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">
 <link rel="stylesheet" href="chrome://resources/css/apps/common.css"></link>
-<link rel="stylesheet" href="chrome://resources/css/apps/topbutton_bar.css"></link>
+<link rel="stylesheet" href="chrome://resources/css/apps/topbutton_bar.css">
+</link>
 <link rel="stylesheet" href="../css/feedback.css">
 
 <script src="chrome://resources/js/load_time_data.js"></script>
@@ -20,10 +21,10 @@
     <span id="page-title" i18n-content="page-title"></span>
     <span class="topbutton-bar">
       <button class="minimize-button" id="minimize-button" tabindex="-1"
-              i18n-values="aria-label:minimize-btn-label">
+              i18n-values="aria-label:minimizeBtnLabel">
       </button>
       <button class="close-button" id="close-button" tabindex="-1"
-              i18n-values="aria-label:close-btn-label">
+              i18n-values="aria-label:closeBtnLabel">
       </button>
     </span>
   </div>
@@ -33,20 +34,20 @@
       <p id="additional-info-label" i18n-content="additionalInfo"><p>
     </div>
     <div id="page-url" class="text-field-container">
-      <label id="page-url-label" i18n-content="page-url"></label>
+      <label id="page-url-label" i18n-content="pageUrl"></label>
       <input id="page-url-text" aria-labelledby="page-url-label" type="text">
     </div>
     <!-- User e-mail -->
     <div id="user-email" class="text-field-container" hidden>
-      <label id="user-email-label" i18n-content="user-email"></label>
+      <label id="user-email-label" i18n-content="userEmail"></label>
       <select id="user-email-drop-down" aria-labelledby="user-email-label">
         <option id="anonymous-user-option" value="anonymous_user"
-                i18n-content="anonymous-user"></option>
+                i18n-content="anonymousUser"></option>
       </select>
     </div>
     <!-- Attach a file -->
     <div id="attach-file-container" class="text-field-container">
-      <label id="attach-file-label" i18n-content="attach-file-label"></label>
+      <label id="attach-file-label" i18n-content="attachFileLabel"></label>
       <input id="attach-file" type="file" aria-labelledby="attach-file-label"
            aria-describedby="attach-file-note">
       <div id="custom-file-container" hidden>
@@ -54,9 +55,9 @@
         <button id="remove-attached-file" class="remove-file-button"></button>
       </div>
       <div id="attach-error" class="attach-file-notification"
-          role="alert" i18n-content="attach-file-to-big" hidden></div>
+          role="alert" i18n-content="attachFileToBig" hidden></div>
     </div>
-    <div id="attach-file-note" i18n-content="attach-file-note"
+    <div id="attach-file-note" i18n-content="attachFileNote"
       aria-hidden="true"></div>
     <!-- Screenshot -->
     <div id="screenshot-container" class="checkbox-field-container">
@@ -67,31 +68,35 @@
     </div>
     <!-- System Information -->
     <div id="sys-info-container" class="checkbox-field-container">
-      <input id="sys-info-checkbox" type="checkbox" aria-labelledby="sys-info-label" checked>
-      <label id="sys-info-label" i18n-values=".innerHTML:sys-info"></label>
+      <input id="sys-info-checkbox" type="checkbox"
+             aria-labelledby="sys-info-label" checked>
+      <label id="sys-info-label" i18n-values=".innerHTML:sysInfo"></label>
     </div>
 <if expr="chromeos">
     <!-- Assistant Debug Logs (Googler Internal Only) -->
-    <div id="assistant-checkbox-container" class="checkbox-field-container" hidden>
-      <input id="assistant-info-checkbox" type="checkbox" checked aria-labelledby="assistant-info-label">
-      <label id="assistant-info-label" i18n-values=".innerHTML:assistant-info"></label>
+    <div id="assistant-checkbox-container" class="checkbox-field-container"
+         hidden>
+      <input id="assistant-info-checkbox" type="checkbox"
+             checked aria-labelledby="assistant-info-label">
+      <label id="assistant-info-label"
+             i18n-values=".innerHTML:assistantInfo"></label>
     </div>
     <!-- Bluetooth Logs (Googler Internal Only) -->
     <div id="bluetooth-checkbox-container" class="checkbox-field-container"
       hidden>
       <input id="bluetooth-logs-checkbox" type="checkbox" checked>
       <label id="bluetooth-info-label"
-        i18n-values=".innerHTML:bluetooth-logs-info"></label>
+        i18n-values=".innerHTML:bluetoothLogsInfo"></label>
     </div>
     <!-- Performance Feedback -->
     <div id="performance-info-area" hidden>
       <input id="performance-info-checkbox" type="checkbox">
-      <a id="performance-info-link" href="#" i18n-content="performance-trace">
+      <a id="performance-info-link" href="#" i18n-content="performanceTrace">
       </a>
     </div>
 </if>
     <!-- Privacy note -->
-    <div id="privacy-note" i18n-values=".innerHTML:privacy-note"></div>
+    <div id="privacy-note" i18n-values=".innerHTML:privacyNote"></div>
   </div>
   <!-- Buttons -->
   <div id="bottom-buttons-container" class="content">
@@ -100,7 +105,7 @@
           class="white-button" i18n-content="cancel">
       </button>
       <button id="send-report-button" type="submit"
-          class="blue-button" i18n-content="send-report">
+          class="blue-button" i18n-content="sendReport">
       </button>
     </div>
   </div>

chrome/browser/resources/feedback/js/feedback.js

@@ -183,7 +183,7 @@ function checkForBluetoothKeywords(inputEvent) {
 function sendReport() {
   if ($('description-text').value.length == 0) {
     const description = $('description-text');
-    description.placeholder = loadTimeData.getString('no-description');
+    description.placeholder = loadTimeData.getString('noDescription');
     description.focus();
     return false;
   }