Commit 458e00cb authored by My Nguyen's avatar My Nguyen Committed by Commit Bot

Update description in smart inputs setting page

Current view: http://screen/ezJ6xsn1Y9c
Mock view: http://go/personal-info-settings-mock

Bug: 1100741
Change-Id: I8b98eeda19d31f30317fd34895dc55aa0caae634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275435
Commit-Queue: My Nguyen <myy@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Auto-Submit: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784180}
parent 565a4161
...@@ -282,10 +282,10 @@ ...@@ -282,10 +282,10 @@
Personal information suggestions Personal information suggestions
</message> </message>
<message name="IDS_SETTINGS_SMART_INPUTS_PERSONAL_INFO_DESCRIPTION" desc="The description for personal information suggestion section."> <message name="IDS_SETTINGS_SMART_INPUTS_PERSONAL_INFO_DESCRIPTION" desc="The description for personal information suggestion section.">
Personal information suggestions help you write faster by suggesting your name, address or phone number when you type some specific words. Only you see your own private, personalized suggestions for your account. Personal information suggestions help you write faster with suggestions such as your name, address or phone number. Only you see your own private, personalized suggestions for your account.
</message> </message>
<message name="IDS_SETTINGS_SMART_INPUTS_SHOW_PERSONAL_INFO" desc="The label for the toggle button controlling showing personal information suggestions."> <message name="IDS_SETTINGS_SMART_INPUTS_SHOW_PERSONAL_INFO" desc="The label for the toggle button controlling showing personal information suggestions.">
Show input personal information suggestions Show personal information suggestions
</message> </message>
<message name="IDS_SETTINGS_SMART_INPUTS_MANAGE_PERSONAL_INFO" desc="The label for opening Chrome's browser settings page for managing personal addresses"> <message name="IDS_SETTINGS_SMART_INPUTS_MANAGE_PERSONAL_INFO" desc="The label for opening Chrome's browser settings page for managing personal addresses">
Manage personal information Manage personal information
...@@ -293,6 +293,9 @@ ...@@ -293,6 +293,9 @@
<message name="IDS_SETTINGS_SMART_INPUTS_EMOJI_SUGGESTION_TITLE" desc="The label for emoji suggestion (when an user types a word, some emojis might be suggested for the user to insert after) section."> <message name="IDS_SETTINGS_SMART_INPUTS_EMOJI_SUGGESTION_TITLE" desc="The label for emoji suggestion (when an user types a word, some emojis might be suggested for the user to insert after) section.">
Emoji suggestions Emoji suggestions
</message> </message>
<message name="IDS_SETTINGS_SMART_INPUTS_EMOJI_SUGGESTION_DESCRIPTION" desc="The description for emoji suggestion (when an user types a word, some emojis might be suggested for the user to insert after) section.">
Get emoji suggestions based on what you are typing
</message>
<message name="IDS_SETTINGS_SMART_INPUTS_SHOW_EMOJI_SUGGESTION" desc="The label for the toggle button controlling showing emoji suggestions (when an user types a word, some emojis might be suggested for the user to insert after)."> <message name="IDS_SETTINGS_SMART_INPUTS_SHOW_EMOJI_SUGGESTION" desc="The label for the toggle button controlling showing emoji suggestions (when an user types a word, some emojis might be suggested for the user to insert after).">
Show emoji suggestions Show emoji suggestions
</message> </message>
......
fe1a68ea0a69ce1210458b73b3d15e24ebd902ec
\ No newline at end of file
e958f3cbebd3520e82f51986c61fc4985ae14f94 3b7f44aa6c56475ca1b41bd8ab2e3c935b43ef40
\ No newline at end of file \ No newline at end of file
8ec56ee81850db8fb7eed35985e27d3bab1b8708 4455da127a7b8cd9cceb329ca8c8d74146266bba
\ No newline at end of file \ No newline at end of file
...@@ -42,10 +42,15 @@ ...@@ -42,10 +42,15 @@
<h2 aria-hidden="true"> <h2 aria-hidden="true">
$i18n{emojiSuggestionTitle} $i18n{emojiSuggestionTitle}
</h2> </h2>
<span class="settings-box first" aria-hidden="true"
id="emojiSuggestionDescription">
$i18n{emojiSuggestionDescription}
</span>
<div class="list-frame vertical-list"> <div class="list-frame vertical-list">
<settings-toggle-button class="list-item first" <settings-toggle-button class="list-item first"
pref="{{prefs.assistive_input.emoji_suggestion_enabled}}" pref="{{prefs.assistive_input.emoji_suggestion_enabled}}"
label="$i18n{showEmojiSuggestion}"> label="$i18n{showEmojiSuggestion}"
aria-describedby="emojiSuggestionDescription">
</settings-toggle-button> </settings-toggle-button>
</div> </div>
</div> </div>
......
...@@ -113,6 +113,8 @@ void AddSmartInputsStrings(content::WebUIDataSource* html_source) { ...@@ -113,6 +113,8 @@ void AddSmartInputsStrings(content::WebUIDataSource* html_source) {
{"managePersonalInfo", IDS_SETTINGS_SMART_INPUTS_MANAGE_PERSONAL_INFO}, {"managePersonalInfo", IDS_SETTINGS_SMART_INPUTS_MANAGE_PERSONAL_INFO},
{"emojiSuggestionTitle", {"emojiSuggestionTitle",
IDS_SETTINGS_SMART_INPUTS_EMOJI_SUGGESTION_TITLE}, IDS_SETTINGS_SMART_INPUTS_EMOJI_SUGGESTION_TITLE},
{"emojiSuggestionDescription",
IDS_SETTINGS_SMART_INPUTS_EMOJI_SUGGESTION_DESCRIPTION},
{"showEmojiSuggestion", IDS_SETTINGS_SMART_INPUTS_SHOW_EMOJI_SUGGESTION}, {"showEmojiSuggestion", IDS_SETTINGS_SMART_INPUTS_SHOW_EMOJI_SUGGESTION},
}; };
AddLocalizedStringsBulk(html_source, kLocalizedStrings); AddLocalizedStringsBulk(html_source, kLocalizedStrings);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment