Commit 45b9314e authored by Brian Sheedy's avatar Brian Sheedy Committed by Commit Bot

Re-enable minidump test on all platforms

The fix from https://crrev.com/c/1713749 appears to fix the issue of
not getting minidumps to symbolize on all platforms, so re-enable the
minidump tests on all supported platforms.

Bug: 634156
Change-Id: Iabc150bb525c294d875105ef4dd48b57c14249f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715395Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680183}
parent 8a4a66cb
......@@ -15,9 +15,8 @@ import py_utils
class BrowserMinidumpTest(tab_test_case.TabTestCase):
@decorators.Isolated
# ChromeOS and Android are currently hard coded to return None for minidump
# paths, so disable on those platforms. Windows 7 doesn't find any minidump
# paths for some reason.
@decorators.Disabled('chromeos', 'android', 'win7')
# paths, so disable on those platforms.
@decorators.Disabled('chromeos', 'android')
def testSymbolizeMinidump(self):
# Wait for the browser to restart fully before crashing
self._LoadPageThenWait('var sam = "car";', 'sam')
......@@ -89,10 +88,7 @@ class BrowserMinidumpTest(tab_test_case.TabTestCase):
self.assertTrue(crash_function in sections[4])
@decorators.Isolated
# Disabled on Mac 10.12 (Sierra) due to it not getting a stack trace to
# symbolize from the second crash.
# Test is flaky on 10.13 (HighSierra). See https://crbug.com/986644.
@decorators.Disabled('chromeos', 'android', 'win7', 'sierra', 'highsierra')
@decorators.Disabled('chromeos', 'android')
def testMultipleCrashMinidumps(self):
# Wait for the browser to restart fully before crashing
self._LoadPageThenWait('var cat = "dog";', 'cat')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment