Commit 45db51f3 authored by Matthias Körber's avatar Matthias Körber Committed by Commit Bot

Removed unused methods from |FullCardRequest|.

Bug: 1007974
Change-Id: Ia2c10f57f0ee67de237414679046984e34a1bd7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827002
Commit-Queue: Matthias Körber <koerber@google.com>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: default avatarVadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700224}
parent a7d38dd4
......@@ -111,10 +111,6 @@ void FullCardRequest::GetFullCard(const CreditCard& card,
}
}
bool FullCardRequest::IsGettingFullCard() const {
return !!request_;
}
void FullCardRequest::OnUnmaskPromptAccepted(
const UserProvidedUnmaskDetails& user_response) {
if (!user_response.exp_month.empty())
......
......@@ -85,9 +85,6 @@ class FullCardRequest final : public CardUnmaskDelegate {
base::WeakPtr<ResultDelegate> result_delegate,
base::Value fido_assertion_info);
// Returns true if there's a pending request to get the full card.
bool IsGettingFullCard() const;
// Called by the payments client when a card has been unmasked.
void OnDidGetRealPan(
AutofillClient::PaymentsRpcResult result,
......
......@@ -621,74 +621,5 @@ TEST_F(FullCardRequestTest, UnmaskForPaymentRequest) {
card_unmask_delegate()->OnUnmaskPromptClosed();
}
// Verify that FullCardRequest::IsGettingFullCard() is true until the server
// returns the full PAN for a masked card.
TEST_F(FullCardRequestTest, IsGettingFullCardForMaskedServerCard) {
EXPECT_CALL(*result_delegate(),
OnFullCardRequestSucceeded(
testing::Ref(*request()),
CardMatches(CreditCard::FULL_SERVER_CARD, "4111"),
base::ASCIIToUTF16("123")));
EXPECT_CALL(*ui_delegate(), ShowUnmaskPrompt(_, _, _));
EXPECT_CALL(*ui_delegate(),
OnUnmaskVerificationResult(AutofillClient::SUCCESS));
EXPECT_FALSE(request()->IsGettingFullCard());
request()->GetFullCard(
CreditCard(CreditCard::MASKED_SERVER_CARD, "server_id"),
AutofillClient::UNMASK_FOR_AUTOFILL, result_delegate()->AsWeakPtr(),
ui_delegate()->AsWeakPtr());
EXPECT_TRUE(request()->IsGettingFullCard());
CardUnmaskDelegate::UserProvidedUnmaskDetails details;
details.cvc = base::ASCIIToUTF16("123");
card_unmask_delegate()->OnUnmaskPromptAccepted(details);
EXPECT_TRUE(request()->IsGettingFullCard());
OnDidGetRealPan(AutofillClient::SUCCESS, "4111");
EXPECT_FALSE(request()->IsGettingFullCard());
card_unmask_delegate()->OnUnmaskPromptClosed();
EXPECT_FALSE(request()->IsGettingFullCard());
}
// Verify that FullCardRequest::IsGettingFullCard() is true until the user types
// in the CVC for a card that is not masked.
TEST_F(FullCardRequestTest, IsGettingFullCardForLocalCard) {
EXPECT_CALL(
*result_delegate(),
OnFullCardRequestSucceeded(testing::Ref(*request()),
CardMatches(CreditCard::LOCAL_CARD, "4111"),
base::ASCIIToUTF16("123")));
EXPECT_CALL(*ui_delegate(), ShowUnmaskPrompt(_, _, _));
EXPECT_CALL(*ui_delegate(),
OnUnmaskVerificationResult(AutofillClient::SUCCESS));
EXPECT_FALSE(request()->IsGettingFullCard());
CreditCard card;
test::SetCreditCardInfo(&card, nullptr, "4111", "12", "2050", "1");
request()->GetFullCard(card, AutofillClient::UNMASK_FOR_AUTOFILL,
result_delegate()->AsWeakPtr(),
ui_delegate()->AsWeakPtr());
EXPECT_TRUE(request()->IsGettingFullCard());
CardUnmaskDelegate::UserProvidedUnmaskDetails details;
details.cvc = base::ASCIIToUTF16("123");
card_unmask_delegate()->OnUnmaskPromptAccepted(details);
EXPECT_FALSE(request()->IsGettingFullCard());
card_unmask_delegate()->OnUnmaskPromptClosed();
EXPECT_FALSE(request()->IsGettingFullCard());
}
} // namespace payments
} // namespace autofill
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment