Commit 45dcd9a7 authored by Kenichi Ishibashi's avatar Kenichi Ishibashi Committed by Commit Bot

Stop dropping service worker scripts from MemoryCache

This was a hack to ensure service worker script requests go through
the browser process. This hack is no longer needed because script
requests happen on the worker thread and requests happened outside
the main thread are never put into MemoryCache.

Bug: 990659
Change-Id: I9450309e95a3116f0d03b5beb22a2e58ed343a61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735148Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683895}
parent ca698fff
...@@ -766,11 +766,6 @@ void ServiceWorkerGlobalScope::importScripts( ...@@ -766,11 +766,6 @@ void ServiceWorkerGlobalScope::importScripts(
: stringOrUrl.GetAsTrustedScriptURL()->toString(); : stringOrUrl.GetAsTrustedScriptURL()->toString();
KURL completed_url = CompleteURL(string_url); KURL completed_url = CompleteURL(string_url);
// Bust the MemoryCache to ensure script requests reach the browser-side
// and get added to and retrieved from the ServiceWorker's script cache.
// FIXME: Revisit in light of the solution to crbug/388375.
RemoveURLFromMemoryCache(completed_url);
if (installed_scripts_manager && if (installed_scripts_manager &&
!installed_scripts_manager->IsScriptInstalled(completed_url)) { !installed_scripts_manager->IsScriptInstalled(completed_url)) {
DCHECK(installed_scripts_manager->IsScriptInstalled(Url())); DCHECK(installed_scripts_manager->IsScriptInstalled(Url()));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment