Revert "Reland "Worker: Add data URL tests for nested dedicated workers"" (45ee5a9b) · Commits · eriksson monteiro / tangled

Commit 45ee5a9b authored Feb 18, 2020 by

Hiroki Nakagawa Committed by Commit Bot Feb 18, 2020

Revert "Reland "Worker: Add data URL tests for nested dedicated workers""

This reverts commit 1431d28a.

Reason for revert:
The tests still consistently time out on WebKit Linux Leak.

Original change's description:
> Reland "Worker: Add data URL tests for nested dedicated workers"
> 
> The original patch was reverted because the tests with worker variant
> (nested dedicated workers) consistently timed out on WebKit Linux Leak.
> In general, nested dedicated workers are slow, and also WebKit Linux
> Leak is slow. Probably this is the reason why the tests consistently
> timed out.
> 
> To mitigate it, this patch adds timeout=long in the WPT's META line in
> addition to the original patch.
> 
> For sheriff: If the tests still time out on WebKit Linux Leak, feel free
> to revert this patch again. In that case, I'll attempt to separate the
> tests into multiple files.
> 
> Original change's description:
> > Revert "Worker: Add data URL tests for nested dedicated workers"
> >
> > This reverts commit 1d73a2eb.
> >
> > Reason for revert: Worker variant of tests appears to consistently timeout on WebKit Linux Leak (crbug.com/1052322)
> >
> > Original change's description:
> > > Worker: Add data URL tests for nested dedicated workers
> > >
> > > This CL renames data-url.html to data-url.any.js in order to run the
> > > tests on a dedicated worker. Previously these tests only ran on window.
> > >
> > > Bug: n/a
> > > Change-Id: I4be0cfdddc01fa4865763868c4947ea63e62d491
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054656
> > > Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#741367}
> >
> > TBR=nhiroki@chromium.org,shimazu@chromium.org
> >
> > Change-Id: I00481f9a51c672b4041364674d0bcad00d959c63
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: n/a
> > Bug: 1052322
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057046
> > Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#741417}
> 
> Bug: 1052322
> Change-Id: I348ba1743f58a6f0fedf2b739a1cb6a574af6f2f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060356
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742050}

TBR=nhiroki@chromium.org,shimazu@chromium.org

Change-Id: I09412305ad6d2093ffb6c489774552eb0bd58f3b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1052322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061577Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742080}

parent da2d9e57

Hide whitespace changes

Inline Side-by-side

→

View file @ 45ee5a9b

 // META: title=data URL dedicated workers
 // META: timeout=long
 <!DOCTYPE html>
 <title>data URL dedicated workers</title>
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 <script>
 // Helper assert functions -START-
 function assert_worker_sends_pass(test_desc, mime_type, worker_code) {
   async_test(function(t) {
@@ -62,3 +64,4 @@ setup({allow_uncaught_exception:true});
 assert_worker_construction_fails('invalid javascript produces error', 'application/javascript', '}x=3');
 // Actual tests -END-
 </script>

Please register or to comment