Commit 45fe4453 authored by Maksim Ivanov's avatar Maksim Ivanov Committed by Commit Bot

[privacy_budget] Fix use-after-move in scoped_identifiability_test_sample_collector

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I521dc064f7ae4522b25a3c7c003d608616acba05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401521
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: default avatarAsanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806159}
parent a057e31c
...@@ -29,7 +29,7 @@ void ScopedIdentifiabilityTestSampleCollector::Record( ...@@ -29,7 +29,7 @@ void ScopedIdentifiabilityTestSampleCollector::Record(
std::vector<IdentifiableSample> metrics) { std::vector<IdentifiableSample> metrics) {
entries_.emplace_back(source, std::move(metrics)); entries_.emplace_back(source, std::move(metrics));
AggregatingSampleCollector::UkmMetricsContainerType metrics_map; AggregatingSampleCollector::UkmMetricsContainerType metrics_map;
for (auto metric : metrics) { for (auto metric : entries_.back().metrics) {
metrics_map.emplace(metric.surface.ToUkmMetricHash(), metrics_map.emplace(metric.surface.ToUkmMetricHash(),
metric.value.ToUkmMetricValue()); metric.value.ToUkmMetricValue());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment