Commit 46362457 authored by Erik Chen's avatar Erik Chen Committed by Commit Bot

Update documentation for chrome/test/base/in_process_browser_test.h.

The file does not provide the preprocessor defines for
IN_PROC_BROWSER_TEST_ macros. This documentation update makes it clear
to users that they need to manually include
"content/public/test/browser_test.h". The header cannot be directly
included by in_process_browser_test.h as it produces compile errors:

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874211071355292448/+/steps/compile__with_patch_/0/stdout

Change-Id: Ie8091857d76e2408a6fdbc471bf97ca544f8c89d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308863Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790530}
parent 74e20c48
...@@ -69,6 +69,10 @@ class ScopedBundleSwizzlerMac; ...@@ -69,6 +69,10 @@ class ScopedBundleSwizzlerMac;
// SetUpOnMainThread(), SetUpInProcessBrowserTestFixture(), and other related // SetUpOnMainThread(), SetUpInProcessBrowserTestFixture(), and other related
// methods for a cleaner alternative). // methods for a cleaner alternative).
// //
// To include the default implementation of RunTestOnMainThread() and TestBody()
// for Gtests, it's also necessary to include the file
// "content/public/test/browser_test.h"
//
// The following hook methods are called in sequence before BrowserMain(), so // The following hook methods are called in sequence before BrowserMain(), so
// no browser has been created yet. They are mainly for setting up the // no browser has been created yet. They are mainly for setting up the
// environment for running the browser. // environment for running the browser.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment