Commit 4667034e authored by Sophie Chang's avatar Sophie Chang Committed by Chromium LUCI CQ

Remove file error checking in downloadmanager tests that check for deletion

Just going to keep retrying until the path has been deleted. Probably
better than the test crashing after the first time?

Bug: 1156112
Change-Id: Ia5e7e97a09bcfe347b63b156dde558fd59009f68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629673Reviewed-by: default avatarMichael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843731}
parent 939730b5
...@@ -166,15 +166,6 @@ class PredictionModelDownloadManagerTest : public testing::Test { ...@@ -166,15 +166,6 @@ class PredictionModelDownloadManagerTest : public testing::Test {
if (!path_exists) if (!path_exists)
return true; return true;
base::File::Error file_error = base::File::GetLastFileError();
// In the event this does not fix the flake, log the error so we know what
// it is.
// TODO(crbug/1156112): Remove this log once the flake has been resolved.
DLOG(ERROR) << "Path Exists Error: " << file_error;
if (file_error != base::File::FILE_ERROR_ACCESS_DENIED)
return !path_exists;
// Retry if the last file error is access denied since it's likely that // Retry if the last file error is access denied since it's likely that
// the file is in the process of being deleted. // the file is in the process of being deleted.
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment