Commit 467ac172 authored by prasadv's avatar prasadv Committed by Commit bot

Make bisect tool check for new V8 roll description, "based on <git-hash>"

BUG=419297
NOTRY=true

Review URL: https://codereview.chromium.org/676403005

Cr-Commit-Position: refs/heads/master@{#301444}
parent 36165702
......@@ -1882,9 +1882,6 @@ class BisectPerformanceMetrics(object):
regex_results = version_re.search(revision_info['subject'])
if regex_results:
git_revision = None
# TODO (prasadv): Support the v8 git migration based subject
# "based on <githash>"
# Look for "based on bleeding_edge" and parse out revision
if 'based on bleeding_edge' in revision_info['subject']:
try:
bleeding_edge_revision = revision_info['subject'].split(
......@@ -1904,6 +1901,16 @@ class BisectPerformanceMetrics(object):
return git_revision
except (IndexError, ValueError):
pass
else:
# V8 rolls description changed after V8 git migration, new description
# includes "Version 3.X.Y (based on <git hash>)"
try:
rxp = re.compile('based on (?P<git_revision>[a-fA-F0-9]+)')
re_results = rxp.search(revision_info['subject'])
if re_results:
return re_results.group('git_revision')
except (IndexError, ValueError):
pass
if not git_revision:
# Wasn't successful, try the old way of looking for "Prepare push to"
git_revision = source_control.ResolveToRevision(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment