Commit 46878398 authored by Christian Dullweber's avatar Christian Dullweber Committed by Commit Bot

Remove PageInfo subpages when dialog is closed

To ensure that all fragments are removed when the PageInfo dialog is
closed, the subpage controller needs to be notified when the main
controller is dismissed.

Bug: 1152724
Change-Id: I075a214223ceee675578615226b958880a103946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560628Reviewed-by: default avatarEhimare Okoyomon <eokoyomon@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831024}
parent 6a9ccb15
...@@ -488,6 +488,10 @@ public class PageInfoController implements PageInfoMainController, ModalDialogPr ...@@ -488,6 +488,10 @@ public class PageInfoController implements PageInfoMainController, ModalDialogPr
mPendingRunAfterDismissTask.run(); mPendingRunAfterDismissTask.run();
mPendingRunAfterDismissTask = null; mPendingRunAfterDismissTask = null;
} }
if (mSubpageController != null) {
mSubpageController.onSubpageRemoved();
mSubpageController = null;
}
mWebContentsObserver.destroy(); mWebContentsObserver.destroy();
mWebContentsObserver = null; mWebContentsObserver = null;
PageInfoControllerJni.get().destroy(mNativePageInfoController, PageInfoController.this); PageInfoControllerJni.get().destroy(mNativePageInfoController, PageInfoController.this);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment