Refactor update_client deps.

This reduces the build artifacts necessary to build chrome/updater from
5k to 1.7k.

Change-Id: I7332c69a5f564a08786d7e21e5891448feca8f11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557988
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649098}

chrome/browser/BUILD.gn

@@ -1970,8 +1970,7 @@ jumbo_split_static_library("browser") {
     "//components/undo",
     "//components/unified_consent",
     "//components/update_client",
-    "//components/update_client:patch_impl",
-    "//components/update_client:unzip_impl",
+    "//components/update_client:common_impl",
     "//components/upload_list",
     "//components/url_formatter",
     "//components/url_formatter/top_domains:top500_domains",

chrome/browser/extensions/BUILD.gn

@@ -854,8 +854,7 @@ jumbo_static_library("extensions") {
     "//components/undo",
     "//components/unified_consent",
     "//components/update_client",
-    "//components/update_client:patch_impl",
-    "//components/update_client:unzip_impl",
+    "//components/update_client:common_impl",
     "//components/url_matcher",
     "//components/user_prefs",
     "//components/vector_icons",

components/update_client/BUILD.gn

@@ -4,26 +4,15 @@
 
 import("//net/features.gni")
 
-source_set("network_public") {
+source_set("network_impl") {
   sources = [
     "net/network_chromium.h",
-  ]
-
-  deps = [
-    "//base",
-  ]
-}
-
-source_set("network") {
-  sources = [
     "net/network_impl.cc",
     "net/network_impl.h",
   ]
 
-  visibility = [ ":*" ]
-
   deps = [
-    ":network_public",
+    ":update_client",
     "//base",
     "//net",
     "//services/network/public/cpp:cpp",
@@ -53,6 +42,14 @@ source_set("patch_impl") {
   ]
 }
 
+group("common_impl") {
+  public_deps = [
+    ":network_impl",
+    ":patch_impl",
+    ":unzip_impl",
+  ]
+}
+
 static_library("update_client") {
   sources = [
     "action_runner.cc",
@@ -125,29 +122,16 @@ static_library("update_client") {
     "utils.h",
   ]
 
-  # Allows callers to include the network factory through "update_client" deps.
-  public_deps = [
-    ":network_public",
-  ]
-
   deps = [
-    ":network",
-    ":network_public",
     "//base",
     "//components/client_update_protocol",
     "//components/crx_file",
-    "//components/data_use_measurement/core",
     "//components/prefs",
     "//components/version_info:version_info",
     "//courgette:courgette_lib",
     "//crypto",
     "//url",
   ]
-
-  allow_circular_includes_from = [
-    ":network",
-    ":network_public",
-  ]
 }
 
 static_library("test_support") {
@@ -166,6 +150,7 @@ static_library("test_support") {
   ]
 
   deps = [
+    ":network_impl",
     ":patch_impl",
     ":unzip_impl",
     "//base",
@@ -233,7 +218,7 @@ source_set("unit_tests") {
   }
 
   deps = [
-    ":network",
+    ":network_impl",
     ":patch_impl",
     ":test_support",
     ":unit_tests_bundle_data",

components/update_client/DEPS

 include_rules = [
   "+components/client_update_protocol",
   "+components/crx_file",
-  "+components/data_use_measurement/core",
   "+components/services/patch",
   "+components/prefs",
   "+components/services/unzip",

components/update_client/url_fetcher_downloader.cc

@@ -14,7 +14,6 @@
 #include "base/sequenced_task_runner.h"
 #include "base/task/post_task.h"
 #include "base/task/task_traits.h"
-#include "components/data_use_measurement/core/data_use_user_data.h"
 #include "components/update_client/network.h"
 #include "components/update_client/utils.h"
 #include "url/gurl.h"

components/update_client/utils.cc

@@ -21,7 +21,6 @@
 #include "base/strings/string_util.h"
 #include "base/values.h"
 #include "components/crx_file/id_util.h"
-#include "components/data_use_measurement/core/data_use_user_data.h"
 #include "components/update_client/component.h"
 #include "components/update_client/configurator.h"
 #include "components/update_client/network.h"

ios/chrome/browser/component_updater/BUILD.gn

@@ -11,8 +11,7 @@ source_set("component_updater") {
     "//base",
     "//components/component_updater",
     "//components/update_client",
-    "//components/update_client:patch_impl",
-    "//components/update_client:unzip_impl",
+    "//components/update_client:common_impl",
     "//ios/chrome/browser",
     "//ios/chrome/browser/google",
     "//ios/chrome/common",