Commit 469fb3c3 authored by Tim van der Lippe's avatar Tim van der Lippe Committed by Commit Bot

Fix tests for upcoming DevTools change

They were using typedefs that should have used the actual symbol.
Required for
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2060290

TBR=aerotwist@chromium.org

Bug: 1006759
Change-Id: I3f1433de7e472d7877729132278b581540665cd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064942Reviewed-by: default avatarTim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: default avatarPaul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743126}
parent 938989d5
...@@ -6619,3 +6619,8 @@ crbug.com/848799 [ Win10 ] http/tests/devtools/coverage/multiple-instances-merge ...@@ -6619,3 +6619,8 @@ crbug.com/848799 [ Win10 ] http/tests/devtools/coverage/multiple-instances-merge
crbug.com/1053903 [ Mac ] external/wpt/webxr/events_referenceSpace_reset_inline.https.html [ Pass Failure Timeout ] crbug.com/1053903 [ Mac ] external/wpt/webxr/events_referenceSpace_reset_inline.https.html [ Pass Failure Timeout ]
crbug.com/1053903 [ Linux ] external/wpt/webxr/events_referenceSpace_reset_inline.https.html [ Pass Failure Timeout ] crbug.com/1053903 [ Linux ] external/wpt/webxr/events_referenceSpace_reset_inline.https.html [ Pass Failure Timeout ]
crbug.com/1053903 [ Win ] external/wpt/webxr/events_referenceSpace_reset_inline.https.html [ Pass Failure Timeout ] crbug.com/1053903 [ Win ] external/wpt/webxr/events_referenceSpace_reset_inline.https.html [ Pass Failure Timeout ]
# DevTools roll
crbug.com/1006759 http/tests/devtools/agents-enable-disable.js [ Skip ]
crbug.com/1006759 http/tests/devtools/search/search-in-non-existing-resource.js [ Skip ]
crbug.com/1006759 http/tests/devtools/sources/debugger-breakpoints/debugger-set-breakpoint-regex.js [ Skip ]
...@@ -33,13 +33,17 @@ ...@@ -33,13 +33,17 @@
async function disableAgent(agentName) { async function disableAgent(agentName) {
const agent = target._agents[agentName]; const agent = target._agents[agentName];
const response = await agent.invoke_disable({}); const response = await agent.invoke_disable({});
printResult(agentName, 'disable', response[Protocol.Error]); printResult(
agentName, 'disable',
response[Protocol.InspectorBackend.ProtocolError]);
} }
async function enableAgent(agentName) { async function enableAgent(agentName) {
const agent = target._agents[agentName]; const agent = target._agents[agentName];
const response = await agent.invoke_enable({}); const response = await agent.invoke_enable({});
printResult(agentName, 'enable', response[Protocol.Error]); printResult(
agentName, 'enable',
response[Protocol.InspectorBackend.ProtocolError]);
} }
for (const agentName of agentNames) for (const agentName of agentNames)
......
...@@ -20,7 +20,7 @@ ...@@ -20,7 +20,7 @@
var resource = Bindings.resourceForURL('http://127.0.0.1:8000/devtools/search/resources/search.js'); var resource = Bindings.resourceForURL('http://127.0.0.1:8000/devtools/search/resources/search.js');
var url = 'http://127.0.0.1:8000/devtools/search/resources/non-existing.js'; var url = 'http://127.0.0.1:8000/devtools/search/resources/non-existing.js';
var response = await TestRunner.PageAgent.invoke_searchInResource({frameId: resource.frameId, url, query: text}); var response = await TestRunner.PageAgent.invoke_searchInResource({frameId: resource.frameId, url, query: text});
TestRunner.addResult(response[Protocol.Error]); TestRunner.addResult(response[Protocol.InspectorBackend.ProtocolError]);
TestRunner.completeTest(); TestRunner.completeTest();
} }
})(); })();
...@@ -20,7 +20,7 @@ ...@@ -20,7 +20,7 @@
SourcesTestRunner.runDebuggerTestSuite([ SourcesTestRunner.runDebuggerTestSuite([
async function testSetNoneOfURLAndRegex(next) { async function testSetNoneOfURLAndRegex(next) {
var response = await TestRunner.DebuggerAgent.invoke_setBreakpointByUrl({lineNumber: 1}); var response = await TestRunner.DebuggerAgent.invoke_setBreakpointByUrl({lineNumber: 1});
TestRunner.addResult(response[Protocol.Error]); TestRunner.addResult(response[Protocol.InspectorBackend.ProtocolError]);
next(); next();
}, },
...@@ -28,7 +28,7 @@ ...@@ -28,7 +28,7 @@
var url = 'debugger-set-breakpoint.js'; var url = 'debugger-set-breakpoint.js';
var urlRegex = 'debugger-set-breakpoint.*'; var urlRegex = 'debugger-set-breakpoint.*';
var response = await TestRunner.DebuggerAgent.invoke_setBreakpointByUrl({lineNumber: 1, url, urlRegex}); var response = await TestRunner.DebuggerAgent.invoke_setBreakpointByUrl({lineNumber: 1, url, urlRegex});
TestRunner.addResult(response[Protocol.Error]); TestRunner.addResult(response[Protocol.InspectorBackend.ProtocolError]);
next(); next();
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment