Commit 46a70005 authored by Mario Sanchez Prada's avatar Mario Sanchez Prada Committed by Commit Bot

Re-enable flaky TranslateIframe test and add extra debug information

This test has been disabled in https://crrev.com/c/2303433 due to it
being flaky. However its stack trace matches the one observed recently
in production code (crbug.com/1107103) so we're re-enabling it now and
adding some extra debugging information in order to help us fix the
issue, as it hasn't been possible to reproduce it locally so far.

Bug: 1107103
Change-Id: Ifeee8483c83e72b52a232b71ef2437ecab6bf305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316101Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: default avatarHajime Hoshi <hajimehoshi@chromium.org>
Auto-Submit: Mario Sanchez Prada <mario@igalia.com>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791714}
parent 3e783336
...@@ -2019,7 +2019,7 @@ class TranslateManagerWithMainFrameLanguageDetectionBrowserTest ...@@ -2019,7 +2019,7 @@ class TranslateManagerWithMainFrameLanguageDetectionBrowserTest
// TODO(https://crbug.com/1106620): Disabled due to flake and crashes. // TODO(https://crbug.com/1106620): Disabled due to flake and crashes.
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
TranslateManagerWithMainFrameLanguageDetectionBrowserTest, TranslateManagerWithMainFrameLanguageDetectionBrowserTest,
DISABLED_TranslateIframe) { TranslateIframe) {
base::HistogramTester histograms; base::HistogramTester histograms;
SetTranslateScript(kTestValidScript); SetTranslateScript(kTestValidScript);
......
...@@ -1353,8 +1353,10 @@ bool AXTree::ComputePendingChangesToNode(const AXNodeData& new_data, ...@@ -1353,8 +1353,10 @@ bool AXTree::ComputePendingChangesToNode(const AXNodeData& new_data,
if (!update_state->IncrementPendingCreateNodeCount(child_id, if (!update_state->IncrementPendingCreateNodeCount(child_id,
new_data.id)) { new_data.id)) {
error_ = base::StringPrintf( error_ = base::StringPrintf(
"Node %d is already pending for creation, cannot be a new child", "Node %d from |new_child_id_set| is already pending for "
child_id); "creation, cannot be a new child (of parent %d)\n"
"Parent Node info:\n%s",
child_id, new_data.id, new_data.ToString().c_str());
return false; return false;
} }
} }
...@@ -1406,8 +1408,10 @@ bool AXTree::ComputePendingChangesToNode(const AXNodeData& new_data, ...@@ -1406,8 +1408,10 @@ bool AXTree::ComputePendingChangesToNode(const AXNodeData& new_data,
if (!update_state->IncrementPendingCreateNodeCount(child_id, if (!update_state->IncrementPendingCreateNodeCount(child_id,
new_data.id)) { new_data.id)) {
error_ = base::StringPrintf( error_ = base::StringPrintf(
"Node %d is already pending for creation, cannot be a new child", "Node %d from |create_or_destroy_ids| is already pending for "
child_id); "creation, cannot be a new child (of parent %d)\n"
"Parent Node info:\n%s",
child_id, new_data.id, new_data.ToString().c_str());
return false; return false;
} }
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment