Skip to content

GitLab

T
tangled
Commit 46b14df6 authored by Kevin Marshall's avatar Kevin Marshall Committed by Chromium LUCI CQ
Browse files
Options

[fuchsia] Fix AutoPlayTest.*UserActivatedViaSimulatedInteraction 

Fixes a test flake that was caused by incomplete precondition
criteria. Now the test case will wait until the document is parsed
before executing the test case.

Bug: 1162433
Test: Executed test case with --gtest_repeat=500, no issues found.
Change-Id: I0c5f58965906ec4e83b6212287a529d5b0190034
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638333
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: default avatarWez <wez@chromium.org>
Reviewed-by: default avatarDavid Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845274}
parent 22c27291
Hide whitespace changes
Inline Side-by-side
Showing with 8 additions and 5 deletions
fuchsia/engine/browser/autoplay_browsertest.cc
View file @ 46b14df6
...@@ -49,12 +49,11 @@ class AutoplayTest : public cr_fuchsia::WebEngineBrowserTest { ...@@ -49,12 +49,11 @@ class AutoplayTest : public cr_fuchsia::WebEngineBrowserTest {
fuchsia::web::NavigationControllerPtr controller_; fuchsia::web::NavigationControllerPtr controller_;
}; };
// TODO(1162433): Flakily times-out, probably because URL will change as soon
// as navigation is "committed", which happens before document load.
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
AutoplayTest, AutoplayTest,
DISABLED_UserActivationPolicy_UserActivatedViaSimulatedInteraction) { UserActivationPolicy_UserActivatedViaSimulatedInteraction) {
const GURL kUrl(embedded_test_server()->GetURL("/play_vp8.html?autoplay=1")); const GURL kUrl(embedded_test_server()->GetURL("/play_vp8.html?autoplay=1"));
constexpr const char kPageLoadedTitle[] = "initial title";
fuchsia::web::FramePtr frame = fuchsia::web::FramePtr frame =
CreateFrame(fuchsia::web::AutoplayPolicy::REQUIRE_USER_ACTIVATION); CreateFrame(fuchsia::web::AutoplayPolicy::REQUIRE_USER_ACTIVATION);
...@@ -62,7 +61,7 @@ IN_PROC_BROWSER_TEST_F( ...@@ -62,7 +61,7 @@ IN_PROC_BROWSER_TEST_F(
fuchsia::web::LoadUrlParams params; fuchsia::web::LoadUrlParams params;
EXPECT_TRUE( EXPECT_TRUE(
cr_fuchsia::LoadUrlAndExpectResponse(controller_.get(), {}, kUrl.spec())); cr_fuchsia::LoadUrlAndExpectResponse(controller_.get(), {}, kUrl.spec()));
navigation_listener_.RunUntilUrlEquals(kUrl); navigation_listener_.RunUntilUrlAndTitleEquals(kUrl, kPageLoadedTitle);
context_impl() context_impl()
->GetFrameImplForTest(&frame) ->GetFrameImplForTest(&frame)
......
fuchsia/engine/test/data/play_vp8.html
View file @ 46b14df6
<html> <html>
<head><title>initial title</title></head> <head><title>document loading</title></head>
<body> <body>
<script> <script>
var bear = document.createElement('video'); var bear = document.createElement('video');
...@@ -32,6 +32,10 @@ ...@@ -32,6 +32,10 @@
} }
bear.onstalled = function() { document.title = 'stalled'; } bear.onstalled = function() { document.title = 'stalled'; }
bear.src = 'bear-vp8a.webm'; bear.src = 'bear-vp8a.webm';
// Programatically set the title, to provide an externally-visible
// indication that the page's scripts have executed.
document.title = 'initial title';
</script> </script>
</body> </body>
</html> </html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment