Commit 46dde8d5 authored by Francois Doray's avatar Francois Doray Committed by Commit Bot

Remove WithBaseSyncPrimitives() from observer_list_unittest.cc.

The WithBaseSyncPrimitives() trait is deprecated.

ScopedAllowBaseSyncPrimitives(ForTesting|OutsideBlockingScope)
should be used instead.

Bug: 766678
Change-Id: Ib782e9904ddb14ec0c56973abf0324695383451f
Reviewed-on: https://chromium-review.googlesource.com/702655
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506961}
parent 74907e58
......@@ -21,6 +21,7 @@
#include "base/task_scheduler/task_scheduler.h"
#include "base/test/scoped_task_environment.h"
#include "base/threading/platform_thread.h"
#include "base/threading/thread_restrictions.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
......@@ -587,6 +588,7 @@ class RemoveWhileNotificationIsRunningObserver : public Foo {
void Observe(int x) override {
notification_running_.Signal();
ScopedAllowBaseSyncPrimitivesForTesting allow_base_sync_primitives;
barrier_.Wait();
}
......@@ -617,9 +619,8 @@ TEST(ObserverListThreadSafeTest, RemoveWhileNotificationIsRunning) {
// TaskScheduler can safely use |barrier|.
test::ScopedTaskEnvironment scoped_task_environment;
CreateSequencedTaskRunnerWithTraits({WithBaseSyncPrimitives()})
->PostTask(FROM_HERE,
base::BindOnce(&ObserverListThreadSafe<Foo>::AddObserver,
CreateSequencedTaskRunnerWithTraits({})->PostTask(
FROM_HERE, base::BindOnce(&ObserverListThreadSafe<Foo>::AddObserver,
observer_list, Unretained(&observer)));
TaskScheduler::GetInstance()->FlushForTesting();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment