Commit 46e3076f authored by Ionel Popescu's avatar Ionel Popescu Committed by Commit Bot

Remove the 2px outline-offset for links.

Prior to this CL an 2px outline-offset was used by default for links.
Because we have seen many cases where the focus ring is seen chopped, this
CL changes the offset back to 0px.

Bug: 1044899
Change-Id: I1aa2246a0d4df63a3ad112293c9f8ddca26be29b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020562
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Reviewed-by: default avatarMason Freed <masonfreed@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735308}
parent 07a3a386
......@@ -2206,9 +2206,9 @@ int ComputedStyle::GetDefaultOffsetForFocusRing() const {
if (!::features::IsFormControlsRefreshEnabled())
return 0;
// For FormControlsRefresh checkbox, radio and links have a 2px inner padding.
// For FormControlsRefresh checkbox and radio have a 2px inner padding.
if (EffectiveAppearance() == kCheckboxPart ||
EffectiveAppearance() == kRadioPart || IsLink())
EffectiveAppearance() == kRadioPart)
return 2;
return 0;
}
......
......@@ -18,7 +18,7 @@
},
{
"object": "NGPhysicalBoxFragment LayoutInline A",
"rect": [380, 968, 48, 27],
"rect": [382, 970, 44, 23],
"reason": "appeared"
},
{
......
......@@ -18,7 +18,7 @@
},
{
"object": "NGPhysicalBoxFragment LayoutInline A",
"rect": [381, 1008, 52, 27],
"rect": [383, 1010, 48, 23],
"reason": "appeared"
},
{
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment