Invert toggling state for display password button

Bug: 993653
Change-Id: I21dc10859842208b355245137ba5d141e52c9b09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080415Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Thomas Tellier <tellier@google.com>
Cr-Commit-Position: refs/heads/master@{#745495}

ash/login/ui/login_password_view.cc

@@ -360,13 +360,13 @@ class LoginPasswordView::DisplayPasswordButton
     const gfx::ImageSkia visible_icon = gfx::CreateVectorIcon(
         kLockScreenPasswordVisibleIcon, kDisplayPasswordButtonSizeDp,
         login_constants::kButtonEnabledColor);
-    SetImage(views::Button::STATE_NORMAL, invisible_icon);
-    SetToggledImage(views::Button::STATE_NORMAL, &visible_icon);
+    SetImage(views::Button::STATE_NORMAL, visible_icon);
+    SetToggledImage(views::Button::STATE_NORMAL, &invisible_icon);
 
     SetTooltipText(l10n_util::GetStringUTF16(
-        IDS_ASH_LOGIN_DISPLAY_PASSWORD_BUTTON_ACCESSIBLE_NAME_HIDE));
-    SetToggledTooltipText(l10n_util::GetStringUTF16(
         IDS_ASH_LOGIN_DISPLAY_PASSWORD_BUTTON_ACCESSIBLE_NAME_SHOW));
+    SetToggledTooltipText(l10n_util::GetStringUTF16(
+        IDS_ASH_LOGIN_DISPLAY_PASSWORD_BUTTON_ACCESSIBLE_NAME_HIDE));
     SetFocusBehavior(FocusBehavior::ALWAYS);
     SetInstallFocusRingOnFocus(true);
     focus_ring()->SetColor(ShelfConfig::Get()->shelf_focus_border_color());