Commit 473e0f74 authored by Charlie Andrews's avatar Charlie Andrews Committed by Commit Bot

Remove remaining references to BattOr tracing

This is a follow-up to https://crrev.com/c/1122489, which removed
the BattOr PowerTracingAgent from Chrome.

R=oysteine@chromium.org, dcheng@chromium.org

Bug: 859514
Change-Id: Ib4324289fcf9d1d0e3d34f828550a488a694644b
Reviewed-on: https://chromium-review.googlesource.com/1162626
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avataroysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580678}
parent 41412080
...@@ -22,8 +22,8 @@ class TraceConfig; ...@@ -22,8 +22,8 @@ class TraceConfig;
// tracing method that produces its own trace log should implement this // tracing method that produces its own trace log should implement this
// interface. All tracing agents must only be controlled by TracingController. // interface. All tracing agents must only be controlled by TracingController.
// Some existing examples include TracingControllerImpl for Chrome trace events, // Some existing examples include TracingControllerImpl for Chrome trace events,
// DebugDaemonClient for CrOs system trace, EtwTracingAgent for Windows system // DebugDaemonClient for CrOs system trace, and EtwTracingAgent for Windows
// trace and PowerTracingAgent for BattOr power trace. // system.
class BASE_EXPORT TracingAgent { class BASE_EXPORT TracingAgent {
public: public:
using StartAgentTracingCallback = using StartAgentTracingCallback =
......
include_rules = [ include_rules = [
# Generated by the local tracing_resources.gyp:tracing_resources # Generated by the local tracing_resources.gyp:tracing_resources
"+grit/tracing_resources.h", "+grit/tracing_resources.h",
"+tools/battor_agent",
] ]
specific_include_rules = { specific_include_rules = {
......
...@@ -117,11 +117,12 @@ class Coordinator::TraceStreamer : public base::SupportsWeakPtr<TraceStreamer> { ...@@ -117,11 +117,12 @@ class Coordinator::TraceStreamer : public base::SupportsWeakPtr<TraceStreamer> {
// Bail out if we are in the middle of writing events for another label to // Bail out if we are in the middle of writing events for another label to
// the stream, since we do not want to interleave chunks for different // the stream, since we do not want to interleave chunks for different
// fields. For example, we do not want to mix |traceEvent| chunks with // fields. For example, we do not want to mix |traceEvent| chunks with
// |battor| chunks. // |systrace| chunks.
// //
// If we receive a |battor| chunk from an agent while writing |traceEvent| // If we receive a |systemTraceEvents| chunk from an agent while writing
// chunks to the stream, we wait until all agents that send |traceEvent| // |traceEvent| chunks to the stream, we wait until all agents that send
// chunks are done, and then, we start writing |battor| chunks. // |traceEvent| chunks are done, and then, we start writing
// |systemTraceEvents| chunks.
if (!streaming_label_.empty() && streaming_label_ != label) if (!streaming_label_.empty() && streaming_label_ != label)
return; return;
......
...@@ -69,7 +69,7 @@ class CoordinatorTest : public testing::Test, ...@@ -69,7 +69,7 @@ class CoordinatorTest : public testing::Test,
MockAgent* AddStringAgent() { MockAgent* AddStringAgent() {
auto agent = std::make_unique<MockAgent>(); auto agent = std::make_unique<MockAgent>();
agent_registry_->RegisterAgent(agent->CreateAgentPtr(), "battor", agent_registry_->RegisterAgent(agent->CreateAgentPtr(), "power",
mojom::TraceDataType::STRING, false, mojom::TraceDataType::STRING, false,
base::kNullProcessId); base::kNullProcessId);
agents_.push_back(std::move(agent)); agents_.push_back(std::move(agent));
...@@ -325,8 +325,8 @@ TEST_F(CoordinatorTest, StopAndFlushDifferentTypeAgents) { ...@@ -325,8 +325,8 @@ TEST_F(CoordinatorTest, StopAndFlushDifferentTypeAgents) {
if (!quit_closure_.is_null()) if (!quit_closure_.is_null())
run_loop.Run(); run_loop.Run();
EXPECT_TRUE(output_ == "{\"traceEvents\":[e1,e2],\"battor\":\"e3e4\"}" || EXPECT_TRUE(output_ == "{\"traceEvents\":[e1,e2],\"power\":\"e3e4\"}" ||
output_ == "{\"battor\":\"e3e4\",\"traceEvents\":[e1,e2]}"); output_ == "{\"power\":\"e3e4\",\"traceEvents\":[e1,e2]}");
// Each agent should have received exactly two calls. // Each agent should have received exactly two calls.
EXPECT_EQ(2u, agent1->call_stat().size()); EXPECT_EQ(2u, agent1->call_stat().size());
......
...@@ -21,8 +21,8 @@ enum TraceDataType { ...@@ -21,8 +21,8 @@ enum TraceDataType {
STRING STRING
}; };
// Tracing agents, like |chrome|, |etw|, |battor|, and |cros|, use this // Tracing agents, like |chrome|, |etw|, and |cros|, use this interface to
// interface to register themselves to the tracing service. // register themselves to the tracing service.
// //
// This is a separate interface from |Coordinator| for security and privacy // This is a separate interface from |Coordinator| for security and privacy
// reasons: although we want to let almost every process be able to send tracing // reasons: although we want to let almost every process be able to send tracing
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment