Commit 47481387 authored by Alex Rudenko's avatar Alex Rudenko Committed by Commit Bot

Disable css-rule-hover-highlights-selectors.js for DevTools roll

Refactoring done in [1] is changing the internals of the overlay
that the test intercepts. This CL disables the test temporarily
and modifies it to intercept the new function. I have verified
that the test is passing with the new changes in [1].

[1] https://crrev.com/c/2429775

Bug: 1131801
Change-Id: Ibd586a7435270aed3c82c5b1e26946d75fd37043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435644Reviewed-by: default avatarMathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811238}
parent a5707a7d
......@@ -6169,7 +6169,7 @@ crbug.com/1043920 [ Release Mac ] http/tests/devtools/stylesheet-source-mapping.
crbug.com/1044350 [ Release ] http/tests/devtools/network/network-xhr-replay.js [ Pass Timeout ]
crbug.com/1044414 [ Release ] http/tests/devtools/elements/styles/selector-line-sourcemap-header.js [ Pass Timeout ]
crbug.com/1044415 [ Release ] http/tests/devtools/runtime/evaluate-without-side-effects.js [ Pass Timeout ]
crbug.com/1044424 [ Release ] http/tests/devtools/elements/css-rule-hover-highlights-selectors.js [ Pass Timeout ]
# crbug.com/1044424 [ Release ] http/tests/devtools/elements/css-rule-hover-highlights-selectors.js [ Pass Timeout ]
crbug.com/1044425 [ Release ] http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-1.js [ Pass Timeout ]
crbug.com/1044429 [ Release ] http/tests/devtools/oopif/oopif-navigator.js [ Pass Timeout ]
crbug.com/1002914 http/tests/devtools/elements/elements-panel-styles.js [ Pass Timeout Failure ]
......@@ -6340,6 +6340,7 @@ crbug.com/1042877 virtual/autoupgrade-optionally-blockable-mixed-content/http/te
# DevTools roll
crbug.com/1052111 http/tests/devtools/a11y-axe-core/audits-start-view-a11y-test.js [ Skip ]
crbug.com/1131801 http/tests/devtools/elements/css-rule-hover-highlights-selectors.js [ Pass Failure Timeout ]
# Sheriff 2020-02-18
crbug.com/1050893 [ Fuchsia ] virtual/gpu/fast/canvas/feimage-with-foreignobject-taint-canvas-2.html [ Skip ]
......
......@@ -97,12 +97,15 @@
function drawHighlightProxy() {
window._highlightsForTest = [];
var oldDrawHighlight = drawHighlight;
drawHighlight = proxy;
var oldDispatch = dispatch;
dispatch = proxy;
function proxy(highlight, context) {
window._highlightsForTest.push(highlight);
oldDrawHighlight(highlight, context);
function proxy(message) {
const functionName = message[0];
if (functionName === 'drawHighlight') {
window._highlightsForTest.push(message[1]);
}
oldDispatch(message);
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment