Fix valgrind failures in PhishingTermFeatureExtractor and remove supressions for said failures.

BUG=92267
TEST=Ran PhishingTermFeatureExtractor unittest under valgrind.

Review URL: http://codereview.chromium.org/7604022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96143 0039d316-1c4b-4281-b951-d872f2087c98

chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc

@@ -177,6 +177,7 @@ void PhishingTermFeatureExtractor::ExtractFeaturesWithTimeout() {
         DLOG(ERROR) << "Feature extraction took too long, giving up";
         // We expect this to happen infrequently, so record when it does.
         UMA_HISTOGRAM_COUNTS("SBClientPhishing.TermFeatureTimeout", 1);
+        negative_word_cache_.Clear();
         RunCallback(false);
         return;
       }

tools/valgrind/memcheck/suppressions.txt

@@ -5243,45 +5243,6 @@
    fun:_ZN14RunnableMethodIN3net16HostResolverImpl3JobEMS2_FvRKN4base9TimeTicksEjE6Tuple2IS4_jEE13ReleaseCalleeEv
    fun:_ZN14RunnableMethodIN3net16HostResolverImpl3JobEMS2_FvRKN4base9TimeTicksEjE6Tuple2IS4_jEED0Ev
 }
-{
-   bug_92267_a
-   Memcheck:Addr2
-   fun:_ZNK9__gnu_cxx4hashIN4base13StringPiece16EEclERKS2_
-   fun:*
-   fun:_ZNK9__gnu_cxx9hashtableISt4pairIKN4base13StringPiece16ESt14_List_iteratorIS1_IS3_bEEES3_NS_4hashIS3_EESt10_Select1stIS8_ESt8equal_toIS3_ESaIS7_EE14_M_bkt_num_keyERS4_
-   fun:_ZN9__gnu_cxx9hashtableISt4pairIKN4base13StringPiece16ESt14_List_iteratorIS1_IS3_bEEES3_NS_4hashIS3_EESt10_Select1stIS8_ESt8equal_toIS3_ESaIS7_EE5eraseERS4_
-   fun:_ZN9__gnu_cxx8hash_mapIN4base13StringPiece16ESt14_List_iteratorISt4pairIS2_bEENS_4hashIS2_EESt8equal_toIS2_ESaIS6_EE5eraseERKS2_
-   fun:_ZN4base12MRUCacheBaseINS_13StringPiece16EbNS_19MRUCacheNullDeletorIbEENS_15MRUCacheHashMapEE5EraseESt14_List_iteratorISt4pairIS1_bEE
-   fun:_ZN4base12MRUCacheBaseINS_13StringPiece16EbNS_19MRUCacheNullDeletorIbEENS_15MRUCacheHashMapEED2Ev
-   ...
-   fun:_ZN13safe_browsing28PhishingTermFeatureExtractorD1Ev
-   ...
-   fun:_ZN13safe_browsing32PhishingTermFeatureExtractorTestD2Ev
-   fun:_ZN13safe_browsing50PhishingTermFeatureExtractorTest_Continuation_TestD0Ev
-}
-{
-   bug_92267_b
-   Memcheck:Addr2
-   fun:_ZN4base9c16memcmp*
-   fun:_ZN4base20string16_char_traits7compare*
-   fun:_ZN4base13StringPiece1610wordmemcmp*
-   fun:_ZN4baseeqERKNS_13StringPiece16ES2_
-   fun:_ZNKSt8equal_toIN4base13StringPiece16EEclERKS1_S4_
-   fun:_ZN9__gnu_cxx9hashtableISt4pairIKN4base13StringPiece16ESt14_List_iteratorIS1_IS3_bEEES3_NS_4hashIS3_EESt10_Select1stIS8_ESt8equal_toIS3_ESaIS7_EE5eraseERS4_
-   fun:_ZN9__gnu_cxx8hash_mapIN4base13StringPiece16ESt14_List_iteratorISt4pairIS2_bEENS_4hashIS2_EESt8equal_toIS2_ESaIS6_EE5eraseERKS2_
-   fun:_ZN4base12MRUCacheBaseINS_13StringPiece16EbNS_19MRUCacheNullDeletorIbEENS_15MRUCacheHashMapEE5EraseESt14_List_iteratorISt4pairIS1_bEE
-   fun:_ZN4base12MRUCacheBaseINS_13StringPiece16EbNS_19MRUCacheNullDeletorIbEENS_15MRUCacheHashMapEED2Ev
-   fun:_ZN4base15HashingMRUCacheINS_13StringPiece16*
-   ...
-   fun:_ZN10scoped_ptrIN13safe_browsing28PhishingTermFeatureExtractorEED1Ev
-   fun:_ZN13safe_browsing32PhishingTermFeatureExtractorTestD2Ev
-   fun:_ZN13safe_browsing50PhishingTermFeatureExtractorTest_Continuation_TestD0Ev
-   fun:_ZN7testing4Test11DeleteSelf_Ev
-   fun:_ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc
-   fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc
-   fun:_ZN7testing8TestInfo3RunEv
-   fun:_ZN7testing8TestCase3RunEv
-}
 {
    bug_92279
    Memcheck:Addr4