Commit 479f6e6b authored by Owen Min's avatar Owen Min Committed by Commit Bot

Add text for touch bar search button

When default search provider is disabled by the policy, user can still
press the touch bar search button to enter URL in the omnibox. Add a
text to the button for better UX.

Bug: 1011260
Change-Id: I6d35f853336c567f260579a1ee7d54e9b640a8ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891331Reviewed-by: default avatarSidney San Martín <sdy@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711244}
parent 3ab0aa5b
...@@ -2000,6 +2000,10 @@ are declared in tools/grit/grit_rule.gni. ...@@ -2000,6 +2000,10 @@ are declared in tools/grit/grit_rule.gni.
desc="Text for the search button in the touch bar when Google is the default search provider. Pressing the button will bring focus to the omnibox."> desc="Text for the search button in the touch bar when Google is the default search provider. Pressing the button will bring focus to the omnibox.">
Search or type URL Search or type URL
</message> </message>
<message name="IDS_TOUCH_BAR_NO_DEFAULT_SEARCH"
desc="Text for the search button in the touch bar when there is no default search provider. Pressing the button will bring focus to the omnibox.">
Type URL
</message>
<message name="IDS_TOUCH_BAR_SEARCH" <message name="IDS_TOUCH_BAR_SEARCH"
desc="Text for the search button in the touch bar when Google is not the default search provider. Pressing the button will bring focus to the omnibox. $1 is the name of the search provider)"> desc="Text for the search button in the touch bar when Google is not the default search provider. Pressing the button will bring focus to the omnibox. $1 is the name of the search provider)">
Search <ph name="SEARCH_ENGINE">$1<ex>Bing</ex></ph> Search <ph name="SEARCH_ENGINE">$1<ex>Bing</ex></ph>
......
2a83786b38adc65c5ae8bfe9d22190400140baa8
\ No newline at end of file
...@@ -491,6 +491,8 @@ class API_AVAILABLE(macos(10.12.2)) TouchBarNotificationBridge ...@@ -491,6 +491,8 @@ class API_AVAILABLE(macos(10.12.2)) TouchBarNotificationBridge
title = isGoogle ? l10n_util::GetStringUTF16(IDS_TOUCH_BAR_GOOGLE_SEARCH) title = isGoogle ? l10n_util::GetStringUTF16(IDS_TOUCH_BAR_GOOGLE_SEARCH)
: l10n_util::GetStringFUTF16( : l10n_util::GetStringFUTF16(
IDS_TOUCH_BAR_SEARCH, defaultProvider->short_name()); IDS_TOUCH_BAR_SEARCH, defaultProvider->short_name());
} else {
title = l10n_util::GetStringUTF16(IDS_TOUCH_BAR_NO_DEFAULT_SEARCH);
} }
NSImage* image = nil; NSImage* image = nil;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment