Commit 47a3f38c authored by James Cook's avatar James Cook Committed by Commit Bot

Re-enable MediaEngagementAutoplayBrowserTest.UsePreloadedData_Allowed

It was disabled on all Linux platforms due to failures on Chrome OS
in SingleProcessMash browser_tests.

Instead, disable all MediaEngagement browser_tests via filter file
for SingleProcessMash. There's a fix in-flight for renderer
embedding in this mode, so I expect to re-enable them shortly.

Bug: 884589, 883706, 881574
Change-Id: If6257ea160c7ba83c9bb322941001ce5ab1cc1b7
Reviewed-on: https://chromium-review.googlesource.com/1236836Reviewed-by: default avatarBecca Hughes <beccahughes@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592897}
parent 5307e885
...@@ -293,14 +293,8 @@ IN_PROC_BROWSER_TEST_P(MediaEngagementAutoplayBrowserTest, ...@@ -293,14 +293,8 @@ IN_PROC_BROWSER_TEST_P(MediaEngagementAutoplayBrowserTest,
ExpectAutoplayAllowedIfEnabled(); ExpectAutoplayAllowedIfEnabled();
} }
#if defined(OS_LINUX)
// UsePreloadedData_Allowed/1 is flaky on Linux https://crbug.com/883706
#define MAYBE_UsePreloadedData_Allowed DISABLED_UsePreloadedData_Allowed
#else
#define MAYBE_UsePreloadedData_Allowed UsePreloadedData_Allowed
#endif
IN_PROC_BROWSER_TEST_P(MediaEngagementAutoplayBrowserTest, IN_PROC_BROWSER_TEST_P(MediaEngagementAutoplayBrowserTest,
MAYBE_UsePreloadedData_Allowed) { UsePreloadedData_Allowed) {
// Autoplay should be blocked by default if we have a bad score. // Autoplay should be blocked by default if we have a bad score.
SetScores(PrimaryOrigin(), 0, 0); SetScores(PrimaryOrigin(), 0, 0);
LoadTestPage("engagement_autoplay_test.html"); LoadTestPage("engagement_autoplay_test.html");
......
...@@ -203,8 +203,11 @@ ...@@ -203,8 +203,11 @@
-ManagedWithoutPermission/ManagedWithoutPermissionPlatformKeysTest.* -ManagedWithoutPermission/ManagedWithoutPermissionPlatformKeysTest.*
-ManagedWithPermission/ManagedWithPermissionPlatformKeysTest.* -ManagedWithPermission/ManagedWithPermissionPlatformKeysTest.*
# Timeout. https://crbug.com/883884 # Needs video surface layer support. Should be fixed when renderers don't use
-MediaEngagementBrowserTest.SessionNewTabNavigateSameURL # the window service for embedding.
# https://crbug.com/884589 https://crbug.com/881574
-MediaEngagementBrowserTest.*
-MediaEngagementAutoplayBrowserTest.*
# Full screen button tests. # Full screen button tests.
-PresentationReceiverWindowViewBrowserTest.ChromeOSHardwareFullscreenButton -PresentationReceiverWindowViewBrowserTest.ChromeOSHardwareFullscreenButton
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment