Commit 47b90e1d authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

Remove _TEMPLATE_CLASS_EXPORT macros.

After https://chromium-review.googlesource.com/c/chromium/src/+/1133329
they are no-ops, so no behavior change.

Parts of the CL generated by running

    git grep -l CORE_TEMPLATE_CLASS_EXPORT third_party/blink/renderer/ |
        xargs sed -i 's/CORE_TEMPLATE_CLASS_EXPORT//'

Bug: 859989
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia398e2a4aa511d10577f5ab535c7f54bc3ac47c4
Reviewed-on: https://chromium-review.googlesource.com/1135293
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574803}
parent b0aae2d4
...@@ -42,7 +42,7 @@ class {{exported}}{{cpp_class}} final : public CallbackFunctionBase { ...@@ -42,7 +42,7 @@ class {{exported}}{{cpp_class}} final : public CallbackFunctionBase {
}; };
template <> template <>
class {{exported|replace('_EXPORT', '_TEMPLATE_CLASS_EXPORT')}}V8PersistentCallbackFunction<{{cpp_class}}> final : public V8PersistentCallbackFunctionBase { class V8PersistentCallbackFunction<{{cpp_class}}> final : public V8PersistentCallbackFunctionBase {
using V8CallbackFunction = {{cpp_class}}; using V8CallbackFunction = {{cpp_class}};
public: public:
......
...@@ -58,7 +58,7 @@ class {{exported}}{{v8_class}} final : public CallbackInterfaceBase { ...@@ -58,7 +58,7 @@ class {{exported}}{{v8_class}} final : public CallbackInterfaceBase {
}; };
template <> template <>
class {{exported|replace('_EXPORT', '_TEMPLATE_CLASS_EXPORT')}}V8PersistentCallbackInterface<{{v8_class}}> final : public V8PersistentCallbackInterfaceBase { class V8PersistentCallbackInterface<{{v8_class}}> final : public V8PersistentCallbackInterfaceBase {
using V8CallbackInterface = {{v8_class}}; using V8CallbackInterface = {{v8_class}};
public: public:
......
...@@ -40,7 +40,7 @@ class CORE_EXPORT V8AnyCallbackFunctionOptionalAnyArg final : public CallbackFun ...@@ -40,7 +40,7 @@ class CORE_EXPORT V8AnyCallbackFunctionOptionalAnyArg final : public CallbackFun
}; };
template <> template <>
class CORE_TEMPLATE_CLASS_EXPORT V8PersistentCallbackFunction<V8AnyCallbackFunctionOptionalAnyArg> final : public V8PersistentCallbackFunctionBase { class V8PersistentCallbackFunction<V8AnyCallbackFunctionOptionalAnyArg> final : public V8PersistentCallbackFunctionBase {
using V8CallbackFunction = V8AnyCallbackFunctionOptionalAnyArg; using V8CallbackFunction = V8AnyCallbackFunctionOptionalAnyArg;
public: public:
......
...@@ -40,7 +40,7 @@ class CORE_EXPORT V8LongCallbackFunction final : public CallbackFunctionBase { ...@@ -40,7 +40,7 @@ class CORE_EXPORT V8LongCallbackFunction final : public CallbackFunctionBase {
}; };
template <> template <>
class CORE_TEMPLATE_CLASS_EXPORT V8PersistentCallbackFunction<V8LongCallbackFunction> final : public V8PersistentCallbackFunctionBase { class V8PersistentCallbackFunction<V8LongCallbackFunction> final : public V8PersistentCallbackFunctionBase {
using V8CallbackFunction = V8LongCallbackFunction; using V8CallbackFunction = V8LongCallbackFunction;
public: public:
......
...@@ -40,7 +40,7 @@ class CORE_EXPORT V8StringSequenceCallbackFunctionLongSequenceArg final : public ...@@ -40,7 +40,7 @@ class CORE_EXPORT V8StringSequenceCallbackFunctionLongSequenceArg final : public
}; };
template <> template <>
class CORE_TEMPLATE_CLASS_EXPORT V8PersistentCallbackFunction<V8StringSequenceCallbackFunctionLongSequenceArg> final : public V8PersistentCallbackFunctionBase { class V8PersistentCallbackFunction<V8StringSequenceCallbackFunctionLongSequenceArg> final : public V8PersistentCallbackFunctionBase {
using V8CallbackFunction = V8StringSequenceCallbackFunctionLongSequenceArg; using V8CallbackFunction = V8StringSequenceCallbackFunctionLongSequenceArg;
public: public:
......
...@@ -72,7 +72,7 @@ class CORE_EXPORT V8TestCallbackInterface final : public CallbackInterfaceBase { ...@@ -72,7 +72,7 @@ class CORE_EXPORT V8TestCallbackInterface final : public CallbackInterfaceBase {
}; };
template <> template <>
class CORE_TEMPLATE_CLASS_EXPORT V8PersistentCallbackInterface<V8TestCallbackInterface> final : public V8PersistentCallbackInterfaceBase { class V8PersistentCallbackInterface<V8TestCallbackInterface> final : public V8PersistentCallbackInterfaceBase {
using V8CallbackInterface = V8TestCallbackInterface; using V8CallbackInterface = V8TestCallbackInterface;
public: public:
......
...@@ -48,7 +48,7 @@ class CORE_EXPORT V8TestLegacyCallbackInterface final : public CallbackInterface ...@@ -48,7 +48,7 @@ class CORE_EXPORT V8TestLegacyCallbackInterface final : public CallbackInterface
}; };
template <> template <>
class CORE_TEMPLATE_CLASS_EXPORT V8PersistentCallbackInterface<V8TestLegacyCallbackInterface> final : public V8PersistentCallbackInterfaceBase { class V8PersistentCallbackInterface<V8TestLegacyCallbackInterface> final : public V8PersistentCallbackInterfaceBase {
using V8CallbackInterface = V8TestLegacyCallbackInterface; using V8CallbackInterface = V8TestLegacyCallbackInterface;
public: public:
......
...@@ -44,7 +44,7 @@ class CORE_EXPORT V8VoidCallbackFunction final : public CallbackFunctionBase { ...@@ -44,7 +44,7 @@ class CORE_EXPORT V8VoidCallbackFunction final : public CallbackFunctionBase {
}; };
template <> template <>
class CORE_TEMPLATE_CLASS_EXPORT V8PersistentCallbackFunction<V8VoidCallbackFunction> final : public V8PersistentCallbackFunctionBase { class V8PersistentCallbackFunction<V8VoidCallbackFunction> final : public V8PersistentCallbackFunctionBase {
using V8CallbackFunction = V8VoidCallbackFunction; using V8CallbackFunction = V8VoidCallbackFunction;
public: public:
......
...@@ -45,7 +45,7 @@ class CORE_EXPORT V8VoidCallbackFunctionDictionaryArg final : public CallbackFun ...@@ -45,7 +45,7 @@ class CORE_EXPORT V8VoidCallbackFunctionDictionaryArg final : public CallbackFun
}; };
template <> template <>
class CORE_TEMPLATE_CLASS_EXPORT V8PersistentCallbackFunction<V8VoidCallbackFunctionDictionaryArg> final : public V8PersistentCallbackFunctionBase { class V8PersistentCallbackFunction<V8VoidCallbackFunctionDictionaryArg> final : public V8PersistentCallbackFunctionBase {
using V8CallbackFunction = V8VoidCallbackFunctionDictionaryArg; using V8CallbackFunction = V8VoidCallbackFunctionDictionaryArg;
public: public:
......
...@@ -44,7 +44,7 @@ class CORE_EXPORT V8VoidCallbackFunctionEnumArg final : public CallbackFunctionB ...@@ -44,7 +44,7 @@ class CORE_EXPORT V8VoidCallbackFunctionEnumArg final : public CallbackFunctionB
}; };
template <> template <>
class CORE_TEMPLATE_CLASS_EXPORT V8PersistentCallbackFunction<V8VoidCallbackFunctionEnumArg> final : public V8PersistentCallbackFunctionBase { class V8PersistentCallbackFunction<V8VoidCallbackFunctionEnumArg> final : public V8PersistentCallbackFunctionBase {
using V8CallbackFunction = V8VoidCallbackFunctionEnumArg; using V8CallbackFunction = V8VoidCallbackFunctionEnumArg;
public: public:
......
...@@ -45,7 +45,7 @@ class CORE_EXPORT V8VoidCallbackFunctionInterfaceArg final : public CallbackFunc ...@@ -45,7 +45,7 @@ class CORE_EXPORT V8VoidCallbackFunctionInterfaceArg final : public CallbackFunc
}; };
template <> template <>
class CORE_TEMPLATE_CLASS_EXPORT V8PersistentCallbackFunction<V8VoidCallbackFunctionInterfaceArg> final : public V8PersistentCallbackFunctionBase { class V8PersistentCallbackFunction<V8VoidCallbackFunctionInterfaceArg> final : public V8PersistentCallbackFunctionBase {
using V8CallbackFunction = V8VoidCallbackFunctionInterfaceArg; using V8CallbackFunction = V8VoidCallbackFunctionInterfaceArg;
public: public:
......
...@@ -45,7 +45,7 @@ class CORE_EXPORT V8VoidCallbackFunctionTestInterfaceSequenceArg final : public ...@@ -45,7 +45,7 @@ class CORE_EXPORT V8VoidCallbackFunctionTestInterfaceSequenceArg final : public
}; };
template <> template <>
class CORE_TEMPLATE_CLASS_EXPORT V8PersistentCallbackFunction<V8VoidCallbackFunctionTestInterfaceSequenceArg> final : public V8PersistentCallbackFunctionBase { class V8PersistentCallbackFunction<V8VoidCallbackFunctionTestInterfaceSequenceArg> final : public V8PersistentCallbackFunctionBase {
using V8CallbackFunction = V8VoidCallbackFunctionTestInterfaceSequenceArg; using V8CallbackFunction = V8VoidCallbackFunctionTestInterfaceSequenceArg;
public: public:
......
...@@ -44,7 +44,7 @@ class CORE_EXPORT V8VoidCallbackFunctionTypedef final : public CallbackFunctionB ...@@ -44,7 +44,7 @@ class CORE_EXPORT V8VoidCallbackFunctionTypedef final : public CallbackFunctionB
}; };
template <> template <>
class CORE_TEMPLATE_CLASS_EXPORT V8PersistentCallbackFunction<V8VoidCallbackFunctionTypedef> final : public V8PersistentCallbackFunctionBase { class V8PersistentCallbackFunction<V8VoidCallbackFunctionTypedef> final : public V8PersistentCallbackFunctionBase {
using V8CallbackFunction = V8VoidCallbackFunctionTypedef; using V8CallbackFunction = V8VoidCallbackFunctionTypedef;
public: public:
......
...@@ -44,7 +44,7 @@ class MODULES_EXPORT V8VoidCallbackFunctionModules final : public CallbackFuncti ...@@ -44,7 +44,7 @@ class MODULES_EXPORT V8VoidCallbackFunctionModules final : public CallbackFuncti
}; };
template <> template <>
class MODULES_TEMPLATE_CLASS_EXPORT V8PersistentCallbackFunction<V8VoidCallbackFunctionModules> final : public V8PersistentCallbackFunctionBase { class V8PersistentCallbackFunction<V8VoidCallbackFunctionModules> final : public V8PersistentCallbackFunctionBase {
using V8CallbackFunction = V8VoidCallbackFunctionModules; using V8CallbackFunction = V8VoidCallbackFunctionModules;
public: public:
......
...@@ -65,7 +65,4 @@ ...@@ -65,7 +65,4 @@
#endif // BLINK_CORE_IMPLEMENTATION #endif // BLINK_CORE_IMPLEMENTATION
// TODO(thakis): Remove all references to this, https://crbug.com/859989
#define CORE_TEMPLATE_CLASS_EXPORT
#endif // THIRD_PARTY_BLINK_RENDERER_CORE_CORE_EXPORT_H_ #endif // THIRD_PARTY_BLINK_RENDERER_CORE_CORE_EXPORT_H_
...@@ -14,7 +14,7 @@ namespace blink { ...@@ -14,7 +14,7 @@ namespace blink {
// Editing algorithm defined on node traversal. // Editing algorithm defined on node traversal.
template <typename Traversal> template <typename Traversal>
class CORE_TEMPLATE_CLASS_EXPORT EditingAlgorithm : public Traversal { class EditingAlgorithm : public Traversal {
STATIC_ONLY(EditingAlgorithm); STATIC_ONLY(EditingAlgorithm);
public: public:
......
...@@ -77,7 +77,7 @@ class CheckedTraversalNextIterator ...@@ -77,7 +77,7 @@ class CheckedTraversalNextIterator
// if |Range| objects doesn't live after DOM mutation. // if |Range| objects doesn't live after DOM mutation.
// //
template <typename Strategy> template <typename Strategy>
class CORE_TEMPLATE_CLASS_EXPORT EphemeralRangeTemplate final { class EphemeralRangeTemplate final {
STACK_ALLOCATED(); STACK_ALLOCATED();
public: public:
......
...@@ -12,8 +12,7 @@ ...@@ -12,8 +12,7 @@
namespace blink { namespace blink {
template <typename Strategy> template <typename Strategy>
class CORE_TEMPLATE_CLASS_EXPORT FullyClippedStateStackAlgorithm final class FullyClippedStateStackAlgorithm final : public BitStack {
: public BitStack {
STACK_ALLOCATED(); STACK_ALLOCATED();
public: public:
......
...@@ -41,7 +41,7 @@ class LayoutText; ...@@ -41,7 +41,7 @@ class LayoutText;
// boundaries at points where replaced elements break up the text flow. The text // boundaries at points where replaced elements break up the text flow. The text
// comes back in chunks so as to optimize for performance of the iteration. // comes back in chunks so as to optimize for performance of the iteration.
template <typename Strategy> template <typename Strategy>
class CORE_TEMPLATE_CLASS_EXPORT SimplifiedBackwardsTextIteratorAlgorithm { class SimplifiedBackwardsTextIteratorAlgorithm {
STACK_ALLOCATED(); STACK_ALLOCATED();
public: public:
......
...@@ -50,7 +50,7 @@ String PlainText(const EphemeralRangeInFlatTree&, ...@@ -50,7 +50,7 @@ String PlainText(const EphemeralRangeInFlatTree&,
// text comes back in chunks so as to optimize for performance of the iteration. // text comes back in chunks so as to optimize for performance of the iteration.
template <typename Strategy> template <typename Strategy>
class CORE_TEMPLATE_CLASS_EXPORT TextIteratorAlgorithm { class TextIteratorAlgorithm {
STACK_ALLOCATED(); STACK_ALLOCATED();
public: public:
......
...@@ -47,7 +47,7 @@ enum class PositionAnchorType : unsigned { ...@@ -47,7 +47,7 @@ enum class PositionAnchorType : unsigned {
// Instances of |PositionTemplate<Strategy>| are immutable. // Instances of |PositionTemplate<Strategy>| are immutable.
// TODO(editing-dev): Make constructor of |PositionTemplate| take |const Node*|. // TODO(editing-dev): Make constructor of |PositionTemplate| take |const Node*|.
template <typename Strategy> template <typename Strategy>
class CORE_TEMPLATE_CLASS_EXPORT PositionTemplate { class PositionTemplate {
DISALLOW_NEW(); DISALLOW_NEW();
public: public:
......
...@@ -39,7 +39,7 @@ namespace blink { ...@@ -39,7 +39,7 @@ namespace blink {
// Conversion to Position is O(1). // Conversion to Position is O(1).
// PositionIteratorAlgorithm must be used without DOM tree change. // PositionIteratorAlgorithm must be used without DOM tree change.
template <typename Strategy> template <typename Strategy>
class CORE_TEMPLATE_CLASS_EXPORT PositionIteratorAlgorithm { class PositionIteratorAlgorithm {
STACK_ALLOCATED(); STACK_ALLOCATED();
public: public:
......
...@@ -14,7 +14,7 @@ namespace blink { ...@@ -14,7 +14,7 @@ namespace blink {
enum class TextAffinity; enum class TextAffinity;
template <typename Strategy> template <typename Strategy>
class CORE_TEMPLATE_CLASS_EXPORT PositionWithAffinityTemplate { class PositionWithAffinityTemplate {
DISALLOW_NEW(); DISALLOW_NEW();
public: public:
......
...@@ -53,7 +53,7 @@ namespace blink { ...@@ -53,7 +53,7 @@ namespace blink {
// NOTE: UPSTREAM affinity will be used only if pos is at end of a wrapped line, // NOTE: UPSTREAM affinity will be used only if pos is at end of a wrapped line,
// otherwise it will be converted to DOWNSTREAM. // otherwise it will be converted to DOWNSTREAM.
template <typename Strategy> template <typename Strategy>
class CORE_TEMPLATE_CLASS_EXPORT VisiblePositionTemplate final { class VisiblePositionTemplate final {
DISALLOW_NEW(); DISALLOW_NEW();
public: public:
......
...@@ -43,7 +43,7 @@ class SelectionAdjuster; ...@@ -43,7 +43,7 @@ class SelectionAdjuster;
const TextAffinity kSelDefaultAffinity = TextAffinity::kDownstream; const TextAffinity kSelDefaultAffinity = TextAffinity::kDownstream;
template <typename Strategy> template <typename Strategy>
class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate { class VisibleSelectionTemplate {
DISALLOW_NEW(); DISALLOW_NEW();
public: public:
......
...@@ -47,7 +47,7 @@ class LineLayoutBoxModel; ...@@ -47,7 +47,7 @@ class LineLayoutBoxModel;
class LineLayoutItem; class LineLayoutItem;
template <typename InlineBoxType> template <typename InlineBoxType>
class CORE_TEMPLATE_CLASS_EXPORT InlineBoxList { class InlineBoxList {
DISALLOW_NEW(); DISALLOW_NEW();
public: public:
......
...@@ -36,7 +36,7 @@ class LayoutText; ...@@ -36,7 +36,7 @@ class LayoutText;
// offsets in |text_|. // offsets in |text_|.
// See https://goo.gl/CJbxky for more details about offset mapping. // See https://goo.gl/CJbxky for more details about offset mapping.
template <typename OffsetMappingBuilder> template <typename OffsetMappingBuilder>
class CORE_TEMPLATE_CLASS_EXPORT NGInlineItemsBuilderTemplate { class NGInlineItemsBuilderTemplate {
STACK_ALLOCATED(); STACK_ALLOCATED();
public: public:
......
...@@ -25,7 +25,7 @@ struct NGInlineNodeData; ...@@ -25,7 +25,7 @@ struct NGInlineNodeData;
// LayoutBlockFlow. // LayoutBlockFlow.
template <typename Base> template <typename Base>
class CORE_TEMPLATE_CLASS_EXPORT LayoutNGMixin : public Base { class LayoutNGMixin : public Base {
public: public:
explicit LayoutNGMixin(Element* element); explicit LayoutNGMixin(Element* element);
~LayoutNGMixin() override; ~LayoutNGMixin() override;
......
...@@ -25,8 +25,7 @@ ...@@ -25,8 +25,7 @@
namespace blink { namespace blink {
template <typename WTFTypedArray, typename V8TypedArray> template <typename WTFTypedArray, typename V8TypedArray>
class CORE_TEMPLATE_CLASS_EXPORT DOMTypedArray final class DOMTypedArray final : public DOMArrayBufferView {
: public DOMArrayBufferView {
typedef DOMTypedArray<WTFTypedArray, V8TypedArray> ThisType; typedef DOMTypedArray<WTFTypedArray, V8TypedArray> ThisType;
DECLARE_WRAPPERTYPEINFO(); DECLARE_WRAPPERTYPEINFO();
......
...@@ -12,8 +12,7 @@ ...@@ -12,8 +12,7 @@
namespace blink { namespace blink {
template <typename WTFTypedArray> template <typename WTFTypedArray>
class CORE_TEMPLATE_CLASS_EXPORT TypedFlexibleArrayBufferView final class TypedFlexibleArrayBufferView final : public FlexibleArrayBufferView {
: public FlexibleArrayBufferView {
STACK_ALLOCATED(); STACK_ALLOCATED();
public: public:
......
...@@ -42,7 +42,4 @@ ...@@ -42,7 +42,4 @@
#endif // !defined(COMPONENT_BUILD) #endif // !defined(COMPONENT_BUILD)
// TODO(thakis): Remove all references to this, https://crbug.com/859989
#define MODULES_TEMPLATE_CLASS_EXPORT
#endif // THIRD_PARTY_BLINK_RENDERER_MODULES_MODULES_EXPORT_H_ #endif // THIRD_PARTY_BLINK_RENDERER_MODULES_MODULES_EXPORT_H_
...@@ -70,7 +70,4 @@ ...@@ -70,7 +70,4 @@
#endif // !defined(COMPONENT_BUILD) #endif // !defined(COMPONENT_BUILD)
// TODO(thakis): Remove all references to this, https://crbug.com/859989
#define PLATFORM_TEMPLATE_CLASS_EXPORT
#endif // THIRD_PARTY_BLINK_RENDERER_PLATFORM_PLATFORM_EXPORT_H_ #endif // THIRD_PARTY_BLINK_RENDERER_PLATFORM_PLATFORM_EXPORT_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment