Commit 47c7dc1f authored by philipj@opera.com's avatar philipj@opera.com

Include HTMLFrameOwnerElement.h in fewer headers

Because HTMLFrameOwnerElement.h includes Document.h, the consequence is
mostly that Document.h includes need to be added.

Locally, this reduces the number of recompilation steps when touching
HTMLFrameOwnerElement.h from 579 to 117, and when touching Document.h
from 1214 to 1160.

There is a risk of performance regressions due to outlining
Frame::deprecatedLocalOwner().

Review URL: https://codereview.chromium.org/343593002

git-svn-id: svn://svn.chromium.org/blink/trunk@176433 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 9d45adc6
......@@ -7,6 +7,7 @@
#include "core/dom/shadow/ElementShadow.h"
#include "core/dom/shadow/ShadowRoot.h"
#include "core/html/HTMLFrameOwnerElement.h"
#include "wtf/Assertions.h"
namespace WebCore {
......
......@@ -5,12 +5,14 @@
#ifndef ChildFrameDisconnector_h
#define ChildFrameDisconnector_h
#include "core/dom/Node.h"
#include "core/html/HTMLFrameOwnerElement.h"
#include "platform/heap/Handle.h"
namespace WebCore {
class ElementShadow;
class HTMLFrameOwnerElement;
class Node;
class ChildFrameDisconnector {
STACK_ALLOCATED();
public:
......
......@@ -30,6 +30,7 @@
#include "core/CSSValueKeywords.h"
#include "core/HTMLNames.h"
#include "core/css/StylePropertySet.h"
#include "core/dom/Document.h"
#include "core/dom/Element.h"
#include "core/editing/ApplyStyleCommand.h"
#include "core/editing/EditingStyle.h"
......
......@@ -193,4 +193,9 @@ void Frame::disconnectOwnerElement()
m_owner = 0;
}
HTMLFrameOwnerElement* Frame::deprecatedLocalOwner() const
{
return m_owner && m_owner->isLocal() ? toHTMLFrameOwnerElement(m_owner) : 0;
}
} // namespace WebCore
......@@ -28,7 +28,6 @@
#ifndef Frame_h
#define Frame_h
#include "core/html/HTMLFrameOwnerElement.h"
#include "core/page/FrameTree.h"
#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
......@@ -41,12 +40,13 @@ class WebLayer;
namespace WebCore {
class DOMWindow;
class ChromeClient;
class DOMWindow;
class FrameClient;
class FrameDestructionObserver;
class FrameHost;
class FrameOwner;
class HTMLFrameOwnerElement;
class Page;
class RenderPart;
class Settings;
......@@ -139,11 +139,6 @@ inline FrameOwner* Frame::owner() const
return m_owner;
}
inline HTMLFrameOwnerElement* Frame::deprecatedLocalOwner() const
{
return m_owner && m_owner->isLocal() ? toHTMLFrameOwnerElement(m_owner) : 0;
}
inline FrameTree& Frame::tree() const
{
return m_treeNode;
......
......@@ -26,6 +26,7 @@
#include "core/html/HTMLLabelElement.h"
#include "core/HTMLNames.h"
#include "core/dom/Document.h"
#include "core/dom/ElementTraversal.h"
#include "core/editing/FrameSelection.h"
#include "core/events/MouseEvent.h"
......
......@@ -32,6 +32,7 @@
#include "core/html/HTMLNoEmbedElement.h"
#include "core/HTMLNames.h"
#include "core/dom/Document.h"
#include "core/frame/LocalFrame.h"
#include "core/loader/FrameLoader.h"
......
......@@ -33,6 +33,7 @@
#include "bindings/v8/ScriptController.h"
#include "core/HTMLNames.h"
#include "core/dom/Document.h"
#include "core/frame/LocalFrame.h"
namespace WebCore {
......
......@@ -24,6 +24,7 @@
#include "core/HTMLNames.h"
#include "core/InputTypeNames.h"
#include "core/dom/Document.h"
#include "core/dom/ElementTraversal.h"
#include "core/events/KeyboardEvent.h"
#include "core/events/MouseEvent.h"
......
......@@ -31,6 +31,7 @@
#include "config.h"
#include "core/html/forms/ValidationMessage.h"
#include "core/dom/Document.h"
#include "core/html/HTMLFormControlElement.h"
#include "core/page/Page.h"
#include "core/page/ValidationMessageClient.h"
......
......@@ -31,6 +31,7 @@
#include "config.h"
#include "core/html/ime/InputMethodContext.h"
#include "core/dom/Document.h"
#include "core/dom/Text.h"
#include "core/editing/InputMethodController.h"
#include "core/frame/LocalFrame.h"
......
......@@ -34,6 +34,7 @@
#include "core/frame/LocalFrame.h"
#include "core/frame/Settings.h"
#include "core/html/HTMLAreaElement.h"
#include "core/html/HTMLFrameOwnerElement.h"
#include "core/html/HTMLImageElement.h"
#include "core/page/FrameTree.h"
#include "core/page/Page.h"
......
......@@ -22,7 +22,6 @@
#define SpatialNavigation_h
#include "core/dom/Node.h"
#include "core/html/HTMLFrameOwnerElement.h"
#include "core/page/FocusType.h"
#include "platform/geometry/LayoutRect.h"
......@@ -33,6 +32,7 @@ namespace WebCore {
class Element;
class LocalFrame;
class HTMLAreaElement;
class HTMLFrameOwnerElement;
class IntRect;
class RenderObject;
......
......@@ -5,6 +5,7 @@
#include "config.h"
#include "web/WebRemoteFrameImpl.h"
#include "core/frame/FrameOwner.h"
#include "core/frame/RemoteFrame.h"
#include "public/platform/WebFloatRect.h"
#include "public/platform/WebRect.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment