Commit 47d4f7a0 authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

Revert "win: Disable CFG in release component builds for a bit."

This reverts commit d8f7927c.

Reason for revert: We rolled in a fixed clang. This workaround should
no longer be necessary.

Original change's description:
> win: Disable CFG in release component builds for a bit.
>
> After the 2nd-to-last clang roll, release component builds make
> chrome crash on launch due to CFG. Disable CFG for component builds
> until we roll in a fix.
>
> This does not affect shipping chrome, which doesn't use component builds.
> CFG was already disabled in debug component builds.
>
> Bug: 1147194,1147445
> Change-Id: Idd2ab6dcc6e89e604d8f0c6f37369f7b389b31c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532875
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826317}

TBR=thakis@chromium.org,hans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1147194
Bug: 1147445
Change-Id: If377b6d66f1a78105b1d41db8e68a30da9e39fcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539354
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827727}
parent adafeb4f
......@@ -361,9 +361,7 @@ config("cfi_linker") {
# ASan and CFG leads to slow process startup. Chromium's test runner uses
# lots of child processes, so this means things are really slow. Disable CFG
# for now. https://crbug.com/846966
# TODO(thakis): Re-enable in release component builds once they work again,
# https://crbug.com/1147194
if (!is_debug && !is_asan && !is_component_build) {
if (!is_debug && !is_asan) {
# Turn on CFG bitmap generation and CFG load config.
if (target_cpu == "arm64") {
# longjmp protection is temporarily disabled on Windows on Arm64 due to
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment