Skip to content

GitLab

T
tangled
Commit 47d94379 authored by Alexei Svitkine's avatar Alexei Svitkine Committed by Chromium LUCI CQ
Browse files
Options

Revert "Migrate U-Z histograms to patterned histogram syntax" 

This reverts commit 9b53f52e.

Reason for revert: Causing server pipeline breakage

Original change's description:
> Migrate U-Z histograms to patterned histogram syntax
>
> This is part of a migration that replaces the old
> <histogram-suffixes> syntax that was used to denote groups
> of histogram to the new patterned histogram syntax.
>
> Bug: 758782
> Change-Id: I6cde5e15fb8d43b58006569ca01cab5765fb79e3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552631
> Reviewed-by: Weilun Shi <sweilun@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Commit-Queue: Karthika Pai <karthikapai@google.com>
> Cr-Commit-Position: refs/heads/master@{#832494}

TBR=isherman@chromium.org,sweilun@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,karthikapai@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 758782
Change-Id: I1e6f202496d6bf30f18828ddb8a1ba2647f2eec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574779Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Reviewed-by: default avatarWeilun Shi <sweilun@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833876}
parent 24e521c6
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 233 additions and 420 deletions
tools/metrics/histograms/histograms_xml/histogram_suffixes_list.xml
View file @ 47d94379
......@@ -6578,6 +6578,24 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<affected-histogram name="FileBrowser.CrostiniSharedPaths.Depth"/>
</histogram_suffixes>
<histogram_suffixes name="FileOperations" separator=".">
<suffix name="DeleteFile.NonRecursive" label=""/>
<suffix name="DeleteFile.Recursive" label=""/>
<affected-histogram name="Windows.FilesystemError"/>
<affected-histogram name="Windows.PostOperationState"/>
</histogram_suffixes>
<histogram_suffixes name="FindInPageRequestEndState" separator=".">
<suffix name="Aborted"
label="The request got aborted before it went through every text in the
document."/>
<suffix name="Finished"
label="The request finished going through every text in the document."/>
<affected-histogram name="WebCore.FindInPage.NumberOfTasksPerRequest"/>
<affected-histogram name="WebCore.FindInPage.RequestDuration"/>
<affected-histogram name="WebCore.FindInPage.TotalTaskDuration"/>
</histogram_suffixes>
<histogram_suffixes name="FirstDownload" separator=".">
<obsolete>
Removed 2020-10.
......@@ -7901,6 +7919,15 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<affected-histogram name="InProductHelp.ShouldTriggerHelpUI"/>
</histogram_suffixes>
<histogram_suffixes name="IPProtocolType" separator="_">
<suffix name="TCP" label=""/>
<suffix name="UDP" label=""/>
<affected-histogram name="WebRTC.PeerConnection.CandidatePairType"/>
<affected-histogram name="WebRTC.SystemMaxConsecutiveBytesDelayed"/>
<affected-histogram name="WebRTC.SystemPercentPacketsDelayed"/>
<affected-histogram name="WebRTC.SystemSendPacketDuration"/>
</histogram_suffixes>
<histogram_suffixes name="IPv6_Probe" separator="_">
<suffix name="IPv6_probe_done"
label="with IPv6 probed for and possibly disabled"/>
......@@ -9398,6 +9425,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<affected-histogram name="NativeFileSystemAPI.WritePermissionRequestOutcome"/>
</histogram_suffixes>
<histogram_suffixes name="NatType" separator=".">
<suffix name="NoNAT" label=""/>
<suffix name="NonSymNAT" label=""/>
<suffix name="SymNAT" label=""/>
<suffix name="UnknownNAT" label=""/>
<affected-histogram name="WebRTC.Stun.BatchSuccessPercent"/>
<affected-histogram name="WebRTC.Stun.ResponseLatency"/>
<affected-histogram name="WebRTC.Stun.SuccessPercent"/>
</histogram_suffixes>
<histogram_suffixes name="NavigationCharacteristic" separator="_">
<suffix name="ExistingRenderer_BeforeUnloadDiscounted"
label="Navigation reused an existing renderer process. Time spent in
......@@ -16260,6 +16297,24 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
name="Scheduler.Experimental.Renderer.TotalTime.Wall.MainThread"/>
</histogram_suffixes>
<histogram_suffixes name="ScreenshareLayerStats" separator=".">
<suffix name="FrameRate"
label="Frames per second sent, in fps. The value is reported when a
stream is removed and is calculated as the total number of
frames in this layer, divided by the duration of the call."/>
<suffix name="Qp"
label="Average quantizer (qp) of frames sent. The value is reported
when a stream is removed and is calculated, for this layer, as
the sum of all qp values divided the number of frames."/>
<suffix name="TargetBitrate"
label="Average target bitrate in kbps. The value is reported when a
stream is removed and is calculated as the sum of all target
bitrates for this layer (sampled after frame has been encoded)
divided by the total number of frames for this layer."/>
<affected-histogram name="WebRTC.Video.Screenshare.Layer0"/>
<affected-histogram name="WebRTC.Video.Screenshare.Layer1"/>
</histogram_suffixes>
<histogram_suffixes name="ScrollSourceDevice" separator=".">
<suffix name="Touch" label="Touch"/>
<suffix name="Wheel" label="Wheel"/>
......@@ -19369,6 +19424,15 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<affected-histogram name="VRSessionVideoTime"/>
</histogram_suffixes>
<histogram_suffixes name="WebApkDistributorType" separator=".">
<suffix name="Browser" label="Installed by Chrome"/>
<suffix name="DevicePolicy" label="Installed by device policy"/>
<suffix name="Other" label="Installed by other sources"/>
<affected-histogram name="WebApk.Session.TotalDuration2"/>
<affected-histogram name="WebApk.ShellApkVersion2"/>
<affected-histogram name="WebApk.Uninstall"/>
</histogram_suffixes>
<histogram_suffixes name="WebApkType" separator=".">
<suffix name="BrowserApk" label="Installed by Chrome"/>
<suffix name="UnboundApk" label="Not installed by Chrome"/>
......@@ -19558,6 +19622,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<affected-histogram name="Media.UnderflowDuration2"/>
</histogram_suffixes>
<histogram_suffixes name="WebRTCEchoCancellerEstimate" separator=".">
<suffix name="Max" label="The maximum over the time interval"/>
<suffix name="Min" label="The minimum over the time interval"/>
<suffix name="Value" label="The last estimated value of the time interval"/>
<affected-histogram name="WebRTC.Audio.EchoCanceller.Erl"/>
<affected-histogram name="WebRTC.Audio.EchoCanceller.Erle"/>
</histogram_suffixes>
<histogram_suffixes name="WebRTCEchoCancellerStatisticType" separator=".">
<suffix name="Average" label="The average over the time interval"/>
<suffix name="Max" label="The maximum over the time interval"/>
......@@ -19572,6 +19644,50 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<affected-histogram name="WebRTC.Audio.EchoCanceller.SuppressorGainBand1"/>
</histogram_suffixes>
<histogram_suffixes name="WebRTCMediaType" separator=".">
<suffix name="Audio" label="Audio"/>
<suffix name="Data" label="Data"/>
<suffix name="Video" label="Video"/>
<affected-histogram name="WebRTC.PeerConnection.SrtpCryptoSuite"/>
<affected-histogram name="WebRTC.PeerConnection.SslCipherSuite"/>
</histogram_suffixes>
<histogram_suffixes name="WebRTCVideoExperimentGroupId" separator=".">
<owner>ilnik@chromium.org</owner>
<owner>webrtc-video@google.com</owner>
<suffix name="ExperimentGroup0" label=""/>
<suffix name="ExperimentGroup1" label=""/>
<suffix name="ExperimentGroup2" label=""/>
<suffix name="ExperimentGroup3" label=""/>
<suffix name="ExperimentGroup4" label=""/>
<suffix name="S0" label=""/>
<suffix name="S1" label=""/>
<suffix name="S2" label=""/>
<affected-histogram name="WebRTC.Video.Decoded.Vp8.Qp"/>
<affected-histogram name="WebRTC.Video.EndToEndDelayInMs"/>
<affected-histogram name="WebRTC.Video.EndToEndDelayMaxInMs"/>
<affected-histogram name="WebRTC.Video.InterframeDelay95PercentileInMs"/>
<affected-histogram name="WebRTC.Video.InterframeDelayInMs"/>
<affected-histogram name="WebRTC.Video.InterframeDelayMaxInMs"/>
<affected-histogram name="WebRTC.Video.KeyFramesReceivedInPermille"/>
<affected-histogram name="WebRTC.Video.MediaBitrateReceivedInKbps"/>
<affected-histogram name="WebRTC.Video.ReceivedHeightInPixels"/>
<affected-histogram name="WebRTC.Video.ReceivedWidthInPixels"/>
<affected-histogram name="WebRTC.Video.Screenshare.Decoded.Vp8.Qp"/>
<affected-histogram name="WebRTC.Video.Screenshare.EndToEndDelayInMs"/>
<affected-histogram name="WebRTC.Video.Screenshare.EndToEndDelayMaxInMs"/>
<affected-histogram
name="WebRTC.Video.Screenshare.InterframeDelay95PercentileInMs"/>
<affected-histogram name="WebRTC.Video.Screenshare.InterframeDelayInMs"/>
<affected-histogram name="WebRTC.Video.Screenshare.InterframeDelayMaxInMs"/>
<affected-histogram
name="WebRTC.Video.Screenshare.KeyFramesReceivedInPermille"/>
<affected-histogram
name="WebRTC.Video.Screenshare.MediaBitrateReceivedInKbps"/>
<affected-histogram name="WebRTC.Video.Screenshare.ReceivedHeightInPixels"/>
<affected-histogram name="WebRTC.Video.Screenshare.ReceivedWidthInPixels"/>
</histogram_suffixes>
<histogram_suffixes name="WebSocketErrorCodesVariants" separator="_">
<suffix name="Localhost" label=""/>
<suffix name="NotLocalhost" label=""/>
......
tools/metrics/histograms/histograms_xml/web_apk/histograms.xml
View file @ 47d94379
......@@ -21,12 +21,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histograms>
<variants name="WebApkDistributorType">
<variant name=".Browser" summary="Installed by Chrome"/>
<variant name=".DevicePolicy" summary="Installed by device policy"/>
<variant name=".Other" summary="Installed by other sources"/>
</variants>
<histogram name="WebApk.Install.AvailableSpace.Fail" units="MB"
expires_after="2021-02-01">
<owner>hartmanng@chromium.org</owner>
......@@ -172,22 +166,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</summary>
</histogram>
<histogram name="WebApk.Session.TotalDuration2{WebApkDistributorType}"
units="ms" expires_after="2021-05-16">
<histogram name="WebApk.Session.TotalDuration2" units="ms"
expires_after="2021-05-16">
<owner>hartmanng@chromium.org</owner>
<owner>
src/chrome/android/java/src/org/chromium/chrome/browser/webapps/OWNERS
</owner>
<summary>
The length of a WebAPK session (launch/foregrounding to backgrounding) in
milliseconds. {WebApkDistributorType}
milliseconds.
</summary>
<token key="WebApkDistributorType" variants="WebApkDistributorType">
<variant name=""/>
</token>
</histogram>
<histogram name="WebApk.ShellApkVersion2{WebApkDistributorType}" units="units"
<histogram base="true" name="WebApk.ShellApkVersion2" units="units"
expires_after="2021-04-04">
<owner>hartmanng@chromium.org</owner>
<owner>
......@@ -196,15 +187,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<summary>
Records WebAPK &quot;Shell APK version&quot; when the WebAPK is launched.
The &quot;Shell APK version&quot; is documented in shell_apk_version.gni
{WebApkDistributorType}
</summary>
<token key="WebApkDistributorType" variants="WebApkDistributorType">
<variant name="">
<obsolete>
Base histogram. Use suffixes of this histogram instead.
</obsolete>
</variant>
</token>
</histogram>
<histogram name="WebApk.Startup.Cold.NewStyle.ShellLaunchToSplashscreenVisible"
......@@ -257,22 +240,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</summary>
</histogram>
<histogram name="WebApk.Uninstall{WebApkDistributorType}" enum="BooleanHit"
<histogram base="true" name="WebApk.Uninstall" enum="BooleanHit"
expires_after="2021-06-06">
<owner>hartmanng@chromium.org</owner>
<owner>
src/chrome/android/java/src/org/chromium/chrome/browser/webapps/OWNERS
</owner>
<summary>
Records that a WebAPK was uninstalled. {WebApkDistributorType}
</summary>
<token key="WebApkDistributorType" variants="WebApkDistributorType">
<variant name="">
<obsolete>
Base histogram. Use suffixes of this histogram instead.
</obsolete>
</variant>
</token>
<summary>Records that a WebAPK was uninstalled.</summary>
</histogram>
<histogram name="WebApk.Update.GooglePlayUpdateResult"
......
tools/metrics/histograms/histograms_xml/web_core/histograms.xml
View file @ 47d94379
......@@ -21,14 +21,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histograms>
<variants name="FindInPageRequestEndState">
<variant name=".Aborted"
summary="The request got aborted before it went through every text in
the document."/>
<variant name=".Finished"
summary="The request finished going through every text in the document."/>
</variants>
<histogram name="WebCore.DistillabilityUs" units="microseconds"
expires_after="2021-04-04">
<owner>wychen@chromium.org</owner>
......@@ -66,42 +58,27 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</summary>
</histogram>
<histogram
name="WebCore.FindInPage.NumberOfTasksPerRequest{FindInPageRequestEndState}"
<histogram base="true" name="WebCore.FindInPage.NumberOfTasksPerRequest"
units="tasks" expires_after="2021-04-04">
<owner>rakina@chromium.org</owner>
<owner>altimin@chromium.org</owner>
<summary>
Records the number of find-in-page tasks executed for a find-in-page
request. Emitted when a find-in-page request is finished (it went through
the whole document) or when it got aborted. {FindInPageRequestEndState}
the whole document) or when it got aborted.
</summary>
<token key="FindInPageRequestEndState" variants="FindInPageRequestEndState">
<variant name="">
<obsolete>
Base histogram. Use suffixes of this histogram instead.
</obsolete>
</variant>
</token>
</histogram>
<histogram name="WebCore.FindInPage.RequestDuration{FindInPageRequestEndState}"
units="ms" expires_after="2021-04-04">
<histogram base="true" name="WebCore.FindInPage.RequestDuration" units="ms"
expires_after="2021-04-04">
<owner>rakina@chromium.org</owner>
<owner>altimin@chromium.org</owner>
<summary>
Records how long one find-in-page request (consisting multiple tasks) took
from the request start until the last find-in-page task for the request
finished. Emitted when a find-in-page request is finished (it went through
the whole document) or when it got aborted. {FindInPageRequestEndState}
the whole document) or when it got aborted.
</summary>
<token key="FindInPageRequestEndState" variants="FindInPageRequestEndState">
<variant name="">
<obsolete>
Base histogram. Use suffixes of this histogram instead.
</obsolete>
</variant>
</token>
</histogram>
<histogram name="WebCore.FindInPage.TaskDuration" units="ms"
......@@ -114,9 +91,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</summary>
</histogram>
<histogram
name="WebCore.FindInPage.TotalTaskDuration{FindInPageRequestEndState}"
units="ms" expires_after="2021-04-04">
<histogram base="true" name="WebCore.FindInPage.TotalTaskDuration" units="ms"
expires_after="2021-04-04">
<owner>rakina@chromium.org</owner>
<owner>altimin@chromium.org</owner>
<summary>
......@@ -124,15 +100,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
find-in-page request. Nothe that this does not include the time spent in
between tasks. Emitted when a find-in-page request is finished (it went
through the whole document) or when it got aborted.
{FindInPageRequestEndState}
</summary>
<token key="FindInPageRequestEndState" variants="FindInPageRequestEndState">
<variant name="">
<obsolete>
Base histogram. Use suffixes of this histogram instead.
</obsolete>
</variant>
</token>
</summary>
</histogram>
<histogram name="WebCore.Framebust.ClickThroughPosition"
......
tools/metrics/histograms/histograms_xml/windows/histograms.xml
View file @ 47d94379
......@@ -21,11 +21,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histograms>
<variants name="FileOperations">
<variant name=".DeleteFile.NonRecursive" summary=""/>
<variant name=".DeleteFile.Recursive" summary=""/>
</variants>
<histogram name="Windows.ApplockerRunning" enum="Boolean" expires_after="M83">
<owner>forshaw@chromium.org</owner>
<owner>wfh@chromium.org</owner>
......@@ -69,20 +64,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</summary>
</histogram>
<histogram name="Windows.FilesystemError{FileOperations}"
enum="WinGetLastError" expires_after="M81">
<histogram base="true" name="Windows.FilesystemError" enum="WinGetLastError"
expires_after="M81">
<owner>grt@chromium.org</owner>
<summary>
The Windows error code relating to a failed attempt to operate on a file or
a directory. {FileOperations}
a directory.
</summary>
<token key="FileOperations" variants="FileOperations">
<variant name="">
<obsolete>
Base histogram. Use suffixes of this histogram instead.
</obsolete>
</variant>
</token>
</histogram>
<histogram name="Windows.GetVersionExVersion" enum="WindowsVersion"
......@@ -293,20 +281,12 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</summary>
</histogram>
<histogram name="Windows.PostOperationState{FileOperations}"
<histogram base="true" name="Windows.PostOperationState"
enum="PostOperationState" expires_after="M81">
<owner>grt@chromium.org</owner>
<summary>
The state of an item in the filesystem following an operation on it.
{FileOperations}
</summary>
<token key="FileOperations" variants="FileOperations">
<variant name="">
<obsolete>
Base histogram. Use suffixes of this histogram instead.
</obsolete>
</variant>
</token>
</histogram>
<histogram name="Windows.ProcessorFamily" enum="ProcessorFamily"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment