Commit 47fecb11 authored by Kenneth Russell's avatar Kenneth Russell Committed by Commit Bot

Temporarily disable GPU info collection using NVML.

There are many crashes seen on Chrome Canary inside nvml.dll, so until
a pattern can be found and a workaround proposed, stop calling into it.

Bug: 693090, 873095
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0204273fb88ba8b61799916d98c843f0068ccadc
Tbr: zmo@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1171376
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Reviewed-by: default avatarZhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582307}
parent 5677b531
......@@ -13,7 +13,8 @@
namespace {
const unsigned int kDriverVersionCapacity = 80u;
// TODO(crbug.com/873095): diagnose crashes inside nvml.dll
// const unsigned int kDriverVersionCapacity = 80u;
} // anonymous namespace
......@@ -35,6 +36,9 @@ bool GetNvmlDeviceInfo(uint32_t pci_device_id,
*major_cuda_compute_capability = 0;
*minor_cuda_compute_capability = 0;
// TODO(crbug.com/873095): diagnose crashes inside nvml.dll
return false;
#if 0
base::FilePath dll_path;
if (!base::PathService::Get(base::DIR_PROGRAM_FILES6432, &dll_path)) {
return false;
......@@ -123,4 +127,5 @@ bool GetNvmlDeviceInfo(uint32_t pci_device_id,
return false;
}
return true;
#endif
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment