Commit 480f002f authored by jbudorick's avatar jbudorick Committed by Commit bot

[Android] Fix remote device test run TestPackage() methods.

BUG=428729

Review URL: https://codereview.chromium.org/801283005

Cr-Commit-Position: refs/heads/master@{#308382}
parent 6f899b27
...@@ -27,8 +27,9 @@ class RemoteDeviceGtestRun(remote_device_test_run.RemoteDeviceTestRun): ...@@ -27,8 +27,9 @@ class RemoteDeviceGtestRun(remote_device_test_run.RemoteDeviceTestRun):
DEFAULT_RUNNER_PACKAGE = ( DEFAULT_RUNNER_PACKAGE = (
'org.chromium.native_test.ChromiumNativeTestInstrumentationTestRunner') 'org.chromium.native_test.ChromiumNativeTestInstrumentationTestRunner')
#override
def TestPackage(self): def TestPackage(self):
pass return self._test_instance.suite
#override #override
def _TriggerSetUp(self): def _TriggerSetUp(self):
......
...@@ -41,9 +41,6 @@ class RemoteDeviceTestRun(test_run.TestRun): ...@@ -41,9 +41,6 @@ class RemoteDeviceTestRun(test_run.TestRun):
self._test_id = '' self._test_id = ''
self._results = '' self._results = ''
def TestPackage(self):
pass
#override #override
def RunTests(self): def RunTests(self):
"""Run the test.""" """Run the test."""
......
...@@ -34,8 +34,9 @@ class RemoteDeviceUirobotRun(remote_device_test_run.RemoteDeviceTestRun): ...@@ -34,8 +34,9 @@ class RemoteDeviceUirobotRun(remote_device_test_run.RemoteDeviceTestRun):
""" """
super(RemoteDeviceUirobotRun, self).__init__(env, test_instance) super(RemoteDeviceUirobotRun, self).__init__(env, test_instance)
#override
def TestPackage(self): def TestPackage(self):
pass return self._test_instance.package_name
#override #override
def _TriggerSetUp(self): def _TriggerSetUp(self):
......
...@@ -6,6 +6,7 @@ import os ...@@ -6,6 +6,7 @@ import os
from pylib import constants from pylib import constants
from pylib.base import test_instance from pylib.base import test_instance
from pylib.utils import apk_helper
class UirobotTestInstance(test_instance.TestInstance): class UirobotTestInstance(test_instance.TestInstance):
...@@ -19,6 +20,7 @@ class UirobotTestInstance(test_instance.TestInstance): ...@@ -19,6 +20,7 @@ class UirobotTestInstance(test_instance.TestInstance):
self._apk_under_test = os.path.join( self._apk_under_test = os.path.join(
constants.GetOutDirectory(), args.apk_under_test) constants.GetOutDirectory(), args.apk_under_test)
self._minutes = args.minutes self._minutes = args.minutes
self._package_name = apk_helper.GetPackageName(self._apk_under_test)
#override #override
def TestType(self): def TestType(self):
...@@ -40,12 +42,12 @@ class UirobotTestInstance(test_instance.TestInstance): ...@@ -40,12 +42,12 @@ class UirobotTestInstance(test_instance.TestInstance):
"""Returns the app to run the test on.""" """Returns the app to run the test on."""
return self._apk_under_test return self._apk_under_test
@property
def suite(self):
"""Returns the test suite, none for uirobot."""
return None
@property @property
def minutes(self): def minutes(self):
"""Returns the number of minutes to run the uirobot for.""" """Returns the number of minutes to run the uirobot for."""
return self._minutes return self._minutes
@property
def package_name(self):
"""Returns the name of the package in the APK."""
return self._package_name
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment