[Autofill] Added browser tests for local card migration flow (part 1)

The previous browser tests CL got reverted twice due to flaky tests,
so I will try to break the browser tests into several CLs. Listed the
following tests to be added in the TODO in the browser tests file.


Bug: 897998
Change-Id: Ib3c99de27028530e2f8bce7b616d7d5a9dae4cd3
Reviewed-on: https://chromium-review.googlesource.com/c/1364695
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#625435}

chrome/browser/ui/views/autofill/dialog_view_ids.h

@@ -8,17 +8,21 @@
 #include "components/autofill/core/browser/field_types.h"
 
 // This defines an enumeration of IDs that can uniquely identify a view within
-// the scope of the local and upload credit card save bubbles.
+// the scope of the local and upload credit card save bubbles as well as the
+// local card migration bubble and dialogs.
 
 namespace autofill {
 
 enum DialogViewId : int {
   VIEW_ID_NONE = 0,
 
-  // The following are the important containing views of the bubble.
-  MAIN_CONTENT_VIEW_LOCAL,   // The main content view, for a local save bubble
-  MAIN_CONTENT_VIEW_UPLOAD,  // The main content view, for an upload save bubble
-  FOOTNOTE_VIEW,             // Contains the legal messages for upload save
+  // The following views are contained in SaveCardBubbleViews.
+  MAIN_CONTENT_VIEW_LOCAL,   // The main content view for a local
+                             // save bubble
+  MAIN_CONTENT_VIEW_UPLOAD,  // The main content view for an upload
+                             // save bubble
+  FOOTNOTE_VIEW,             // The footnote view of either an upload
+                             // save bubble or a manage cards view.
   SIGN_IN_PROMO_VIEW,        // Contains the sign-in promo view
   MANAGE_CARDS_VIEW,         // The manage cards view
   EXPIRATION_DATE_VIEW,      // Contains the dropdowns for expiration date
@@ -26,6 +30,12 @@ enum DialogViewId : int {
   // The sub-view that contains the sign-in button in the promo.
   SIGN_IN_VIEW,
 
+  // The main content view for a migration offer bubble.
+  MAIN_CONTENT_VIEW_MIGRATION_BUBBLE,
+
+  // The main content view for the main migration dialog.
+  MAIN_CONTENT_VIEW_MIGRATION_OFFER_DIALOG,
+
   // The following are views::LabelButton objects (clickable).
   OK_BUTTON,            // Can say [Save], [Next], [Confirm],
                         // or [Done] depending on context

chrome/browser/ui/views/autofill/local_card_migration_bubble_views.cc

@@ -6,6 +6,7 @@
 
 #include <stddef.h>
 #include <memory>
+#include <utility>
 
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
@@ -29,6 +30,7 @@
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/style/typography.h"
+#include "ui/views/window/dialog_client_view.h"
 
 namespace autofill {
 
@@ -154,6 +156,7 @@ void LocalCardMigrationBubbleViews::Init() {
   explanatory_message->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   explanatory_message->SetMultiLine(true);
   AddChildView(explanatory_message);
+  set_id(DialogViewId::MAIN_CONTENT_VIEW_MIGRATION_BUBBLE);
 }
 
 }  // namespace autofill

chrome/browser/ui/views/autofill/local_card_migration_bubble_views.h

@@ -47,6 +47,8 @@ class LocalCardMigrationBubbleViews : public LocalCardMigrationBubble,
   void WindowClosing() override;
 
  private:
+  friend class LocalCardMigrationBrowserTest;
+
   ~LocalCardMigrationBubbleViews() override;
 
   // views::BubbleDialogDelegateView:

chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc

@@ -4,6 +4,10 @@
 
 #include "chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h"
 
+#include <memory>
+#include <string>
+#include <vector>
+
 #include "base/i18n/message_formatter.h"
 #include "base/location.h"
 #include "base/macros.h"
@@ -311,6 +315,8 @@ class LocalCardMigrationOfferView : public views::View,
   }
 
  private:
+  friend class LocalCardMigrationDialogView;
+
   LocalCardMigrationDialogController* controller_;
 
   views::View* card_list_view_ = nullptr;
@@ -467,6 +473,8 @@ void LocalCardMigrationDialogView::ConstructView() {
 
   if (view_state == LocalCardMigrationDialogState::kOffered) {
     offer_view_ = new LocalCardMigrationOfferView(controller_, this);
+    offer_view_->set_id(DialogViewId::MAIN_CONTENT_VIEW_MIGRATION_OFFER_DIALOG);
+    card_list_view_ = offer_view_->card_list_view_;
     AddChildView(offer_view_);
   } else {
     AddChildView(CreateFeedbackContentView(controller_, this).release());

chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h

@@ -51,7 +51,10 @@ class LocalCardMigrationDialogView : public LocalCardMigrationDialog,
   void UpdateLayout();
 
  private:
+  friend class LocalCardMigrationBrowserTest;
+
   void ConstructView();
+
   base::string16 GetOkButtonLabel() const;
   base::string16 GetCancelButtonLabel() const;
 
@@ -63,6 +66,10 @@ class LocalCardMigrationDialogView : public LocalCardMigrationDialog,
   // dialog is not in the 'offer' state.
   LocalCardMigrationOfferView* offer_view_ = nullptr;
 
+  // The view containing a list of cards. It is the content of the scroll bar.
+  // Owned by the LocalCardMigrationOfferView.
+  views::View* card_list_view_;
+
   DISALLOW_COPY_AND_ASSIGN(LocalCardMigrationDialogView);
 };
 

chrome/test/BUILD.gn

@@ -1539,6 +1539,7 @@ test("browser_tests") {
         "../browser/ui/views/autofill/autofill_popup_base_view_browsertest.cc",
         "../browser/ui/views/autofill/card_unmask_prompt_view_tester_views.cc",
         "../browser/ui/views/autofill/card_unmask_prompt_view_tester_views.h",
+        "../browser/ui/views/autofill/local_card_migration_browsertest.cc",
         "../browser/ui/views/autofill/save_card_bubble_views_browsertest.cc",
         "../browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc",
         "../browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h",

components/autofill/core/browser/credit_card_save_manager.h

@@ -124,6 +124,7 @@ class CreditCardSaveManager {
  private:
   friend class CreditCardSaveManagerTest;
   friend class CreditCardSaveManagerTestObserverBridge;
+  friend class LocalCardMigrationBrowserTest;
   friend class TestCreditCardSaveManager;
   friend class SaveCardBubbleViewsBrowserTestBase;
 

components/autofill/core/browser/form_data_importer.h

@@ -145,6 +145,7 @@ class FormDataImporter {
   friend class AutofillMergeTest;
   friend class FormDataImporterTest;
   friend class FormDataImporterTestBase;
+  friend class LocalCardMigrationBrowserTest;
   friend class SaveCardBubbleViewsBrowserTestBase;
   friend class SaveCardInfobarEGTestHelper;
   FRIEND_TEST_ALL_PREFIXES(AutofillMergeTest, MergeProfiles);

components/autofill/core/browser/local_card_migration_manager.cc

@@ -88,6 +88,9 @@ void LocalCardMigrationManager::AttemptToOfferLocalCardMigration(
     return;
   migration_request_ = payments::PaymentsClient::MigrationRequestDetails();
 
+  if (observer_for_testing_)
+    observer_for_testing_->OnDecideToRequestLocalCardMigration();
+
   payments_client_->GetUploadDetails(
       std::vector<AutofillProfile>(), GetDetectedValues(),
       /*active_experiments=*/std::vector<const char*>(), app_locale_,
@@ -145,15 +148,25 @@ bool LocalCardMigrationManager::IsCreditCardMigrationEnabled() {
   bool migration_experiment_enabled =
       features::GetLocalCardMigrationExperimentalFlag() !=
       features::LocalCardMigrationExperimentalFlag::kMigrationDisabled;
-  bool credit_card_upload_enabled = ::autofill::IsCreditCardUploadEnabled(
-      client_->GetPrefs(), client_->GetSyncService(),
-      client_->GetIdentityManager()->GetPrimaryAccountInfo().email);
+
+  // If |observer_for_testing_| is set, assume we are in a browsertest and
+  // credit card upload should be enabled by default. Cannot get around this as
+  // Chrome OS testing requires an unsupported email domain (i.e.
+  // stub-user@example.com).
+  bool credit_card_upload_enabled =
+      observer_for_testing_ ||
+      ::autofill::IsCreditCardUploadEnabled(
+          client_->GetPrefs(), client_->GetSyncService(),
+          client_->GetIdentityManager()->GetPrimaryAccountInfo().email);
+
   bool has_google_payments_account =
       (payments::GetBillingCustomerId(personal_data_manager_,
                                       payments_client_->GetPrefService()) != 0);
+
   bool sync_feature_enabled =
       (personal_data_manager_->GetSyncSigninState() ==
        AutofillSyncSigninState::kSignedInAndSyncFeature);
+
   return migration_experiment_enabled && credit_card_upload_enabled &&
          has_google_payments_account && sync_feature_enabled;
 }
@@ -163,6 +176,9 @@ void LocalCardMigrationManager::OnDidGetUploadDetails(
     AutofillClient::PaymentsRpcResult result,
     const base::string16& context_token,
     std::unique_ptr<base::Value> legal_message) {
+  if (observer_for_testing_)
+    observer_for_testing_->OnReceivedGetUploadDetailsResponse();
+
   if (result == AutofillClient::SUCCESS) {
     migration_request_.context_token = context_token;
     legal_message_ = base::DictionaryValue::From(std::move(legal_message));
@@ -196,6 +212,9 @@ void LocalCardMigrationManager::OnDidMigrateLocalCards(
     AutofillClient::PaymentsRpcResult result,
     std::unique_ptr<std::unordered_map<std::string, std::string>> save_result,
     const std::string& display_text) {
+  if (observer_for_testing_)
+    observer_for_testing_->OnReceivedMigrateCardsResponse();
+
   if (!save_result)
     return;
 
@@ -254,6 +273,9 @@ void LocalCardMigrationManager::OnDidGetMigrationRiskData(
 // Send the migration request. Will call payments_client to create a new
 // PaymentsRequest. Also create a new callback function OnDidMigrateLocalCards.
 void LocalCardMigrationManager::SendMigrateLocalCardsRequest() {
+  if (observer_for_testing_)
+    observer_for_testing_->OnSentMigrateCardsRequest();
+
   migration_request_.app_locale = app_locale_;
   migration_request_.billing_customer_number = payments::GetBillingCustomerId(
       personal_data_manager_, payments_client_->GetPrefService());

components/autofill/core/browser/local_card_migration_manager.h

@@ -43,7 +43,7 @@ class MigratableCreditCard {
     FAILURE_ON_UPLOAD,
   };
 
-  MigratableCreditCard(const CreditCard& credit_card);
+  explicit MigratableCreditCard(const CreditCard& credit_card);
   ~MigratableCreditCard();
 
   CreditCard credit_card() const { return credit_card_; }
@@ -66,6 +66,16 @@ class MigratableCreditCard {
 // Owned by FormDataImporter.
 class LocalCardMigrationManager {
  public:
+  // An observer class used by browsertests that gets notified whenever
+  // particular actions occur.
+  class ObserverForTest {
+   public:
+    virtual void OnDecideToRequestLocalCardMigration() = 0;
+    virtual void OnReceivedGetUploadDetailsResponse() = 0;
+    virtual void OnSentMigrateCardsRequest() = 0;
+    virtual void OnReceivedMigrateCardsResponse() = 0;
+  };
+
   // The parameters should outlive the LocalCardMigrationManager.
   LocalCardMigrationManager(AutofillClient* client,
                             payments::PaymentsClient* payments_client,
@@ -141,6 +151,7 @@ class LocalCardMigrationManager {
   payments::PaymentsClient* payments_client_;
 
  private:
+  friend class LocalCardMigrationBrowserTest;
   FRIEND_TEST_ALL_PREFIXES(LocalCardMigrationManagerTest,
                            MigrateCreditCard_MigrationPermanentFailure);
   FRIEND_TEST_ALL_PREFIXES(LocalCardMigrationManagerTest,
@@ -161,6 +172,11 @@ class LocalCardMigrationManager {
   // Finalizes the migration request and calls PaymentsClient.
   void SendMigrateLocalCardsRequest();
 
+  // For testing.
+  void SetEventObserverForTesting(ObserverForTest* observer) {
+    observer_for_testing_ = observer;
+  }
+
   std::unique_ptr<base::DictionaryValue> legal_message_;
 
   std::string app_locale_;
@@ -187,6 +203,9 @@ class LocalCardMigrationManager {
   // Record the triggering source of the local card migration.
   AutofillMetrics::LocalCardMigrationOrigin local_card_migration_origin_;
 
+  // Initialized only during tests.
+  ObserverForTest* observer_for_testing_ = nullptr;
+
   base::WeakPtrFactory<LocalCardMigrationManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(LocalCardMigrationManager);