Commit 4826012d authored by Himanshu Jaju's avatar Himanshu Jaju Committed by Commit Bot

Re-enable successful incoming payload test in nearby service.

The flakiness is due to the check for file existing on disk. Needs further
investigation, but re-enabling the test to ensure other checks for success
case are still in place.

Bug: 1123022
Change-Id: Ic04663c0670dd1ef2799e43e47d935445f47a1e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390160Reviewed-by: default avatarAlex Chau <alexchau@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803829}
parent 58d3ca9b
......@@ -2292,9 +2292,7 @@ TEST_F(NearbySharingServiceImplTest, AcceptValidShareTarget) {
service_->UnregisterReceiveSurface(&callback);
}
// TODO(crbug.com/1123022): flakily times-out.
TEST_F(NearbySharingServiceImplTest,
DISABLED_AcceptValidShareTarget_PayloadSuccessful) {
TEST_F(NearbySharingServiceImplTest, AcceptValidShareTarget_PayloadSuccessful) {
for (int64_t payload_id : kValidIntroductionFramePayloadIds) {
fake_nearby_connections_manager_->SetPayloadPathStatus(
payload_id, location::nearby::connections::mojom::Status::kSuccess);
......@@ -2397,7 +2395,9 @@ TEST_F(NearbySharingServiceImplTest,
EXPECT_FALSE(
fake_nearby_connections_manager_->connection_endpoint_info(kEndpointId));
EXPECT_TRUE(fake_nearby_connections_manager_->has_incoming_payloads());
EXPECT_TRUE(FileExists(file_path));
// TODO(crbug.com/1123022): This check is flaky, should be investigated.
// EXPECT_TRUE(FileExists(file_path));
// To avoid UAF in OnIncomingTransferUpdate().
service_->UnregisterReceiveSurface(&callback);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment