Commit 4843d985 authored by bmcquade's avatar bmcquade Committed by Commit bot

Remove clock resolution page load histograms.

These were temporary metrics intended to understand whether high/low
resolution clocks adversely impact page load metrics. After collecting a few
months of data it was determined that clock resolution doesn't adversely
impact our metrics, and it that these histograms were no longer needed.

BUG=394757

Review-Url: https://codereview.chromium.org/2155143003
Cr-Commit-Position: refs/heads/master@{#406143}
parent 6d456bbb
...@@ -198,11 +198,6 @@ const char kHistogramLoadTypeParseStartForwardBack[] = ...@@ -198,11 +198,6 @@ const char kHistogramLoadTypeParseStartForwardBack[] =
const char kHistogramLoadTypeParseStartNewNavigation[] = const char kHistogramLoadTypeParseStartNewNavigation[] =
"PageLoad.ParseTiming.NavigationToParseStart.LoadType.NewNavigation"; "PageLoad.ParseTiming.NavigationToParseStart.LoadType.NewNavigation";
const char kHistogramFirstContentfulPaintHigh[] =
"PageLoad.Timing2.NavigationToFirstContentfulPaint.HighResolutionClock";
const char kHistogramFirstContentfulPaintLow[] =
"PageLoad.Timing2.NavigationToFirstContentfulPaint.LowResolutionClock";
const char kHistogramFirstBackground[] = const char kHistogramFirstBackground[] =
"PageLoad.Timing2.NavigationToFirstBackground"; "PageLoad.Timing2.NavigationToFirstBackground";
const char kHistogramFirstForeground[] = const char kHistogramFirstForeground[] =
...@@ -582,15 +577,6 @@ void CorePageLoadMetricsObserver::RecordTimingHistograms( ...@@ -582,15 +577,6 @@ void CorePageLoadMetricsObserver::RecordTimingHistograms(
timing.first_contentful_paint, info)) { timing.first_contentful_paint, info)) {
PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaint, PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaint,
timing.first_contentful_paint.value()); timing.first_contentful_paint.value());
// Bucket these histograms into high/low resolution clock systems. This
// might point us to directions that will de-noise some UMA.
if (base::TimeTicks::IsHighResolution()) {
PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaintHigh,
timing.first_contentful_paint.value());
} else {
PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaintLow,
timing.first_contentful_paint.value());
}
PAGE_LOAD_HISTOGRAM( PAGE_LOAD_HISTOGRAM(
internal::kHistogramParseStartToFirstContentfulPaint, internal::kHistogramParseStartToFirstContentfulPaint,
timing.first_contentful_paint.value() - timing.parse_start.value()); timing.first_contentful_paint.value() - timing.parse_start.value());
......
...@@ -95081,6 +95081,12 @@ To add a new entry, add it with any value and run test to compute valid value. ...@@ -95081,6 +95081,12 @@ To add a new entry, add it with any value and run test to compute valid value.
</histogram_suffixes> </histogram_suffixes>
<histogram_suffixes name="ClockResolution" separator="."> <histogram_suffixes name="ClockResolution" separator=".">
<obsolete>
These were temporary metrics intended to understand whether high/low
resolution clocks adversely impact page load metrics. After collecting a few
months of data it was determined that clock resolution doesn't adversely
impact our metrics, and that these histograms were no longer needed.
</obsolete>
<suffix name="HighResolutionClock" <suffix name="HighResolutionClock"
label="base::TimeTicks::IsHighResolution() is true for this measurement"/> label="base::TimeTicks::IsHighResolution() is true for this measurement"/>
<suffix name="LowResolutionClock" <suffix name="LowResolutionClock"
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment