Revert "Remove external dependencies from |AudioInputImpl|"
This reverts commit 340ff5b3. Reason for revert: causes crash crbug.com/1158611 Original change's description: > Remove external dependencies from |AudioInputImpl| > > This will allow us to easier move this class to the Libassistant mojm > service. > > All dependencies have been moved to the new class |AudioInputHost|. > This class currently talks directly to |AudioInputImpl|, but later > it will instead talk to the mojom APIs. > > Some notes: > - |AudioInputImpl| still depends on > |AssistantClient::Get()->RequestAudioStreamFactory()|, because the > Libassistant mojom service will also use an audio stream factory to > open/close its audio input. In a follow up CL I will introduce a > delegate to sever this dependency. > - There is one behavior change: > |power_manager_client_->NotifyWakeNotification()| was previously > only called when DSP was enabled, and it is now always called (when > Libassistant starts a conversation). I can think of no reason why > this would be an issue. > > Bug: b/171748795 > Test: chromeos_unittests, deployed on real hardware with and without DSP. > Change-Id: I119521c7a72bf5361019d70240c02ba47a23d6ad > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582537 > Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836710} TBR=xiaohuic@chromium.org,wutao@chromium.org,meilinw@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jeroendh@chromium.org Change-Id: I2525fce21492c0417d0411db99fbb8463583cb02 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/171748795 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591771Reviewed-by:Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#836891}
Showing
Please register or sign in to comment