Commit 48af468c authored by edchin's avatar edchin Committed by Commit Bot

[ios] Handle both opaque and transparent buttons on sign-in

https://crrev.com/c/2312556 is a refactor that introduced a DCHECK
failure regarding (mouse) pointer support.

The signin confirmation button can either have an opaque background
(i.e., "Add Account" or "Yes, I'm in!") or a transparent background
(i.e., "More") when scrolling is needed to reach the bottom of the
screen.

This CL changes the style provider to one that handles both opaque
and transparent buttons.

Bug: 1127293
Change-Id: I9e27f012d79885324b32ba918bd4f3f48a59d235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413172
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: default avatarNohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807516}
parent f9749e44
...@@ -461,7 +461,7 @@ enum AuthenticationButtonType { ...@@ -461,7 +461,7 @@ enum AuthenticationButtonType {
if (base::FeatureList::IsEnabled(kPointerSupport)) { if (base::FeatureList::IsEnabled(kPointerSupport)) {
button.pointerInteractionEnabled = YES; button.pointerInteractionEnabled = YES;
button.pointerStyleProvider = button.pointerStyleProvider =
CreateTransparentButtonPointerStyleProvider(); CreateOpaqueOrTransparentButtonPointerStyleProvider();
} }
} }
#endif // defined(__IPHONE_13_4) #endif // defined(__IPHONE_13_4)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment