Commit 48bc8636 authored by Andreas Haas's avatar Andreas Haas Committed by Chromium LUCI CQ

Revert "[v8-browsing] Add WebAssembly UMA metrics to v8-browsing"

This reverts commit 6e5458b0.

Reason for revert: UMA metrics cause errors when more than one WebAssembly module gets compiled, see https://bugs.chromium.org/p/chromium/issues/detail?id=1163528

Original change's description:
> [v8-browsing] Add WebAssembly UMA metrics to v8-browsing
>
> This CL brings WebAssembly UMA metrics to the v8-browsing benchmark in
> Telemetry.
>
> R=​mythria@chromium.org, clemensb@chromium.org
>
> Bug: chromium:1084929
> Change-Id: I28e72378774c3d599da1ad670ba036a3f0ea84e0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497164
> Reviewed-by: Mythri Alle <mythria@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: Andreas Haas <ahaas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820779}

TBR=ahaas@chromium.org,mythria@chromium.org,clemensb@chromium.org,johnchen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:1084929, chromium:1163528
Change-Id: Id160376c4f56c160cf48bb9575e4b3c6d629e540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627153Reviewed-by: default avatarAndreas Haas <ahaas@chromium.org>
Reviewed-by: default avatarMythri Alle <mythria@chromium.org>
Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844012}
parent 46044e0a
...@@ -11,19 +11,6 @@ from telemetry.timeline import chrome_trace_config ...@@ -11,19 +11,6 @@ from telemetry.timeline import chrome_trace_config
from telemetry.web_perf import timeline_based_measurement from telemetry.web_perf import timeline_based_measurement
import page_sets import page_sets
V8_BROWSING_BENCHMARK_UMA = [
'V8.WasmCompileModuleMicroSeconds.wasm',
'V8.WasmCompileModuleAsyncMicroSeconds',
'V8.WasmCompileModuleStreamingMicroSeconds',
'V8.WasmFinishModuleStreamingMicroSeconds',
'V8.WasmTierUpModuleMicroSeconds',
'V8.WasmCompileFunctionMicroSeconds.wasm',
'V8.WasmInstantiateModuleMicroSeconds.wasm',
'V8.WasmModuleCodeSizeTopTierMiB',
'V8.WasmCompileFunctionPeakMemoryBytes',
'V8.WasmModuleCodeSizeMiB',
]
def AugmentOptionsForV8BrowsingMetrics(options, enable_runtime_call_stats=True): def AugmentOptionsForV8BrowsingMetrics(options, enable_runtime_call_stats=True):
categories = [ categories = [
...@@ -57,9 +44,6 @@ def AugmentOptionsForV8BrowsingMetrics(options, enable_runtime_call_stats=True): ...@@ -57,9 +44,6 @@ def AugmentOptionsForV8BrowsingMetrics(options, enable_runtime_call_stats=True):
options.config.chrome_trace_config.SetTraceBufferSizeInKb(400 * 1024) options.config.chrome_trace_config.SetTraceBufferSizeInKb(400 * 1024)
options.config.chrome_trace_config.EnableUMAHistograms(
*V8_BROWSING_BENCHMARK_UMA)
metrics = [ metrics = [
'blinkGcMetric', 'blinkGcMetric',
'consoleErrorMetric', 'consoleErrorMetric',
...@@ -68,7 +52,6 @@ def AugmentOptionsForV8BrowsingMetrics(options, enable_runtime_call_stats=True): ...@@ -68,7 +52,6 @@ def AugmentOptionsForV8BrowsingMetrics(options, enable_runtime_call_stats=True):
'memoryMetric', 'memoryMetric',
'pcscanMetric', 'pcscanMetric',
'reportedByPageMetric', 'reportedByPageMetric',
'umaMetric',
'wasmMetric', 'wasmMetric',
] ]
options.ExtendTimelineBasedMetric(metrics) options.ExtendTimelineBasedMetric(metrics)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment