Commit 48f5d794 authored by Yi Gu's avatar Yi Gu Committed by Commit Bot

[Sheriff] Disable Flaky test on ChromeOS

See bug for details.

TBR=hansenmichael@google.com

Bug: 1133295
Change-Id: I18353dee3eac0b18a1e5f4ccb6d333c3f0561662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438192Reviewed-by: default avatarYi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811698}
parent cb5a1635
...@@ -8,6 +8,7 @@ ...@@ -8,6 +8,7 @@
#include "base/optional.h" #include "base/optional.h"
#include "base/test/bind_test_util.h" #include "base/test/bind_test_util.h"
#include "build/build_config.h"
#include "chrome/browser/nearby_sharing/client/fake_nearby_share_client.h" #include "chrome/browser/nearby_sharing/client/fake_nearby_share_client.h"
#include "chrome/browser/nearby_sharing/common/nearby_share_prefs.h" #include "chrome/browser/nearby_sharing/common/nearby_share_prefs.h"
#include "chrome/browser/nearby_sharing/local_device_data/fake_nearby_share_device_data_updater.h" #include "chrome/browser/nearby_sharing/local_device_data/fake_nearby_share_device_data_updater.h"
...@@ -259,7 +260,13 @@ TEST_F(NearbyShareLocalDeviceDataManagerImplTest, DeviceId) { ...@@ -259,7 +260,13 @@ TEST_F(NearbyShareLocalDeviceDataManagerImplTest, DeviceId) {
EXPECT_EQ(id, manager()->GetId()); EXPECT_EQ(id, manager()->GetId());
} }
TEST_F(NearbyShareLocalDeviceDataManagerImplTest, ValidateDeviceName) { // Test is flaky. crbug.com/1133295.
#if defined(OS_CHROMEOS)
#define MAYBE_ValidateDeviceName DISABLED_ValidateDeviceName
#else
#define MAYBE_ValidateDeviceName ValidateDeviceName
#endif
TEST_F(NearbyShareLocalDeviceDataManagerImplTest, MAYBE_ValidateDeviceName) {
CreateManager(); CreateManager();
EXPECT_EQ(manager()->ValidateDeviceName(kFakeDeviceName), EXPECT_EQ(manager()->ValidateDeviceName(kFakeDeviceName),
nearby_share::mojom::DeviceNameValidationResult::kValid); nearby_share::mojom::DeviceNameValidationResult::kValid);
...@@ -272,7 +279,13 @@ TEST_F(NearbyShareLocalDeviceDataManagerImplTest, ValidateDeviceName) { ...@@ -272,7 +279,13 @@ TEST_F(NearbyShareLocalDeviceDataManagerImplTest, ValidateDeviceName) {
nearby_share::mojom::DeviceNameValidationResult::kErrorNotValidUtf8); nearby_share::mojom::DeviceNameValidationResult::kErrorNotValidUtf8);
} }
TEST_F(NearbyShareLocalDeviceDataManagerImplTest, SetDeviceName) { // Test is flaky. crbug.com/1133295.
#if defined(OS_CHROMEOS)
#define MAYBE_SetDeviceName DISABLED_SetDeviceName
#else
#define MAYBE_SetDeviceName SetDeviceName
#endif
TEST_F(NearbyShareLocalDeviceDataManagerImplTest, MAYBE_SetDeviceName) {
CreateManager(); CreateManager();
// The default device name is set in the ctor when the device name is empty. // The default device name is set in the ctor when the device name is empty.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment