Commit 48f80206 authored by Kevin Bailey's avatar Kevin Bailey Committed by Commit Bot

[omnibox browser test] Split up test and narrow waiting

I suspect that a test wasn't timing out due to slowness, but in fact
because a SINGLETON navigation was switching instead, and not waking up
waiting observers. This CL adds an explicit 'wait' parameter for
choosing (instead of relying on disposition).

It also splits up the respective test into SINGLETON and SWITCH_TO_TAB
versions (they're orthogonal) and cleans up some comments.

Bug: 822071
Change-Id: I241478b7a566b0e843f92b091d8f090ffbf9011c
Reviewed-on: https://chromium-review.googlesource.com/964386
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543695}
parent eb319ef3
...@@ -50,7 +50,8 @@ class BrowserNavigatorTest : public InProcessBrowserTest, ...@@ -50,7 +50,8 @@ class BrowserNavigatorTest : public InProcessBrowserTest,
Browser* NavigateHelper(const GURL& url, Browser* NavigateHelper(const GURL& url,
Browser* browser, Browser* browser,
WindowOpenDisposition disposition); WindowOpenDisposition disposition,
bool wait_for_navigation);
size_t created_tab_contents_count_; size_t created_tab_contents_count_;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment