DevTools: make createBrowserContext implementation async

We are planning to use ephemeral profiles to implement this method
in the future, but their creation is async. OTR profiles which are
currently used have synchronous creation, which is why this method
was synchronous so far.

This CL updates the implementation to be async, but does not yet
make any other changes. In later CLs we will plumb through the
callback to the async ephemeral profile creation.

Doc for context:
https://docs.google.com/document/d/1fnTD_smbp5vzWTLAuXagVsqm_C5607DPbKcfx6KbCTY

Bug: 1086935
Change-Id: I19c72bd002574ba8e6c810f3fff25d974e1f852e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230461Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775106}

content/browser/devtools/protocol/target_handler.cc

@@ -978,37 +978,43 @@ void TargetHandler::DevToolsAgentHostCrashed(DevToolsAgentHost* host,
 
 // ----------------- More protocol methods -------------------
 
-protocol::Response TargetHandler::CreateBrowserContext(
-    Maybe<bool> dispose_on_detach,
-    Maybe<std::string> proxy_server,
-    Maybe<std::string> proxy_bypass_list,
-    std::string* out_context_id) {
-  if (access_mode_ != AccessMode::kBrowser)
-    return Response::ServerError(kNotAllowedError);
+void TargetHandler::CreateBrowserContext(
+    Maybe<bool> in_disposeOnDetach,
+    Maybe<String> in_proxyServer,
+    Maybe<String> in_proxyBypassList,
+    std::unique_ptr<CreateBrowserContextCallback> callback) {
+  if (access_mode_ != AccessMode::kBrowser) {
+    callback->sendFailure(Response::ServerError(kNotAllowedError));
+    return;
+  }
   DevToolsManagerDelegate* delegate =
       DevToolsManager::GetInstance()->delegate();
-  if (!delegate)
-    return Response::ServerError(
-        "Browser context management is not supported.");
+  if (!delegate) {
+    callback->sendFailure(
+        Response::ServerError("Browser context management is not supported."));
+    return;
+  }
   BrowserContext* context = delegate->CreateBrowserContext();
-  if (!context)
-    return Response::ServerError("Failed to create browser context.");
+  if (!context) {
+    callback->sendFailure(
+        Response::ServerError("Failed to create browser context."));
+    return;
+  }
 
-  if (proxy_server.isJust()) {
+  if (in_proxyServer.isJust()) {
     net::ProxyConfig proxy_config;
-    proxy_config.proxy_rules().ParseFromString(proxy_server.fromJust());
-    if (proxy_bypass_list.isJust()) {
+    proxy_config.proxy_rules().ParseFromString(in_proxyServer.fromJust());
+    if (in_proxyBypassList.isJust()) {
       proxy_config.proxy_rules().bypass_rules.ParseFromString(
-          proxy_bypass_list.fromJust());
+          in_proxyBypassList.fromJust());
     }
     contexts_with_overridden_proxy_[context->UniqueId()] =
         std::move(proxy_config);
   }
 
-  *out_context_id = context->UniqueId();
-  if (dispose_on_detach.fromMaybe(false))
-    dispose_on_detach_context_ids_.insert(*out_context_id);
-  return Response::Success();
+  if (in_disposeOnDetach.fromMaybe(false))
+    dispose_on_detach_context_ids_.insert(context->UniqueId());
+  callback->sendSuccess(context->UniqueId());
 }
 
 protocol::Response TargetHandler::GetBrowserContexts(

content/browser/devtools/protocol/target_handler.h

@@ -88,10 +88,11 @@ class TargetHandler : public DevToolsDomainHandler,
                        bool* out_success) override;
   Response ExposeDevToolsProtocol(const std::string& target_id,
                                   Maybe<std::string> binding_name) override;
-  Response CreateBrowserContext(Maybe<bool> dispose_on_detach,
-                                Maybe<std::string> proxy_server,
-                                Maybe<std::string> proxy_bypass_list,
-                                std::string* out_context_id) override;
+  void CreateBrowserContext(
+      Maybe<bool> in_disposeOnDetach,
+      Maybe<String> in_proxyServer,
+      Maybe<String> in_proxyBypassList,
+      std::unique_ptr<CreateBrowserContextCallback> callback) override;
   void DisposeBrowserContext(
       const std::string& context_id,
       std::unique_ptr<DisposeBrowserContextCallback> callback) override;

content/browser/devtools/protocol_config.json

@@ -94,7 +94,7 @@
             },
             {
                 "domain": "Target",
-                "async": ["disposeBrowserContext", "setAutoAttach"]
+                "async": ["createBrowserContext", "disposeBrowserContext", "setAutoAttach"]
             },
             {
                 "domain": "Tethering",