Deliver bounds information to CreateTooltipWidget

When 'CreateTooltipWidget' creates 'Widget' for tooltip and
initializes it, it needs its bounds at InitParams. If it
doesn't have the bounds information, some platform widgets
get crashed and DesktopWindowTreeHostX11 keeps
|sanitized_params| to avoid this case.

This patch delivers the bounds for the tooltip widget and
adds DCHECK to find what causes the empty bounds.

Bug: 849585
Change-Id: I3de067a917e4343bab642c3a1b13434b6cfaeee0
Reviewed-on: https://chromium-review.googlesource.com/1086820Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#582426}

ui/platform_window/x11/x11_window_base.cc

@@ -164,6 +164,8 @@ void X11WindowBase::Close() {
 }
 
 void X11WindowBase::SetBounds(const gfx::Rect& bounds) {
+  DCHECK(!bounds.size().IsEmpty());
+
   if (xwindow_ != x11::None) {
     XWindowChanges changes = {0};
     unsigned value_mask = 0;

ui/views/corewm/tooltip_aura.cc

@@ -42,7 +42,8 @@ bool CanUseTranslucentTooltipWidget() {
 }
 
 // Creates a widget of type TYPE_TOOLTIP
-views::Widget* CreateTooltipWidget(aura::Window* tooltip_window) {
+views::Widget* CreateTooltipWidget(aura::Window* tooltip_window,
+                                   const gfx::Rect& bounds) {
   views::Widget* widget = new views::Widget;
   views::Widget::InitParams params;
   // For aura, since we set the type to TYPE_TOOLTIP, the widget will get
@@ -52,6 +53,7 @@ views::Widget* CreateTooltipWidget(aura::Window* tooltip_window) {
   DCHECK(params.context);
   params.keep_on_top = true;
   params.accept_events = false;
+  params.bounds = bounds;
   if (CanUseTranslucentTooltipWidget())
     params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
   params.shadow_type = views::Widget::InitParams::SHADOW_TYPE_NONE;
@@ -166,8 +168,8 @@ gfx::RenderText* TooltipAura::GetRenderTextForTest() {
   return tooltip_view_->render_text_for_test();
 }
 
-void TooltipAura::SetTooltipBounds(const gfx::Point& mouse_pos,
-                                   const gfx::Size& tooltip_size) {
+gfx::Rect TooltipAura::GetTooltipBounds(const gfx::Point& mouse_pos,
+                                        const gfx::Size& tooltip_size) {
   gfx::Rect tooltip_rect(mouse_pos, tooltip_size);
   tooltip_rect.Offset(kCursorOffsetX, kCursorOffsetY);
   display::Screen* screen = display::Screen::GetScreen();
@@ -186,7 +188,7 @@ void TooltipAura::SetTooltipBounds(const gfx::Point& mouse_pos,
     tooltip_rect.set_y(mouse_pos.y() - tooltip_size.height());
 
   tooltip_rect.AdjustToFit(display_bounds);
-  widget_->SetBounds(tooltip_rect);
+  return tooltip_rect;
 }
 
 void TooltipAura::DestroyWidget() {
@@ -210,14 +212,17 @@ void TooltipAura::SetText(aura::Window* window,
   tooltip_view_->SetMaxWidth(GetMaxWidth(location));
   tooltip_view_->SetText(tooltip_text);
 
+  const gfx::Rect adjusted_bounds =
+      GetTooltipBounds(location, tooltip_view_->GetPreferredSize());
+
   if (!widget_) {
-    widget_ = CreateTooltipWidget(tooltip_window_);
+    widget_ = CreateTooltipWidget(tooltip_window_, adjusted_bounds);
     widget_->SetContentsView(tooltip_view_.get());
     widget_->AddObserver(this);
+  } else {
+    widget_->SetBounds(adjusted_bounds);
   }
 
-  SetTooltipBounds(location, tooltip_view_->GetPreferredSize());
-
   ui::NativeTheme* native_theme = widget_->GetNativeTheme();
   tooltip_view_->SetBackgroundColor(native_theme->GetSystemColor(
       ui::NativeTheme::kColorId_TooltipBackground));

ui/views/corewm/tooltip_aura.h

@@ -38,9 +38,9 @@ class VIEWS_EXPORT TooltipAura : public Tooltip, public WidgetObserver {
   gfx::RenderText* GetRenderTextForTest();
 
   // Adjusts the bounds given by the arguments to fit inside the desktop
-  // and applies the adjusted bounds to the label_.
-  void SetTooltipBounds(const gfx::Point& mouse_pos,
-                        const gfx::Size& tooltip_size);
+  // and returns the adjusted bounds.
+  gfx::Rect GetTooltipBounds(const gfx::Point& mouse_pos,
+                             const gfx::Size& tooltip_size);
 
   // Destroys |widget_|.
   void DestroyWidget();