Commit 490eea10 authored by Tina Wang's avatar Tina Wang Committed by Commit Bot

[Sheriff] Add missing dependency of buildflags target

chrome/browser/browser_process.h imports chrome/common/buildflags.h but
doesn't include the target in BUILD.gn.

chrome/test/base/testing_profile.h ditto.

As the result, the files above maybe compiled before the buildflags.h
is generated, which caused multiple flaky build failure.

This CL added necessary target to deflake the build.

TBR=sky@chromium.org

Bug: 1063513
Change-Id: Ic3a74260351937382a9eabd32b9251d8d6057cd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116591
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: default avatarTina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752577}
parent 80cdb9f6
...@@ -2998,6 +2998,7 @@ jumbo_static_library("browser") { ...@@ -2998,6 +2998,7 @@ jumbo_static_library("browser") {
"//chrome/browser/share", "//chrome/browser/share",
"//chrome/browser/upboarding", "//chrome/browser/upboarding",
"//chrome/browser/updates", "//chrome/browser/updates",
"//chrome/common:non_code_constants",
"//chrome/services/media_gallery_util/public/cpp", "//chrome/services/media_gallery_util/public/cpp",
"//components/autofill_assistant/browser", "//components/autofill_assistant/browser",
"//components/cbor", "//components/cbor",
......
...@@ -168,6 +168,7 @@ static_library("test_support") { ...@@ -168,6 +168,7 @@ static_library("test_support") {
#"//chrome/app/theme:theme_resources", #"//chrome/app/theme:theme_resources",
"//chrome/browser:test_support", "//chrome/browser:test_support",
"//chrome/child", "//chrome/child",
"//chrome/common:non_code_constants",
"//chrome/common:test_support", "//chrome/common:test_support",
"//chrome/renderer", "//chrome/renderer",
"//chrome/renderer:test_support", "//chrome/renderer:test_support",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment