PDF Viewer: Show file name and page count among properties

Both properties are already loaded by the PDF Viewer UI, so there's no
need to send them again from the plugin, unlike the other properties.

Bug: 93619
Change-Id: I223fcc10d758da910bbf0b65bef5e4f6763ac210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622576
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842649}

chrome/browser/resources/pdf/elements/viewer-properties-dialog.html

@@ -38,7 +38,7 @@
     <table>
       <tr>
         <td class="name">$i18n{propertiesFileName}</td>
-        <td class="value" id="file-name">-</td>
+        <td class="value" id="file-name">[[fileName]]</td>
       </tr>
       <tr class="break">
         <td class="name">$i18n{propertiesFileSize}</td>
@@ -94,7 +94,7 @@
       </tr>
       <tr>
         <td class="name">$i18n{propertiesPageCount}</td>
-        <td class="value" id="page-count">-</td>
+        <td class="value" id="page-count">[[pageCount]]</td>
       </tr>
       <tr class="break">
         <td class="name">$i18n{propertiesPageSize}</td>

chrome/browser/resources/pdf/elements/viewer-properties-dialog.js

@@ -23,6 +23,10 @@ export class ViewerPropertiesDialogElement extends PolymerElement {
     return {
       /** @type {!DocumentMetadata} */
       documentMetadata: Object,
+
+      fileName: String,
+
+      pageCount: Number,
     };
   }
 

chrome/browser/resources/pdf/pdf_viewer.html

@@ -226,8 +226,8 @@
 
 <template is="dom-if" if="[[showPropertiesDialog_]]" restamp>
   <viewer-properties-dialog id="properties-dialog"
-      document-metadata="[[documentMetadata_]]"
-      on-close="onPropertiesDialogClose_">
+      document-metadata="[[documentMetadata_]]" file-name="[[fileName_]]"
+      page-count="[[docLength_]]" on-close="onPropertiesDialogClose_">
   </viewer-properties-dialog>
 </template>
 

chrome/browser/resources/pdf/pdf_viewer.js

@@ -181,6 +181,9 @@ export class PDFViewerElement extends PDFViewerBaseElement {
         value: () => {},
       },
 
+      /** @private */
+      fileName_: String,
+
       /** @private */
       hadPassword_: {
         type: Boolean,
@@ -257,10 +260,7 @@ export class PDFViewerElement extends PDFViewerBaseElement {
       },
 
       /** @private */
-      title_: {
-        type: String,
-        value: '',
-      },
+      title_: String,
 
       /** @private */
       twoUpViewEnabled_: {
@@ -405,7 +405,9 @@ export class PDFViewerElement extends PDFViewerBaseElement {
         () => chrome.mimeHandlerPrivate.setShowBeforeUnloadDialog(true));
     // </if>
 
-    this.title_ = getFilenameFromURL(this.originalUrl);
+    this.fileName_ = getFilenameFromURL(this.originalUrl);
+    this.title_ = this.fileName_;
+
     if (this.toolbarEnabled_) {
       this.getToolbar_().hidden = false;
     }
@@ -1060,8 +1062,7 @@ export class PDFViewerElement extends PDFViewerBaseElement {
    */
   setDocumentMetadata_(metadata) {
     this.documentMetadata_ = metadata;
-    this.title_ =
-        this.documentMetadata_.title || getFilenameFromURL(this.originalUrl);
+    this.title_ = this.documentMetadata_.title || this.fileName_;
     document.title = this.title_;
     this.canSerializeDocument_ = this.documentMetadata_.canSerializeDocument;
   }

chrome/test/data/pdf/viewer_properties_dialog_test.js

@@ -50,7 +50,7 @@ const tests = [
 
     // TODO(crbug.com/93169): None of the following expected values should be
     // '-' when support for every property is implemented.
-    [['file-name', '-'],
+    [['file-name', 'document_info.pdf'],
      ['file-size', '-'],
      ['title', 'Sample PDF Document Info'],
      ['author', 'Chromium Authors'],
@@ -61,7 +61,7 @@ const tests = [
      ['application', 'Your Preferred Text Editor'],
      ['pdf-producer', 'fixup_pdf_template.py'],
      ['pdf-version', '1.7'],
-     ['page-count', '-'],
+     ['page-count', '1'],
      ['page-size', '-'],
      ['fast-web-view', 'No'],
     ].forEach(([field, expectedValue]) => assertField(field, expectedValue));