Tab strip view: when focused, activate on space up

Bug: 1054741
Change-Id: Iae1362c77859c122c7100886788c64682aa569b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070735Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744118}

chrome/browser/ui/views/tabs/tab.cc

@@ -431,9 +431,7 @@ const char* Tab::GetClassName() const {
 }
 
 bool Tab::OnKeyPressed(const ui::KeyEvent& event) {
-  if ((event.key_code() == ui::VKEY_SPACE ||
-       event.key_code() == ui::VKEY_RETURN) &&
-      !IsSelected()) {
+  if (event.key_code() == ui::VKEY_RETURN && !IsSelected()) {
     controller_->SelectTab(this, event);
     return true;
   }
@@ -470,6 +468,14 @@ bool Tab::OnKeyPressed(const ui::KeyEvent& event) {
   return false;
 }
 
+bool Tab::OnKeyReleased(const ui::KeyEvent& event) {
+  if (event.key_code() == ui::VKEY_SPACE && !IsSelected()) {
+    controller_->SelectTab(this, event);
+    return true;
+  }
+  return false;
+}
+
 namespace {
 bool IsSelectionModifierDown(const ui::MouseEvent& event) {
 #if defined(OS_MACOSX)

chrome/browser/ui/views/tabs/tab.h

@@ -84,6 +84,7 @@ class Tab : public gfx::AnimationDelegate,
   void Layout() override;
   const char* GetClassName() const override;
   bool OnKeyPressed(const ui::KeyEvent& event) override;
+  bool OnKeyReleased(const ui::KeyEvent& event) override;
   bool OnMousePressed(const ui::MouseEvent& event) override;
   bool OnMouseDragged(const ui::MouseEvent& event) override;
   void OnMouseReleased(const ui::MouseEvent& event) override;