Add a generator to validate all builders appear in some console.

Change-Id: Ica03d95af30be8221b67648578460ba2c7ce4a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869682
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708734}

infra/config/consoles/android.packager.star

+luci.console_view(
+    name = 'android.packager',
+    header = '//consoles/chromium-header.textpb',
+    repo = 'https://chromium.googlesource.com/chromium/src',
+    entries = [
+        luci.console_view_entry(
+            builder = 'ci/android-avd-packager',
+            short_name = 'avd',
+        ),
+        luci.console_view_entry(
+            builder = 'ci/android-sdk-packager',
+            short_name = 'sdk',
+        ),
+    ],
+)

infra/config/consoles/chromium.fyi.star

@@ -305,6 +305,10 @@ luci.console_view(
             builder = 'ci/Win10 Tests x64 1803',
             category = 'win10|1803',
         ),
+        luci.console_view_entry(
+            builder = 'ci/win32-arm64-rel',
+            category = 'win32|arm64',
+        ),
         luci.console_view_entry(
             builder = 'ci/win-celab-builder-rel',
             category = 'celab',

infra/config/consoles/chromium.star

@@ -36,12 +36,22 @@ luci.console_view(
         ),
         luci.console_view_entry(
             builder = 'ci/win32-archive-rel',
-            category = 'win-rel',
+            category = 'win|rel',
             short_name = '32',
         ),
         luci.console_view_entry(
             builder = 'ci/win-archive-rel',
-            category = 'win-rel',
+            category = 'win|rel',
+            short_name = '64',
+        ),
+        luci.console_view_entry(
+            builder = 'ci/win32-archive-dbg',
+            category = 'win|dbg',
+            short_name = '32',
+        ),
+        luci.console_view_entry(
+            builder = 'ci/win-archive-dbg',
+            category = 'win|dbg',
             short_name = '64',
         ),
     ],

infra/config/consoles/findit.star

+luci.list_view(
+    name = 'findit',
+    entries = [
+        'findit/findit-rerun',
+        'findit/findit_variable',
+        'findit/linux_chromium_bot_db_exporter',
+    ],
+)

infra/config/consoles/tryserver.chromium.dawn.star

+luci.list_view(
+    name = 'tryserver.chromium.dawn',
+    entries = [
+        'try/dawn-linux-x64-deps-rel',
+        'try/dawn-mac-x64-deps-rel',
+        'try/dawn-win10-x64-deps-rel',
+        'try/dawn-win10-x86-deps-rel',
+        'try/linux-dawn-rel',
+        'try/mac-dawn-rel',
+        'try/win-dawn-rel',
+    ],
+)

infra/config/consoles/tryserver.chromium.linux.star

@@ -28,6 +28,7 @@ luci.list_view(
         'try/layout_test_leak_detection',
         'try/leak_detection_linux',
         'try/linux-annotator-rel',
+        'try/linux-dcheck-off-rel',
         'try/linux-gcc-rel',
         'try/linux-libfuzzer-asan-rel',
         'try/linux-ozone-rel',
@@ -35,6 +36,7 @@ luci.list_view(
         'try/linux-clang-tidy-dbg',
         'try/linux-clang-tidy-rel',
         'try/linux-trusty-rel',
+        'try/linux-webkit-msan-rel',
         'try/linux_arm',
         'try/linux_chromium_analysis',
         'try/linux_chromium_archive_rel_ng',

infra/config/consoles/tryserver.chromium.win.star

@@ -17,6 +17,8 @@ luci.list_view(
         'try/gpu-fyi-try-win10-nvidia-rel-32',
         'try/gpu-fyi-try-win10-nvidia-rel-64',
         'try/gpu-fyi-try-win10-nvidia-skgl-64',
+        'try/gpu-try-win10-nvidia-rel',
+        'try/win-asan',
         'try/win-libfuzzer-asan-rel',
         'try/win7-rel',
         'try/win10_chromium_x64_dbg_ng',

infra/config/generated/luci-milo.cfg

@@ -4,6 +4,258 @@
 # For the schema of this file, see Project message:
 #   https://luci-config.appspot.com/schemas/projects:luci-milo.cfg
 
+consoles: <
+  id: "android.packager"
+  name: "android.packager"
+  repo_url: "https://chromium.googlesource.com/chromium/src"
+  refs: "regexp:refs/heads/master"
+  manifest_name: "REVISION"
+  builders: <
+    name: "buildbucket/luci.chromium.ci/android-avd-packager"
+    short_name: "avd"
+  >
+  builders: <
+    name: "buildbucket/luci.chromium.ci/android-sdk-packager"
+    short_name: "sdk"
+  >
+  header: <
+    oncalls: <
+      name: "Chromium"
+      url: "https://rota-ng.appspot.com/legacy/sheriff.json"
+    >
+    oncalls: <
+      name: "Android"
+      url: "https://rota-ng.appspot.com/legacy/sheriff_android.json"
+    >
+    oncalls: <
+      name: "iOS"
+      url: "https://rota-ng.appspot.com/legacy/sheriff_ios.json"
+    >
+    oncalls: <
+      name: "GPU"
+      url: "https://rota-ng.appspot.com/legacy/sheriff_gpu.json"
+    >
+    oncalls: <
+      name: "Angle"
+      url: "https://rota-ng.appspot.com/legacy/sheriff_angle.json"
+    >
+    oncalls: <
+      name: "Perf"
+      url: "https://rota-ng.appspot.com/legacy/sheriff_perf.json"
+    >
+    oncalls: <
+      name: "Perfbot"
+      url: "https://rota-ng.appspot.com/legacy/sheriff_perfbot.json"
+    >
+    oncalls: <
+      name: "V8"
+      url: "https://rota-ng.appspot.com/legacy/sheriff_v8.json"
+    >
+    oncalls: <
+      name: "Trooper"
+      url: "https://rota-ng.appspot.com/legacy/trooper.json"
+    >
+    links: <
+      name: "Builds"
+      links: <
+        text: "continuous"
+        url: "https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html"
+        alt: "Continuous browser snapshots"
+      >
+      links: <
+        text: "symbols"
+        url: "https://www.chromium.org/developers/how-tos/debugging-on-windows"
+        alt: "Windows Symbols"
+      >
+      links: <
+        text: "status"
+        url: "https://chromium-status.appspot.com/"
+        alt: "Current tree status"
+      >
+    >
+    links: <
+      name: "Dashboards"
+      links: <
+        text: "perf"
+        url: "https://chromeperf.appspot.com/"
+        alt: "Chrome perf dashboard"
+      >
+      links: <
+        text: "flake-portal"
+        url: "https://analysis.chromium.org/p/chromium/flake-portal"
+        alt: "New flake portal"
+      >
+      links: <
+        text: "legacy-flakiness"
+        url: "https://test-results.appspot.com/dashboards/flakiness_dashboard.html"
+        alt: "Legacy flakiness dashboard"
+      >
+    >
+    links: <
+      name: "Chromium"
+      links: <
+        text: "source"
+        url: "https://chromium.googlesource.com/chromium/src"
+        alt: "Chromium source code repository"
+      >
+      links: <
+        text: "reviews"
+        url: "https://chromium-review.googlesource.com"
+        alt: "Chromium code review tool"
+      >
+      links: <
+        text: "bugs"
+        url: "https://crbug.com"
+        alt: "Chromium bug tracker"
+      >
+      links: <
+        text: "coverage"
+        url: "https://analysis.chromium.org/p/chromium/coverage"
+        alt: "Chromium code coverage dashboard"
+      >
+      links: <
+        text: "dev"
+        url: "https://dev.chromium.org/Home"
+        alt: "Chromium developer home page"
+      >
+      links: <
+        text: "support"
+        url: "https://support.google.com/chrome/#topic=7438008"
+        alt: "Google Chrome help center"
+      >
+    >
+    links: <
+      name: "Consoles"
+      links: <
+        text: "android"
+        url: "/p/chromium/g/chromium.android"
+        alt: "Chromium Android console"
+      >
+      links: <
+        text: "clang"
+        url: "/p/chromium/g/chromium.clang"
+        alt: "Chromium Clang console"
+      >
+      links: <
+        text: "dawn"
+        url: "/p/chromium/g/chromium.dawn"
+        alt: "Chromium Dawn console"
+      >
+      links: <
+        text: "fuzz"
+        url: "/p/chromium/g/chromium.fuzz"
+        alt: "Chromium Fuzz console"
+      >
+      links: <
+        text: "fyi"
+        url: "/p/chromium/g/chromium.fyi"
+        alt: "Chromium FYI console"
+      >
+      links: <
+        text: "gpu"
+        url: "/p/chromium/g/chromium.gpu"
+        alt: "Chromium GPU console"
+      >
+      links: <
+        text: "perf"
+        url: "/p/chrome/g/chrome.perf/console"
+        alt: "Chromium Perf console"
+      >
+      links: <
+        text: "perf.fyi"
+        url: "/p/chrome/g/chrome.perf.fyi/console"
+        alt: "Chromium Perf FYI console"
+      >
+      links: <
+        text: "webrtc"
+        url: "/p/chromium/g/chromium.webrtc"
+        alt: "Chromium WebRTC console"
+      >
+      links: <
+        text: "chromiumos"
+        url: "/p/chromium/g/chromium.chromiumos"
+        alt: "ChromiumOS console"
+      >
+    >
+    links: <
+      name: "Tryservers"
+      links: <
+        text: "android"
+        url: "/p/chromium/g/tryserver.chromium.android/builders"
+        alt: "Android"
+      >
+      links: <
+        text: "angle"
+        url: "/p/chromium/g/angle.try/builders"
+        alt: "Angle"
+      >
+      links: <
+        text: "blink"
+        url: "/p/chromium/g/tryserver.blink/builders"
+        alt: "Blink"
+      >
+      links: <
+        text: "chrome"
+        url: "/p/chrome/g/tryserver.chrome/builders"
+        alt: "Chrome"
+      >
+      links: <
+        text: "chromiumos"
+        url: "/p/chromium/g/tryserver.chromium.chromiumos/builders"
+        alt: "ChromiumOS"
+      >
+      links: <
+        text: "linux"
+        url: "/p/chromium/g/tryserver.chromium.linux/builders"
+        alt: "Linux"
+      >
+      links: <
+        text: "mac"
+        url: "/p/chromium/g/tryserver.chromium.mac/builders"
+        alt: "Mac"
+      >
+      links: <
+        text: "win"
+        url: "/p/chromium/g/tryserver.chromium.win/builders"
+        alt: "Win"
+      >
+    >
+    links: <
+      name: "Navigate"
+      links: <
+        text: "about"
+        url: "http://dev.chromium.org/developers/testing/chromium-build-infrastructure/tour-of-the-chromium-buildbot"
+        alt: "Tour of the console"
+      >
+      links: <
+        text: "customize"
+        url: "https://chromium.googlesource.com/chromium/src/+/master/infra/config/luci-milo.cfg"
+        alt: "Customize this console"
+      >
+    >
+    console_groups: <
+      title: <
+        text: "Tree Closers"
+        url: "https://chromium-status.appspot.com/"
+      >
+      console_ids: "chromium/chromium"
+      console_ids: "chromium/chromium.win"
+      console_ids: "chromium/chromium.mac"
+      console_ids: "chromium/chromium.linux"
+      console_ids: "chromium/chromium.chromiumos"
+      console_ids: "chrome/chrome"
+      console_ids: "chromium/chromium.memory"
+      console_ids: "chromium/chromium.gpu"
+    >
+    console_groups: <
+      console_ids: "chromium/chromium.android"
+      console_ids: "chrome/chrome.perf"
+      console_ids: "chromium/chromium.gpu.fyi"
+      console_ids: "chromium/chromium.fuzz"
+    >
+    tree_status_host: "chromium-status.appspot.com"
+  >
+>
 consoles: <
   id: "angle.try"
   name: "angle.try"
@@ -92,12 +344,22 @@ consoles: <
   >
   builders: <
     name: "buildbucket/luci.chromium.ci/win32-archive-rel"
-    category: "win-rel"
+    category: "win|rel"
     short_name: "32"
   >
   builders: <
     name: "buildbucket/luci.chromium.ci/win-archive-rel"
-    category: "win-rel"
+    category: "win|rel"
+    short_name: "64"
+  >
+  builders: <
+    name: "buildbucket/luci.chromium.ci/win32-archive-dbg"
+    category: "win|dbg"
+    short_name: "32"
+  >
+  builders: <
+    name: "buildbucket/luci.chromium.ci/win-archive-dbg"
+    category: "win|dbg"
     short_name: "64"
   >
   header: <
@@ -2855,6 +3117,10 @@ consoles: <
     name: "buildbucket/luci.chromium.ci/Win10 Tests x64 1803"
     category: "win10|1803"
   >
+  builders: <
+    name: "buildbucket/luci.chromium.ci/win32-arm64-rel"
+    category: "win32|arm64"
+  >
   builders: <
     name: "buildbucket/luci.chromium.ci/win-celab-builder-rel"
     category: "celab"
@@ -7910,6 +8176,20 @@ consoles: <
     tree_status_host: "chromium-status.appspot.com"
   >
 >
+consoles: <
+  id: "findit"
+  name: "findit"
+  builders: <
+    name: "buildbucket/luci.chromium.findit/findit-rerun"
+  >
+  builders: <
+    name: "buildbucket/luci.chromium.findit/findit_variable"
+  >
+  builders: <
+    name: "buildbucket/luci.chromium.findit/linux_chromium_bot_db_exporter"
+  >
+  builder_view_only: true
+>
 consoles: <
   id: "goma.latest"
   name: "goma.latest"
@@ -10282,6 +10562,32 @@ consoles: <
   >
   builder_view_only: true
 >
+consoles: <
+  id: "tryserver.chromium.dawn"
+  name: "tryserver.chromium.dawn"
+  builders: <
+    name: "buildbucket/luci.chromium.try/dawn-linux-x64-deps-rel"
+  >
+  builders: <
+    name: "buildbucket/luci.chromium.try/dawn-mac-x64-deps-rel"
+  >
+  builders: <
+    name: "buildbucket/luci.chromium.try/dawn-win10-x64-deps-rel"
+  >
+  builders: <
+    name: "buildbucket/luci.chromium.try/dawn-win10-x86-deps-rel"
+  >
+  builders: <
+    name: "buildbucket/luci.chromium.try/linux-dawn-rel"
+  >
+  builders: <
+    name: "buildbucket/luci.chromium.try/mac-dawn-rel"
+  >
+  builders: <
+    name: "buildbucket/luci.chromium.try/win-dawn-rel"
+  >
+  builder_view_only: true
+>
 consoles: <
   id: "tryserver.chromium.linux"
   name: "tryserver.chromium.linux"
@@ -10366,6 +10672,9 @@ consoles: <
   builders: <
     name: "buildbucket/luci.chromium.try/linux-annotator-rel"
   >
+  builders: <
+    name: "buildbucket/luci.chromium.try/linux-dcheck-off-rel"
+  >
   builders: <
     name: "buildbucket/luci.chromium.try/linux-gcc-rel"
   >
@@ -10387,6 +10696,9 @@ consoles: <
   builders: <
     name: "buildbucket/luci.chromium.try/linux-trusty-rel"
   >
+  builders: <
+    name: "buildbucket/luci.chromium.try/linux-webkit-msan-rel"
+  >
   builders: <
     name: "buildbucket/luci.chromium.try/linux_arm"
   >
@@ -10619,6 +10931,12 @@ consoles: <
   builders: <
     name: "buildbucket/luci.chromium.try/gpu-fyi-try-win10-nvidia-skgl-64"
   >
+  builders: <
+    name: "buildbucket/luci.chromium.try/gpu-try-win10-nvidia-rel"
+  >
+  builders: <
+    name: "buildbucket/luci.chromium.try/win-asan"
+  >
   builders: <
     name: "buildbucket/luci.chromium.try/win-libfuzzer-asan-rel"
   >

infra/config/main.star

@@ -81,6 +81,7 @@ exec('//buckets/try.star')
 exec('//buckets/webrtc.star')
 exec('//buckets/webrtc.fyi.star')
 
+exec('//consoles/android.packager.star')
 exec('//consoles/angle.try.star')
 exec('//consoles/chromium.star')
 exec('//consoles/chromium.android.star')
@@ -102,6 +103,7 @@ exec('//consoles/chromium.memory.star')
 exec('//consoles/chromium.webrtc.star')
 exec('//consoles/chromium.webrtc.fyi.star')
 exec('//consoles/chromium.win.star')
+exec('//consoles/findit.star')
 exec('//consoles/goma.latest.star')
 exec('//consoles/luci.chromium.goma.star')
 exec('//consoles/luci.chromium.try.star')
@@ -110,8 +112,11 @@ exec('//consoles/sheriff.ios.star')
 exec('//consoles/tryserver.blink.star')
 exec('//consoles/tryserver.chromium.android.star')
 exec('//consoles/tryserver.chromium.chromiumos.star')
+exec('//consoles/tryserver.chromium.dawn.star')
 exec('//consoles/tryserver.chromium.linux.star')
 exec('//consoles/tryserver.chromium.mac.star')
 exec('//consoles/tryserver.chromium.win.star')
 
-exec('//cq-builders-md.star')
+exec('//generators/cq-builders-md.star')
+
+exec('//validators/builders-in-consoles.star')

infra/config/validators/builders-in-consoles.star

+def _validate_builders_in_console(ctx):
+  builders = {}
+
+  for console in ctx.output['luci-milo.cfg'].consoles:
+    for builder in console.builders:
+      for name in builder.name:
+        _, long_bucket, builder_name = name.split('/')
+        _, _, bucket = long_bucket.split('.', 2)
+        builders.setdefault(bucket, {})[builder_name] = True
+
+  builders_without_console = []
+
+  for bucket in ctx.output['cr-buildbucket.cfg'].buckets:
+    bucket_builders = builders.get(bucket.name, {})
+    for builder in bucket.swarming.builders:
+      if builder.name not in bucket_builders:
+        builders_without_console.append(
+            '{}/{}'.format(bucket.name, builder.name))
+
+  if builders_without_console:
+    fail('The following builders do not appear in any console:\n  '
+         + '\n  '.join([repr(b) for b in builders_without_console]))
+
+lucicfg.generator(_validate_builders_in_console)