Add a generator to validate all builders appear in some console.

Change-Id: Ica03d95af30be8221b67648578460ba2c7ce4a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869682
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708734}

infra/config/consoles/android.packager.star

+luci.console_view(
+    name = 'android.packager',
+    header = '//consoles/chromium-header.textpb',
+    repo = 'https://chromium.googlesource.com/chromium/src',
+    entries = [
+        luci.console_view_entry(
+            builder = 'ci/android-avd-packager',
+            short_name = 'avd',
+        ),
+        luci.console_view_entry(
+            builder = 'ci/android-sdk-packager',
+            short_name = 'sdk',
+        ),
+    ],
+)

infra/config/consoles/chromium.fyi.star

@@ -305,6 +305,10 @@ luci.console_view(
             builder = 'ci/Win10 Tests x64 1803',
             category = 'win10|1803',
         ),
+        luci.console_view_entry(
+            builder = 'ci/win32-arm64-rel',
+            category = 'win32|arm64',
+        ),
         luci.console_view_entry(
             builder = 'ci/win-celab-builder-rel',
             category = 'celab',

infra/config/consoles/chromium.star

@@ -36,12 +36,22 @@ luci.console_view(
         ),
         luci.console_view_entry(
             builder = 'ci/win32-archive-rel',
-            category = 'win-rel',
+            category = 'win|rel',
             short_name = '32',
         ),
         luci.console_view_entry(
             builder = 'ci/win-archive-rel',
-            category = 'win-rel',
+            category = 'win|rel',
+            short_name = '64',
+        ),
+        luci.console_view_entry(
+            builder = 'ci/win32-archive-dbg',
+            category = 'win|dbg',
+            short_name = '32',
+        ),
+        luci.console_view_entry(
+            builder = 'ci/win-archive-dbg',
+            category = 'win|dbg',
             short_name = '64',
         ),
     ],

infra/config/consoles/findit.star

+luci.list_view(
+    name = 'findit',
+    entries = [
+        'findit/findit-rerun',
+        'findit/findit_variable',
+        'findit/linux_chromium_bot_db_exporter',
+    ],
+)

infra/config/consoles/tryserver.chromium.dawn.star

+luci.list_view(
+    name = 'tryserver.chromium.dawn',
+    entries = [
+        'try/dawn-linux-x64-deps-rel',
+        'try/dawn-mac-x64-deps-rel',
+        'try/dawn-win10-x64-deps-rel',
+        'try/dawn-win10-x86-deps-rel',
+        'try/linux-dawn-rel',
+        'try/mac-dawn-rel',
+        'try/win-dawn-rel',
+    ],
+)

infra/config/consoles/tryserver.chromium.linux.star

@@ -28,6 +28,7 @@ luci.list_view(
         'try/layout_test_leak_detection',
         'try/leak_detection_linux',
         'try/linux-annotator-rel',
+        'try/linux-dcheck-off-rel',
         'try/linux-gcc-rel',
         'try/linux-libfuzzer-asan-rel',
         'try/linux-ozone-rel',
@@ -35,6 +36,7 @@ luci.list_view(
         'try/linux-clang-tidy-dbg',
         'try/linux-clang-tidy-rel',
         'try/linux-trusty-rel',
+        'try/linux-webkit-msan-rel',
         'try/linux_arm',
         'try/linux_chromium_analysis',
         'try/linux_chromium_archive_rel_ng',

infra/config/consoles/tryserver.chromium.win.star

@@ -17,6 +17,8 @@ luci.list_view(
         'try/gpu-fyi-try-win10-nvidia-rel-32',
         'try/gpu-fyi-try-win10-nvidia-rel-64',
         'try/gpu-fyi-try-win10-nvidia-skgl-64',
+        'try/gpu-try-win10-nvidia-rel',
+        'try/win-asan',
         'try/win-libfuzzer-asan-rel',
         'try/win7-rel',
         'try/win10_chromium_x64_dbg_ng',

infra/config/main.star

@@ -81,6 +81,7 @@ exec('//buckets/try.star')
 exec('//buckets/webrtc.star')
 exec('//buckets/webrtc.fyi.star')
 
+exec('//consoles/android.packager.star')
 exec('//consoles/angle.try.star')
 exec('//consoles/chromium.star')
 exec('//consoles/chromium.android.star')
@@ -102,6 +103,7 @@ exec('//consoles/chromium.memory.star')
 exec('//consoles/chromium.webrtc.star')
 exec('//consoles/chromium.webrtc.fyi.star')
 exec('//consoles/chromium.win.star')
+exec('//consoles/findit.star')
 exec('//consoles/goma.latest.star')
 exec('//consoles/luci.chromium.goma.star')
 exec('//consoles/luci.chromium.try.star')
@@ -110,8 +112,11 @@ exec('//consoles/sheriff.ios.star')
 exec('//consoles/tryserver.blink.star')
 exec('//consoles/tryserver.chromium.android.star')
 exec('//consoles/tryserver.chromium.chromiumos.star')
+exec('//consoles/tryserver.chromium.dawn.star')
 exec('//consoles/tryserver.chromium.linux.star')
 exec('//consoles/tryserver.chromium.mac.star')
 exec('//consoles/tryserver.chromium.win.star')
 
-exec('//cq-builders-md.star')
+exec('//generators/cq-builders-md.star')
+
+exec('//validators/builders-in-consoles.star')

infra/config/validators/builders-in-consoles.star

+def _validate_builders_in_console(ctx):
+  builders = {}
+
+  for console in ctx.output['luci-milo.cfg'].consoles:
+    for builder in console.builders:
+      for name in builder.name:
+        _, long_bucket, builder_name = name.split('/')
+        _, _, bucket = long_bucket.split('.', 2)
+        builders.setdefault(bucket, {})[builder_name] = True
+
+  builders_without_console = []
+
+  for bucket in ctx.output['cr-buildbucket.cfg'].buckets:
+    bucket_builders = builders.get(bucket.name, {})
+    for builder in bucket.swarming.builders:
+      if builder.name not in bucket_builders:
+        builders_without_console.append(
+            '{}/{}'.format(bucket.name, builder.name))
+
+  if builders_without_console:
+    fail('The following builders do not appear in any console:\n  '
+         + '\n  '.join([repr(b) for b in builders_without_console]))
+
+lucicfg.generator(_validate_builders_in_console)